From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web11.3084.1585736082545390242 for ; Wed, 01 Apr 2020 03:14:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=JGCWC+mG; spf=pass (domain: nuviainc.com, ip: 209.85.221.65, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f65.google.com with SMTP id t7so29817819wrw.12 for ; Wed, 01 Apr 2020 03:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4eWMUmB/TM1TWtUKaO+J2WZmX3FEf4B/tC0L20scLj8=; b=JGCWC+mGHg/bU/rCfH7rA1yCgJaKT0raYl2O2r/tca8f+/FnTbmXW6ukvQUY5u7GSB ABTjCgJo9P3I9WfU7baSTjdWV45JdxrWYrONFHMY94jUQ3hrFDShpMWX71m/mIHArX7H rpk7TmL+7O5RP6GJKK0AUVZCvtF72LoWc52p/zfFA9xFdOPjO/SQAxryxg6GA2JsG2h/ q5To0Stf+lbVpzbAjg0BMDN3FjJA8ELJmhN2whI9jAU/lcPvQaKEskwKBe3oh4+ImoOw wqkinhos74tInzFwyAinc6/uhYFSLtXDJptAH+TeQd2nHrUkIdLtHsmM7weEqZ4IyBoG v9CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4eWMUmB/TM1TWtUKaO+J2WZmX3FEf4B/tC0L20scLj8=; b=HwjwIzjEiPjOPlKH76IiOAYq465irMdJydhhTbxR6JS2U9YU92KeAvTtJTJgSEkhDo 8JdDbXhypI0YDLmnlMk9UV1B98UP5jGwEtyhnGTQncxWckWizfBBQaoZ5fVOiN7eP4z9 1HM+q1qNbg5aP0dnFpiQHMOsBYV1VN5+GfWbsjeIrMD0j5+Xrd91g0f5FSz1uFEkg1uK fVfbo4eZ7zJiFsOyboojOIBvPpnWHnx1BtlqEH0GjKASkWtA1+R5kahcC7kOHDfWGy+h ni701zB7ZT1MPNNfKpGB4Hd2Nfc7jH5ZEhFq6GIufhsNDtLEK5K4FcrG94PHBpB7yz+a rRGQ== X-Gm-Message-State: ANhLgQ2q5YRB+HhlVq5DsNxYkHU4lvJgRVoxMRVMiiTg6xChhsAhqo2A D7z4x7KErkTggjtPPa31MY4KyA== X-Google-Smtp-Source: ADFU+vuwgsVo2m4HD6SxZK/exxAZOE+QR/Ro4FLpvv/9ENW6oOnGpYKa7vS9GAY8R+4rCmuaN+fQyA== X-Received: by 2002:adf:f852:: with SMTP id d18mr26735616wrq.172.1585736081126; Wed, 01 Apr 2020 03:14:41 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id t5sm2442907wrr.93.2020.04.01.03.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 03:14:40 -0700 (PDT) Date: Wed, 1 Apr 2020 11:14:38 +0100 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 14/28] Platform/NXP: rename the ArmPlatformLib as per ArmPlatformPkg Message-ID: <20200401101438.GV7468@vanye> References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-15-pankaj.bansal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <20200320143543.18615-15-pankaj.bansal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 20, 2020 at 20:05:29 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Keep the names and location of files as mentioned in ArmPlatformPkg. > This helps in porting the common changes (if any in future) easily. > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 2 +- > .../AArch64/ArmPlatformHelper.S} | 2 +- > .../Library/{PlatformLib => ArmPlatformLib}/ArmPlatformLib.c | 2 +- > .../{PlatformLib => ArmPlatformLib}/ArmPlatformLib.inf | 4 ++-- > .../NxpQoriqLsMem.c => ArmPlatformLib/ArmPlatformLibMem.c} | 0 > 5 files changed, 5 insertions(+), 5 deletions(-) > rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib/NxpQoriqLsHelper.S => ArmPlatformLib/AArch64/ArmPlatformHelper.S} (88%) > rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib => ArmPlatformLib}/ArmPlatformLib.c (93%) > rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib => ArmPlatformLib}/ArmPlatformLib.inf (89%) > rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib/NxpQoriqLsMem.c => ArmPlatformLib/ArmPlatformLibMem.c} (100%) > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > index 1975f2c4c52c..e5383aaf0cc5 100644 > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc > @@ -26,7 +26,7 @@ [Defines] > !include Silicon/NXP/LS1043A/LS1043A.dsc.inc > > [LibraryClasses.common] > - ArmPlatformLib|Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > + ArmPlatformLib|Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > RealTimeClockLib|Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.inf > > [PcdsFixedAtBuild.common] > diff --git a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/AArch64/ArmPlatformHelper.S > similarity index 88% > rename from Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S > rename to Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/AArch64/ArmPlatformHelper.S > index 84ee8c9f9700..dfbf73675a2d 100644 > --- a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S > +++ b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/AArch64/ArmPlatformHelper.S > @@ -1,7 +1,7 @@ > # @file > # > # Copyright (c) 2012-2013, ARM Limited. All rights reserved. > -# Copyright 2017 NXP > +# Copyright 2017, 2020 NXP > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > diff --git a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.c b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c > similarity index 93% > rename from Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.c > rename to Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c > index eac7d4aa4e47..718c71bf02eb 100644 > --- a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.c > +++ b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c > @@ -6,7 +6,7 @@ > * > * Copyright (c) 2011-2012, ARM Limited. All rights reserved. > * Copyright (c) 2016, Freescale Semiconductor, Inc. All rights reserved. > -* Copyright 2017 NXP > +* Copyright 2017, 2020 NXP > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > **/ > diff --git a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > similarity index 89% > rename from Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > rename to Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > index 7563a1c43630..7a43ad86d183 100644 > --- a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf > +++ b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf > @@ -27,8 +27,8 @@ [LibraryClasses] > SocLib > > [Sources.common] > - NxpQoriqLsHelper.S | GCC > - NxpQoriqLsMem.c > + AArch64/ArmPlatformHelper.S | GCC > + ArmPlatformLibMem.c > ArmPlatformLib.c > > [Ppis] > diff --git a/Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem.c > similarity index 100% > rename from Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c > rename to Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem.c > -- > 2.17.1 >