From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web11.8254.1585750813492551327 for ; Wed, 01 Apr 2020 07:20:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=w+HpPu8w; spf=pass (domain: nuviainc.com, ip: 209.85.128.65, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f65.google.com with SMTP id i19so7454195wmb.0 for ; Wed, 01 Apr 2020 07:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QslsVcIk1ayIA7QzIi6AKC7OZ2JGDnZxWl45yqMaTZ8=; b=w+HpPu8w2SwNaGJhNswc3rXZpqxRUTbgK9Np7DLj8V+nnFD0lL+nJbMB2lTyaY+Lw6 JRKepFVaXCg+I+5MXSCt4qIf3bojSl9ojyn6GMLC9gYuUyCW/nnWNPl3/dvzP51ko0jw VDmqKj8LeomqXitr8fdXn0e1ZN2qqMQqZW2jZJQT3zdNy1o91dH4E4g76uxsHu/4eEjv T/IcslvclcJnoXt5MolLQC3LN0PNKLeyDe+ZizSKO4tVhwpKxLhfHBacgXgXABHVHcfC RCDAozEWprBk8auXjfaEtvidV0Yh2zAkHgF5+QYJbr5cbxQbY4IfsnShQyV2vqYmNfrS 2/uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QslsVcIk1ayIA7QzIi6AKC7OZ2JGDnZxWl45yqMaTZ8=; b=oi87qx3PSso4KBZsSwgmXwJvhtGrhldWWwcE4OxsZ4L6mq76TfPxJaPypv2vsTrBs1 G976Eb9Aw+ry5uV0Zpqj2ezncCYHV96dSBH88M0SPL2JJPvUHw71Z1dXMLG5s0+zGIjN gnpuhPgSr+ATt5xXvIxT+gqSjR28z4Il7P0yOutcBfvSZVS/cwe7hj9575SvoKavXh19 CMgbg7VuIQRFRgHvRqoGjxfL5hmh/GNsGWZzUalu5OtpwNPlgjNJhTM/trhliG3vwrsl mhyzRYJ+FKuu+HnzAbKv1p0II7upYkTaiMM1mdJsOZGKFXVe03lUXuqUz3HHC3ifqbXy ywxQ== X-Gm-Message-State: AGi0PuYBb15cfiycSL0N3BPkmoyiQRILYjfT5RT6eR9d81DS2fEomRZL +gWgcoJnOaFztoPhwx5A/1QBCA== X-Google-Smtp-Source: APiQypIOg9VOxz8y0p0J8aRhye6DeJvHy68vL2vgUXcrKFoxm+iXOYnF4SouFoTWT8gcxoF73Fr6TA== X-Received: by 2002:a7b:c842:: with SMTP id c2mr4797038wml.154.1585750812156; Wed, 01 Apr 2020 07:20:12 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id k83sm7330894wma.3.2020.04.01.07.20.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 07:20:11 -0700 (PDT) Date: Wed, 1 Apr 2020 15:20:09 +0100 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 20/28] Silicon/NXP/LS1043A: Move SocLib to Soc Package Message-ID: <20200401142009.GC7468@vanye> References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-21-pankaj.bansal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <20200320143543.18615-21-pankaj.bansal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 20, 2020 at 20:05:35 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > The SocLib contains code specific to an Soc. it should be part of > SOC package. > Therefore, move the SocLib to Soc Package. > Since we are moving the files to Soc Package, no need to mention the > Soc name in file names. Their location is enough to indicate for which > Soc the files are. > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm > --- > Silicon/NXP/LS1043A/LS1043A.dsc.inc | 2 +- > .../SocLib/Chassis2/Soc.c => LS1043A/Library/SocLib/SocLib.c} | 0 > .../LS1043aSocLib.inf => LS1043A/Library/SocLib/SocLib.inf} | 2 +- > 3 files changed, 2 insertions(+), 2 deletions(-) > rename Silicon/NXP/{Library/SocLib/Chassis2/Soc.c => LS1043A/Library/SocLib/SocLib.c} (100%) > rename Silicon/NXP/{Library/SocLib/LS1043aSocLib.inf => LS1043A/Library/SocLib/SocLib.inf} (92%) > > diff --git a/Silicon/NXP/LS1043A/LS1043A.dsc.inc b/Silicon/NXP/LS1043A/LS1043A.dsc.inc > index 7e75d5b7cba9..a5942c0f2c9c 100644 > --- a/Silicon/NXP/LS1043A/LS1043A.dsc.inc > +++ b/Silicon/NXP/LS1043A/LS1043A.dsc.inc > @@ -11,7 +11,7 @@ > > [LibraryClasses.common] > PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf > - SocLib|Silicon/NXP/Library/SocLib/LS1043aSocLib.inf > + SocLib|Silicon/NXP/LS1043A/Library/SocLib/SocLib.inf > SerialUartClockLib|Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > > diff --git a/Silicon/NXP/Library/SocLib/Chassis2/Soc.c b/Silicon/NXP/LS1043A/Library/SocLib/SocLib.c > similarity index 100% > rename from Silicon/NXP/Library/SocLib/Chassis2/Soc.c > rename to Silicon/NXP/LS1043A/Library/SocLib/SocLib.c > diff --git a/Silicon/NXP/Library/SocLib/LS1043aSocLib.inf b/Silicon/NXP/LS1043A/Library/SocLib/SocLib.inf > similarity index 92% > rename from Silicon/NXP/Library/SocLib/LS1043aSocLib.inf > rename to Silicon/NXP/LS1043A/Library/SocLib/SocLib.inf > index 1d042bbfc4e4..3d0f988e1c67 100644 > --- a/Silicon/NXP/Library/SocLib/LS1043aSocLib.inf > +++ b/Silicon/NXP/LS1043A/Library/SocLib/SocLib.inf > @@ -24,4 +24,4 @@ [LibraryClasses] > DebugLib > > [Sources.common] > - Chassis2/Soc.c > + SocLib.c > -- > 2.17.1 >