From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web11.161.1585770786369104256 for ; Wed, 01 Apr 2020 12:53:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=zVNOQv+w; spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f66.google.com with SMTP id d5so1566401wrn.2 for ; Wed, 01 Apr 2020 12:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=poJje4ngUUhQzxYFH/AaIwgsfFwgFL+4I8Tm2B9h1d8=; b=zVNOQv+wDuRBaYmT2q88lMXafs1b+pb/rHE6vGsQ7srz+DEIsRx4lC/H7BBaDYxzF6 B55w9Z59TefgNCnNts/y95ILujH0d4mUmpI6lCsBIXzVo7Si2SaVYtAgkw8px0OzQn+1 IFOLIG7BOGCkuyGCW044h1rvFhMLKIb1V6vZUBEfmeXL5qIklpVG8/MZvPESwGHYRtrA A2Oth+HWj8uNZdDUkYutbj671XgrkussJ4rvL0Ecs1HIKhvmj18Hbrz5aoJv89ge1e/P TYiGrXrOOH04+ShdzVDMsvoWbkNHsd4U7tm06Gs0yT2olDPC59rVC2UK7Oh3yyVykbVE U3yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=poJje4ngUUhQzxYFH/AaIwgsfFwgFL+4I8Tm2B9h1d8=; b=Ne56lPC8HQgIUYpdEAnZ6a1DxVvWRQAGXR2FkxADquXQ3oUnYrALGaH9BGNDVHrsnz A4+5kLytQPHMNjlfSfbpHhM+AYE1fwLwV7fOr5M/FsNe2paDxCulIAzPCjEVPZdw2fKI iF6Z95VG7r2qVnFfu3vOVFuKRaAjbFgLpnipOg4KAt1LakCo5May6NGDJkd/MkFNRpIo Vxk3Y0u4GmIBh2ZcFT/OllJsDbqAppOsaAQjvelHjtf7f+nMpSKKbw4kkrGkGP82A7t3 ek1FZ03rNHyS3mXtj+qqEUYegg+z3g0WNpKAEtLjZ45aT87/u8jOdZ25ea2Ga6D1E3mt spug== X-Gm-Message-State: ANhLgQ1MMat3nBIYE3DM99lz+lMmnbFLB5ewrWzA+rXyB5OEpHOf+AEI XsQx65uAOvZy3enF5AYmMbmlUQ== X-Google-Smtp-Source: ADFU+vugv1XO9kX5ohV+kVHmneY68R2WWxEySjCQDradQHk55N26ruh0iW08RT0E3k4duAPsNXIUHw== X-Received: by 2002:adf:f58c:: with SMTP id f12mr29281309wro.207.1585770785015; Wed, 01 Apr 2020 12:53:05 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id x16sm4285110wrn.71.2020.04.01.12.53.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 12:53:04 -0700 (PDT) Date: Wed, 1 Apr 2020 20:53:02 +0100 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 24/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Remove extern SocInit Message-ID: <20200401195302.GG7468@vanye> References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-25-pankaj.bansal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <20200320143543.18615-25-pankaj.bansal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 20, 2020 at 20:05:39 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > SocInit can be defined in SocLib.h > No need to make it extern in ArmPlatformLib > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm But do please move it as early as possible in the series. > --- > .../LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 2 -- > Silicon/NXP/Include/Library/SocLib.h | 8 ++++++++ > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c > index 1e2e85f87dfe..dc81e7ba3101 100644 > --- a/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c > +++ b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c > @@ -16,8 +16,6 @@ > #include > #include > > -extern VOID SocInit (VOID); > - > /** > Get the clocks supplied by Platform(Board) to NXP Layerscape SOC IPs > > diff --git a/Silicon/NXP/Include/Library/SocLib.h b/Silicon/NXP/Include/Library/SocLib.h > index 749aa230dec5..0ca68602618d 100644 > --- a/Silicon/NXP/Include/Library/SocLib.h > +++ b/Silicon/NXP/Include/Library/SocLib.h > @@ -41,4 +41,12 @@ SocGetClock ( > IN VA_LIST Args > ); > > +/** > + Function to initialize SoC specific constructs > + **/ > +VOID > +SocInit ( > + VOID > + ); > + > #endif // SOC_LIB_H__ > -- > 2.17.1 >