From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web10.266.1585771049823993593 for ; Wed, 01 Apr 2020 12:57:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=Z+g08OAa; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id a81so1106144wmf.5 for ; Wed, 01 Apr 2020 12:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Xf1fHwABaNqvvOpec5yuxw72IXlyov/q6avMFV2uXIY=; b=Z+g08OAaFmQ4iHhmkCOELSx9IaHq/9BMg8HM1mdz8ZDrGIlwd4xOqZvZ4xGgdb+9DF Wq3LnfXyNG+OE9jAh7PdVVY/voZo+2Apz5J4h62d7kyISNs9o3QjflBERXVjdtkSoZ1P MY73YImxTu1cVsqOFc2z5gIjZXVnFtrclNj3zthjibMrcSt+VHkprBEa6twjptwGIzqS ynf+BO13AKHe4cU2ggwHpRK+blPht+RVLsj614um4IJrd/qfmjf4cKj+k4q6vtnGccMQ 8FsKiUPrpJ1bfJ82kX47FlX++6n15d0u1KO8blDPZpWUq5Tq2SIG6qiI+zoTWZ/MQOOq j0tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Xf1fHwABaNqvvOpec5yuxw72IXlyov/q6avMFV2uXIY=; b=REwOKhquLSQ2NIr4PF1PugmWXVSrkzf88eAeuR2Qje/kFzlJnSE0q/kMfgBIaJOHdn 2NRV4qLnME1eBDsLxpc8UCoVGO6zlN5pFoe5hGS2sGAtkIn1KyWeABnIQychfkUeq3ku zebUv7WxHxt9tGXZcpU+F467JgPQTcccbiajnpc+XD+syZ2DweML48IjkcYC+VH08New tEd/T3ehBaaEXuRqLFOnX8eqSJ0782H6VxG0miVNLf5yZGfkw4FVWba+8GYKoAhGHK5T B9Fb8BphdabNyqmDfXHsoNS07+mc32g057uKyKb540bwA1CpXEQTafQR7QzIFP+VXtBX uPLQ== X-Gm-Message-State: AGi0PubadB4cKENYR6J9X4njwl6pDPISDIlZSbCdj45ps/RLaqdrgUQP ix6D0Kzcwm+HvzKkH8qSWaMN7g== X-Google-Smtp-Source: APiQypLEXUJgKfTpj5EoxFA1yGdQ00bhjS1naPSOkicOtTBZegdT70iSwhqhRCD6F0Wnz8+KbEJqKw== X-Received: by 2002:a1c:9658:: with SMTP id y85mr41585wmd.63.1585771048384; Wed, 01 Apr 2020 12:57:28 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id c4sm3937478wmb.5.2020.04.01.12.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 12:57:27 -0700 (PDT) Date: Wed, 1 Apr 2020 20:57:25 +0100 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 25/28] Platform/NXP: Modify FV rules Message-ID: <20200401195725.GH7468@vanye> References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-26-pankaj.bansal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <20200320143543.18615-26-pankaj.bansal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Please make the subject contain information. / Leif On Fri, Mar 20, 2020 at 20:05:40 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Use same FV rules as ArmVirtPkg/ArmVirtRules.fdf.inc > > Signed-off-by: Pankaj Bansal > --- > Platform/NXP/FVRules.fdf.inc | 59 +++++++++++++++++++++++------------- > 1 file changed, 38 insertions(+), 21 deletions(-) > > diff --git a/Platform/NXP/FVRules.fdf.inc b/Platform/NXP/FVRules.fdf.inc > index c9fba65dae85..63de26abe056 100644 > --- a/Platform/NXP/FVRules.fdf.inc > +++ b/Platform/NXP/FVRules.fdf.inc > @@ -1,8 +1,7 @@ > -# FvRules.fdf.inc > # > -# Rules for creating FD. > -# > -# Copyright 2017-2019 NXP > +# Copyright (c) 2011-2015, ARM Limited. All rights reserved. > +# Copyright (c) 2014-2016, Linaro Limited. All rights reserved. > +# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -16,40 +15,49 @@ > # > ################################################################################ > > + > +############################################################################ > +# Example of a DXE_DRIVER FFS file with a Checksum encapsulation section # > +############################################################################ > +# > +#[Rule.Common.DXE_DRIVER] > +# FILE DRIVER = $(NAMED_GUID) { > +# DXE_DEPEX DXE_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > +# COMPRESS PI_STD { > +# GUIDED { > +# PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > +# UI STRING="$(MODULE_NAME)" Optional > +# VERSION STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER) > +# } > +# } > +# } > +# > +############################################################################ > + > [Rule.Common.SEC] > - FILE SEC = $(NAMED_GUID) RELOCS_STRIPPED { > - TE TE Align = 32 $(INF_OUTPUT)/$(MODULE_NAME).efi > + FILE SEC = $(NAMED_GUID) RELOCS_STRIPPED FIXED { > + TE TE Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi > } > > [Rule.Common.PEI_CORE] > - FILE PEI_CORE = $(NAMED_GUID) { > - TE TE $(INF_OUTPUT)/$(MODULE_NAME).efi > + FILE PEI_CORE = $(NAMED_GUID) FIXED { > + TE TE Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi > UI STRING ="$(MODULE_NAME)" Optional > } > > [Rule.Common.PEIM] > - FILE PEIM = $(NAMED_GUID) { > + FILE PEIM = $(NAMED_GUID) FIXED { > PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > + TE TE Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi > UI STRING="$(MODULE_NAME)" Optional > } > > -[Rule.Common.PEIM.TIANOCOMPRESSED] > - FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 { > - PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > - GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE { > - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > - UI STRING="$(MODULE_NAME)" Optional > - } > - } > - > [Rule.Common.DXE_CORE] > FILE DXE_CORE = $(NAMED_GUID) { > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > UI STRING="$(MODULE_NAME)" Optional > } > > - > [Rule.Common.UEFI_DRIVER] > FILE DRIVER = $(NAMED_GUID) { > DXE_DEPEX DXE_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > @@ -62,6 +70,8 @@ [Rule.Common.DXE_DRIVER] > DXE_DEPEX DXE_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > UI STRING="$(MODULE_NAME)" Optional > + RAW ACPI Optional |.acpi > + RAW ASL Optional |.aml > } > > [Rule.Common.DXE_RUNTIME_DRIVER] > @@ -73,7 +83,7 @@ [Rule.Common.DXE_RUNTIME_DRIVER] > > [Rule.Common.UEFI_APPLICATION] > FILE APPLICATION = $(NAMED_GUID) { > - UI STRING ="$(MODULE_NAME)" Optional > + UI STRING ="$(MODULE_NAME)" Optional > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > } > > @@ -91,3 +101,10 @@ [Rule.Common.UEFI_APPLICATION.BINARY] > UI STRING="$(MODULE_NAME)" Optional > VERSION STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER) > } > + > +[Rule.Common.USER_DEFINED.ACPITABLE] > + FILE FREEFORM = $(NAMED_GUID) { > + RAW ACPI |.acpi > + RAW ASL |.aml > + UI STRING="$(MODULE_NAME)" Optional > + } > -- > 2.17.1 >