From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web11.297.1585771155443444324 for ; Wed, 01 Apr 2020 12:59:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=UCeAZJ3l; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id f6so1137193wmj.3 for ; Wed, 01 Apr 2020 12:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=R0uZsb7STyVGEJslCMKU40GI0VS9fx7NvXVKYX4+1WE=; b=UCeAZJ3lYVpLxwDYinP1EXP79iETd1guTn9ePYFcZxEz6f2xfOcrxqK644wYvptm9f B+9O5niWLTZQ6tC6uBJgW9Ry2tZWtXlwwxYj5yhKHMZXE6oGJuHsFO+AjHAp4pQG7UqQ NNHQBqdQZtnb0QqjMUh5d5CYYfGAuUNsuRPV33X1Lp5SqYoCf0pKDLgcn26wBEo06gBX cuJpbubLmWljGrXQOfLZnOeFLpY1bL0K4g9eXQEi29X95Z01s1unzMe/8zupG6Wggmb5 GBtGD7BllROmVtdcHxculLnbHljzMH+xNQU2DZiqLJXb0bQKQ+X1Fma8s3MsdYYBepRb ryNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=R0uZsb7STyVGEJslCMKU40GI0VS9fx7NvXVKYX4+1WE=; b=tgu5dkcRDcex9gAkIe85FmUX80gs4bPKwQrmZY5dOtjEGXZoQpjctJy4fLYBFZCXzT i40wd82t/dKZeHDb5RGQI5Oc6hiyMgqtT3aKlCwtJG1ace/9nFlQREIYS/GJjMcubpKX ahVIfzxN5pBdcdDxCcqev9uoa2qwSMjj2jKXQ+pjnKgXpufwhbPnQvo9fpI3uW8+jSqb zfm4qnBya9/+62A3rx9B54L/9DGzcxk+tbBS7y7bJXgVoofyLHtPomzw40IT+adIK7d0 UqqEO81vkC/uZFgJII5GbNeXG2ixg3TFHx92OA1iH3EQkzmEJMx2Hcm8Nw3SWn5ipSI5 cDvA== X-Gm-Message-State: AGi0PuZayOLgVKReeem5wQA/92R7qX4zss7di+l2RCBqByTLlcC4K3Yw YT3t7kxUFEXsbzeraeEVnMv1vQ== X-Google-Smtp-Source: APiQypI1GVxzVtth4sEWmC/Kg4KWuS/sP1B/RNWoLFKGXvZCPSpVPLw+KOq+lQTe+pb5Vd4kKHSgrw== X-Received: by 2002:a7b:c5cd:: with SMTP id n13mr35840wmk.125.1585771153929; Wed, 01 Apr 2020 12:59:13 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id d206sm3888215wmf.29.2020.04.01.12.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 12:59:13 -0700 (PDT) Date: Wed, 1 Apr 2020 20:59:11 +0100 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 26/28] Platform/NXP/LS1043aRdbPkg: Add VarStore Message-ID: <20200401195911.GI7468@vanye> References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-27-pankaj.bansal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <20200320143543.18615-27-pankaj.bansal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 20, 2020 at 20:05:41 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > Add VarStore Fd. This Fd is used to store non volatile variables in > flash. > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm > --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 3 +- > Platform/NXP/LS1043aRdbPkg/VarStore.fdf.inc | 91 ++++++++++++++++++++ > 2 files changed, 93 insertions(+), 1 deletion(-) > create mode 100644 Platform/NXP/LS1043aRdbPkg/VarStore.fdf.inc > > diff --git a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > index 8d66f36d7407..99fbc87e1200 100644 > --- a/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > +++ b/Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf > @@ -3,7 +3,7 @@ > # FLASH layout file for LS1043a board. > # > # Copyright (c) 2016, Freescale Ltd. All rights reserved. > -# Copyright 2017-2019 NXP > +# Copyright 2017-2020 NXP > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -49,6 +49,7 @@ [FD.LS1043ARDB_EFI] > FV = FVMAIN_COMPACT > > !include Platform/NXP/FVRules.fdf.inc > +!include VarStore.fdf.inc > ################################################################################ > # > # FV Section > diff --git a/Platform/NXP/LS1043aRdbPkg/VarStore.fdf.inc b/Platform/NXP/LS1043aRdbPkg/VarStore.fdf.inc > new file mode 100644 > index 000000000000..391e4ae5eaf8 > --- /dev/null > +++ b/Platform/NXP/LS1043aRdbPkg/VarStore.fdf.inc > @@ -0,0 +1,91 @@ > +## @file > +# FDF include file with FD definition that defines an empty variable store. > +# > +# Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved. > +# Copyright (C) 2014, Red Hat, Inc. > +# Copyright (c) 2016, Linaro, Ltd. All rights reserved. > +# Copyright (c) 2016, Freescale Semiconductor. All rights reserved. > +# Copyright 2017-2020 NXP > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +## > + > +[FD.LS1043aRdbNv_EFI] > +BaseAddress = 0x60500000 #The base address of the FLASH device > +Size = 0x000C0000 #The size in bytes of the FLASH device > +ErasePolarity = 1 > +BlockSize = 0x40000 > +NumBlocks = 0x3 > + > +# > +# Place NV Storage just above Platform Data Base > +# > +DEFINE NVRAM_AREA_VARIABLE_BASE = 0x00000000 > +DEFINE NVRAM_AREA_VARIABLE_SIZE = 0x00040000 > +DEFINE FTW_WORKING_BASE = $(NVRAM_AREA_VARIABLE_BASE) + $(NVRAM_AREA_VARIABLE_SIZE) > +DEFINE FTW_WORKING_SIZE = 0x00040000 > +DEFINE FTW_SPARE_BASE = $(FTW_WORKING_BASE) + $(FTW_WORKING_SIZE) > +DEFINE FTW_SPARE_SIZE = 0x00040000 > + > +############################################################################# > +# LS1043ARDB NVRAM Area > +# LS1043ARDB NVRAM Area contains: Variable + FTW Working + FTW Spare > +############################################################################# > + > + > +$(NVRAM_AREA_VARIABLE_BASE)|$(NVRAM_AREA_VARIABLE_SIZE) > +gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize > +#NV_VARIABLE_STORE > +DATA = { > + ## This is the EFI_FIRMWARE_VOLUME_HEADER > + # ZeroVector [] > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + # FileSystemGuid: gEfiSystemNvDataFvGuid = > + # { 0xFFF12B8D, 0x7696, 0x4C8B, > + # { 0xA9, 0x85, 0x27, 0x47, 0x07, 0x5B, 0x4F, 0x50 }} > + 0x8D, 0x2B, 0xF1, 0xFF, 0x96, 0x76, 0x8B, 0x4C, > + 0xA9, 0x85, 0x27, 0x47, 0x07, 0x5B, 0x4F, 0x50, > + # FvLength: 0xC0000 > + 0x00, 0x00, 0x0C, 0x00, 0x00, 0x00, 0x00, 0x00, > + # Signature "_FVH" # Attributes > + 0x5f, 0x46, 0x56, 0x48, 0x36, 0x0E, 0x00, 0x00, > + # HeaderLength # CheckSum # ExtHeaderOffset #Reserved #Revision > + 0x48, 0x00, 0xC2, 0xF9, 0x00, 0x00, 0x00, 0x02, > + # Blockmap[0]: 0x3 Blocks * 0x40000 Bytes / Block > + 0x38, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, > + # Blockmap[1]: End > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + ## This is the VARIABLE_STORE_HEADER > + # It is compatible with SECURE_BOOT_ENABLE == FALSE as well. > + # Signature: gEfiVariableGuid = > + # { 0xddcf3616, 0x3275, 0x4164, > + # { 0x98, 0xb6, 0xfe, 0x85, 0x70, 0x7f, 0xfe, 0x7d }} > + 0x16, 0x36, 0xcf, 0xdd, 0x75, 0x32, 0x64, 0x41, > + 0x98, 0xb6, 0xfe, 0x85, 0x70, 0x7f, 0xfe, 0x7d, > + # Size: 0x40000 (gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize) - > + # 0x48 (size of EFI_FIRMWARE_VOLUME_HEADER) = 0x3ffb8 > + # This can speed up the Variable Dispatch a bit. > + 0xB8, 0xFF, 0x03, 0x00, > + # FORMATTED: 0x5A #HEALTHY: 0xFE #Reserved: UINT16 #Reserved1: UINT32 > + 0x5A, 0xFE, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 > +} > + > +$(FTW_WORKING_BASE)|$(FTW_WORKING_SIZE) > +gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase64|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize > +#NV_FTW_WORKING > +DATA = { > + # EFI_FAULT_TOLERANT_WORKING_BLOCK_HEADER->Signature = gEdkiiWorkingBlockSignatureGuid = > + # { 0x9e58292b, 0x7c68, 0x497d, { 0xa0, 0xce, 0x65, 0x0, 0xfd, 0x9f, 0x1b, 0x95 }} > + 0x2b, 0x29, 0x58, 0x9e, 0x68, 0x7c, 0x7d, 0x49, > + 0xa0, 0xce, 0x65, 0x0, 0xfd, 0x9f, 0x1b, 0x95, > + # Crc:UINT32 #WorkingBlockValid:1, WorkingBlockInvalid:1, Reserved > + 0x5b, 0xe7, 0xc6, 0x86, 0xFE, 0xFF, 0xFF, 0xFF, > + # WriteQueueSize: UINT64 > + 0xE0, 0xFF, 0x03, 0x00, 0x00, 0x00, 0x00, 0x00 > +} > + > +$(FTW_SPARE_BASE)|$(FTW_SPARE_SIZE) > +gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase64|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize > +#NV_FTW_SPARE > -- > 2.17.1 >