From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web12.332.1585771216649527388 for ; Wed, 01 Apr 2020 13:00:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=w0ZV0PSY; spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f66.google.com with SMTP id p10so1559450wrt.6 for ; Wed, 01 Apr 2020 13:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oxBZm1d/jWixzJVAM6KcWfSmb4KUpozzy7/xvG5YjwE=; b=w0ZV0PSYLJUJBnCSSOt+BSaGPYPS070ZS1HJyA2Bz8y8F0Zd5lf3S9d00y8nhjkB2r cJ/Y2ij7BZ7YM5LjK45YulQXfQvcXKVr/6HMc6FCw8A6o0fO+Duq+x+sn9SNQF9Ka4Wy SQ0KuFaouTuHzgY2XNmJDlaVxscH/ajdoYTpZ6akRur3Z+rZtTz+zBwT/0cQspdwHUQw oP7IZ+IPRW05a0w8Kc10qpZr7gtyMgST13RAT6W1WpTdxhy6uo0k/DOJCZBH2UdwBCLO QJxERTUcNjHxHp2xI/hVOTQWljwFwlLNEu/1ZyaOw5w7kRiiVoxcoEeCm18vL5lXzqFz yvHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oxBZm1d/jWixzJVAM6KcWfSmb4KUpozzy7/xvG5YjwE=; b=qnD4XN4BHbTvmBP7O7pwCb8jLCg+ghVTWSmFIiUk7ZxPxxQVQfBwoWhqW6HZ3/mKUE mAcXZ5b9MCc4EI9RtxeJF/dhLUq5jfqw3r3FfwyhpKbUzjuTKAByF4HYMV2iySt4GxCM Oc4UeBzL/AmQSNb6uROGdWHrUXSgnVbOG4zYKBxsP86zBe+K2XmSxyECA9PLNwNNzCt/ f7wnjXZj7M6gxthofTd6ba+Ldq4HKF4mj9cC5W41TsULeDMmFTliJD1mwySAPYBIX0cf vN0fr9Fe+qzdWZo6vUjq5ApBUGTDh+uJY/6vMtNqb1xp74wpGFhMvxKeiGFfOq91MQvx RYFw== X-Gm-Message-State: ANhLgQ2H9dobr6zpvufttgcV+O+1/dnYv598SqacUeA317g4hYz7DEfM QR57UWAv6bevm7sva0ATYvCpVA== X-Google-Smtp-Source: ADFU+vuWqCq25weumPfI0oszIAMJRS8h+RiXwiZ8aJDj4oZviSDGl8+sjCs5OEWPkKhHH3A0i80VmQ== X-Received: by 2002:adf:e282:: with SMTP id v2mr27488656wri.329.1585771215257; Wed, 01 Apr 2020 13:00:15 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id v186sm3910289wme.24.2020.04.01.13.00.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2020 13:00:14 -0700 (PDT) Date: Wed, 1 Apr 2020 21:00:12 +0100 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 27/28] Silicon/NXP: move MemoryInitPeiLib as per PEIM structures Message-ID: <20200401200012.GJ7468@vanye> References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-28-pankaj.bansal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <20200320143543.18615-28-pankaj.bansal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 20, 2020 at 20:05:42 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > MemoryInitPeiLib would be linked to MemoryInitPeim, when we implement > PEI phase. therefore, move the library to directory of same name. > > Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm > --- > .../{MemoryInitPei => MemoryInitPeiLib}/MemoryInitPeiLib.c | 0 > .../{MemoryInitPei => MemoryInitPeiLib}/MemoryInitPeiLib.h | 0 > .../{MemoryInitPei => MemoryInitPeiLib}/MemoryInitPeiLib.inf | 0 > Silicon/NXP/NxpQoriqLs.dsc.inc | 3 +-- > 4 files changed, 1 insertion(+), 2 deletions(-) > rename Silicon/NXP/Library/{MemoryInitPei => MemoryInitPeiLib}/MemoryInitPeiLib.c (100%) > rename Silicon/NXP/Library/{MemoryInitPei => MemoryInitPeiLib}/MemoryInitPeiLib.h (100%) > rename Silicon/NXP/Library/{MemoryInitPei => MemoryInitPeiLib}/MemoryInitPeiLib.inf (100%) > > diff --git a/Silicon/NXP/Library/MemoryInitPei/MemoryInitPeiLib.c b/Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.c > similarity index 100% > rename from Silicon/NXP/Library/MemoryInitPei/MemoryInitPeiLib.c > rename to Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.c > diff --git a/Silicon/NXP/Library/MemoryInitPei/MemoryInitPeiLib.h b/Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.h > similarity index 100% > rename from Silicon/NXP/Library/MemoryInitPei/MemoryInitPeiLib.h > rename to Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.h > diff --git a/Silicon/NXP/Library/MemoryInitPei/MemoryInitPeiLib.inf b/Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf > similarity index 100% > rename from Silicon/NXP/Library/MemoryInitPei/MemoryInitPeiLib.inf > rename to Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf > diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.inc > index 5f77f47f0399..b2b10ce28a93 100644 > --- a/Silicon/NXP/NxpQoriqLs.dsc.inc > +++ b/Silicon/NXP/NxpQoriqLs.dsc.inc > @@ -102,6 +102,7 @@ [LibraryClasses.common] > PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf > > PlatformPeiLib|Silicon/NXP/Library/PlatformPeiLib/PlatformPeiLib.inf > + MemoryInitPeiLib|Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.inf > > [LibraryClasses.common.SEC] > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > @@ -113,7 +114,6 @@ [LibraryClasses.common.SEC] > PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf > MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > - MemoryInitPeiLib|Silicon/NXP/Library/MemoryInitPei/MemoryInitPeiLib.inf > > # 1/123 faster than Stm or Vstm version > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > @@ -143,7 +143,6 @@ [LibraryClasses.common.DXE_DRIVER] > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > - MemoryInitPeiLib|Silicon/NXP/Library/MemoryInitPei/MemoryInitPeiLib.inf > > [LibraryClasses.common.UEFI_APPLICATION] > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > -- > 2.17.1 >