From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web10.3302.1585822992802669210 for ; Thu, 02 Apr 2020 03:23:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=eNf/SayF; spf=pass (domain: nuviainc.com, ip: 209.85.221.68, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f68.google.com with SMTP id t7so3469237wrw.12 for ; Thu, 02 Apr 2020 03:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=DHdEQ53hnj9Fl+/zFGpgKUO/i+ESYepgcerRbiVV2kw=; b=eNf/SayFFI3lIKdUPBpVEJ+Jb585tl4yajp5gwLiHmzxXew+5zJPMcbwLf9YCtjSju gdU3BNnedwP2rZfawZ+Mudp7Ck/+EpvcBiMkL7SOlzBij0E6Lg1hqyicGV3YDotm3Nj5 Q+wK/FFR5pBj7TWsXM1oFytEuA/CMYjQCS/BJa/r0z7sKZZbn+NMKFS5y2S4j6yhj++m MT2vMdVAY+SurRbPnuvjQMA9dDktQWTkMpxfuMrmr21hPS/gQJZrO+VCi9g7CirgUFXt V75OINNE210L4NbddAdI11K2SYEB8X89wQMtL6aGBA0mm3IBMZpE+lyew15JbcDUa9zp XQ4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=DHdEQ53hnj9Fl+/zFGpgKUO/i+ESYepgcerRbiVV2kw=; b=aYiL/wTSghhW1X0u0e8zsgrXG7bbNgRgYEzt1nGZ52LRgKMYLHWaLAafKH7Yy96CMl ytBsizR77dZooOi87SL3X13tFyZdUiMD+j3/WCSBcezh9czjijRcnjBrwE77m9FI8YL0 iPoV+qXMhi4YhcXJ/x30rMLOzatMDUzS1dhq/bhXqf4HEhq6EJbzJesD9hXjLcxU3T5d dTaC2NODG5fmMMcQBwtmNQMRvhl6hseeIqgjgQeg90ZI0GKkLgLmSK7xGZPgJbSrYaCw 5Bu001CrMD4g1aYU7gDdoQm9tT+0K72ZwyN2/n1Y1KLC1MSkr8UUibbmMsXC08n0f6i6 cn1g== X-Gm-Message-State: AGi0PuZRf95ecA8RGYmooBBCx9cGsQw4TIqwVs/HnnXJ3a2TCSDEAk6a gf034x8fdxugISkmlbYC8DweVg== X-Google-Smtp-Source: APiQypLjROjBZQYi7eYeMR6u05Aa7cbHY0w4riT+jatXKkRbIHd0bAEhqt/tExClgdj8Xz715CAF8g== X-Received: by 2002:adf:aa8c:: with SMTP id h12mr546550wrc.54.1585822991230; Thu, 02 Apr 2020 03:23:11 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id e5sm6941549wru.92.2020.04.02.03.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2020 03:23:10 -0700 (PDT) Date: Thu, 2 Apr 2020 11:23:08 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH 5/5] ArmPkg/ArmMmuLib: drop unused TT_ATTR_INDX_INVALID CPP symbol Message-ID: <20200402102308.GM7468@vanye> References: <20200328104321.8668-1-ard.biesheuvel@linaro.org> <20200328104321.8668-6-ard.biesheuvel@linaro.org> MIME-Version: 1.0 In-Reply-To: <20200328104321.8668-6-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Sat, Mar 28, 2020 at 11:43:21 +0100, Ard Biesheuvel wrote: > TT_ATTR_INDX_INVALID is #define'd but never used so drop it. > > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c > index a82596d290f1..222ff817956f 100644 > --- a/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c > +++ b/ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c > @@ -19,9 +19,6 @@ > #include > #include > > -// We use this index definition to define an invalid block entry > -#define TT_ATTR_INDX_INVALID ((UINT32)~0) > - Since this is separately defined also in ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c (£"$%^£"$?!?!?) could this patch be tweaked to instead "consolidate" the definitions to a central location, like ArmPkg/Include/Chipset/AArch64Mmu.h where all of the other TT_ATTR_INDX_ definitions live? / Leif > STATIC > UINT64 > ArmMemoryAttributeToPageAttribute ( > -- > 2.17.1 >