From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web12.8612.1586172297319054699 for ; Mon, 06 Apr 2020 04:24:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=HppYBRT7; spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f67.google.com with SMTP id 65so16995400wrl.1 for ; Mon, 06 Apr 2020 04:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Haqi3ZdbI4EcBcrCwly7lMO6q5pqw8v6BRA/JIdI3+I=; b=HppYBRT7E5qz5o1+0RD4eKfPrpM9tkJp2NuMZzXWdngTqsYXa/hTXSDYoHSYhtaqgn +1oECffxQwIrmr4ONZcsh6zJuFdZ5ns73gQmWNmCtCPg6E7gRstZmui0HKr2yAW5wjKy B/V05L2KD5j4yqPUkTGWCrn1nK7jLlSMKCV1enZbUiVup1y8hxlNl4yvI3dC0KyC2AYY KM7y5myy9TwLfIwEZB7jOPhkPb+ldzC2bh02Nc2lcIzRi4bLjNSdaFP3e+iNdmBPzYLt JsywlEvrFacYQ4MpdV5r/LOWcuapZhR7hIrELFVx592rEcEtmdGdSHeK7/AelrI1Kj1+ S/Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Haqi3ZdbI4EcBcrCwly7lMO6q5pqw8v6BRA/JIdI3+I=; b=bQ24ScWM08c3YQYl3twVqdxQvHcifZZnT6JNucqQXkrNp1Kg+1wFvD+BoDSTaiX6ro WCWdvKvM9dJO/2urpoEm40pPohDdp7iiKgFpYsCMUW8sCKYeyoVmjzSP4deS7cKdTEDc fwWyjzjytfpdw2/u2OrN/CNtN3pLQn42SBrpGLB4i3mKwMbnmTkkLLRR6or/LH4nEi2r mg5lCb8ukHl6z69aH3XwIvPYwB/z1MRn4B334hmAoD3F9FPy6odZCNp12mi5Jdo/bKEo H00z2KV6rWYdN8J8ZTqvEuCXm07cOjJLC1zugpaYNtII2gp90i7LUvkfgW02oIBFkvu2 pjig== X-Gm-Message-State: AGi0PuZenEV8QYDO173NZUBDK+r/6oP+CKonXgp2eaxDY3t4Mp3S3R5X KNLUSLQsSjsGYEKe0OEW6d2xPg== X-Google-Smtp-Source: APiQypI4NGZl1r2Icwi2BdeWLg2qtD49ML7hKQoIOSC8UMb1alrTTyhiRRUCMwB3WmKV4rW0aYbziQ== X-Received: by 2002:a5d:67cb:: with SMTP id n11mr24033815wrw.104.1586172295946; Mon, 06 Apr 2020 04:24:55 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id u22sm24714644wmu.43.2020.04.06.04.24.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 04:24:55 -0700 (PDT) Date: Mon, 6 Apr 2020 12:24:53 +0100 From: "Leif Lindholm" To: "Pankaj Bansal (OSS)" Cc: Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib Message-ID: <20200406112453.GC14075@vanye> References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-8-pankaj.bansal@oss.nxp.com> <20200401095329.GO7468@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 06, 2020 at 06:33:40 +0000, Pankaj Bansal (OSS) wrote: > > > > -----Original Message----- > > From: Leif Lindholm > > Sent: Wednesday, April 1, 2020 3:23 PM > > To: Pankaj Bansal (OSS) > > Cc: Meenakshi Aggarwal ; Michael D Kinney > > ; devel@edk2.groups.io; Varun Sethi > > ; Samer El-Haj-Mahmoud > Mahmoud@arm.com>; Jon Nettleton > > Subject: Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib > > > > On Fri, Mar 20, 2020 at 20:05:22 +0530, Pankaj Bansal wrote: > > > From: Pankaj Bansal > > > > > > Implement SerialUartClockLib for all NXP Layerscape Platforms. > > > > > > Signed-off-by: Pankaj Bansal > > > --- > > > .../SerialUartClockLib/SerialUartClockLib.c | 27 +++++++++++++++++++ > > > .../SerialUartClockLib/SerialUartClockLib.inf | 26 ++++++++++++++++++ > > > > I requested after the initial submission that you "either follow the > > manual git setup steps from > > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt- > > git-guide-for-edk2-contributors-and-maintainers > > or execute edk2/BaseTools/Scripts/SetupGit.py in each of the tianocore > > repositories" > > > > Now, neither appears to have happened, as .c still comes before .inf > > and paths are still truncated. > > I had executed the SetupGit.py script, I will check again. > > > > > But in addition to that, we realised that git happily ignores settings > > for --stat. So, please, execute aforementioned script, but then > > generate v3 with --stat=1000 --stat-graph-width=20. > > > > Ok. I will follow these steps as well. > > > For this particular patch, the side discussion on the edk2 portion may > > make it redundant, so I'm deferring review. > > Right now, I am yet to work on the review comments of other edk2 patch > and since it touches other platforms as well, it requires thorough vetting from other > platform maintainers. It seems like that would take more time. If I send this patch > series without removing DuartLib (i.e. drop patches 7, 8, 9 from this series), can you > please merge. Parallelly, I will work on edk2 patch and once that is accepted, I will send > patches 7, 8, 9 after that in new series ? See comment in my previous email on merging code only to remove it shortly afterwards. As you have seen on that thread, a couple of proposals have been made for how to fix this without affecting other platforms (the HOB variant[1] and the separate .inf[2] variant). I will keep chasing on that occasionally, but please also contribute to that conversation yourself. / Leif [1] https://edk2.groups.io/g/devel/message/56605 [2] https://edk2.groups.io/g/devel/message/56767