Re: [PATCH edk2-platforms 0/2] SynQuacer: fix driver model integration of NetSec

["Leif Lindholm" <leif@nuviainc.com>]

On Wed, Apr 08, 2020 at 18:11:36 +0200, Ard Biesheuvel wrote:
> Currently, the way the SynQuacer NetSec driver implements the EFI driver
> model is slightly quirky. Two changes are needed to move it closer to the
> intent of the driver model, which is the ability to boot using only the
> drivers that are required to drive the devices that are needed at boot.
> This series does not complete the picture entirely yet for SynQuacer, and
> it still relies on the unconditional EfiBootManagerConnectAll() call that
> exists in the PlatformBootManagerLib implementation in ArmPkg. This is left
> for future work.
> 
> Ard Biesheuvel (2):
>   Silicon/SynQuacer/PlatformDxe: defer device registration until
>     EndOfDxe
>   Silicon/SynQuacer/NetsecDxe: move device path to root device

LGTM.

For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>


>  .../Drivers/Net/NetsecDxe/NetsecDxe.c         | 12 ---
>  .../Drivers/Net/NetsecDxe/NetsecDxe.h         |  9 --
>  .../Drivers/PlatformDxe/PlatformDxe.c         | 92 +++++++++++++++++--
>  .../Drivers/PlatformDxe/PlatformDxe.h         |  1 +
>  .../Drivers/PlatformDxe/PlatformDxe.inf       |  3 +
>  5 files changed, 86 insertions(+), 31 deletions(-)
> 
> -- 
> 2.17.1
>