From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web12.15223.1586363171399326282 for ; Wed, 08 Apr 2020 09:26:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=C+gTFSRC; spf=pass (domain: nuviainc.com, ip: 209.85.221.65, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f65.google.com with SMTP id p10so8531099wrt.6 for ; Wed, 08 Apr 2020 09:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bxrt098uKotopdT0jKedbelI5VVyI1SpIwdqU3eMoeg=; b=C+gTFSRCKNkIF+sZSWqCbAYKndphO0mwvPNL7gYU1SqQGH7N+Kb4Z5BdyNa5JZXt2b /y3GcoLoS9WkrnmfBID7QCIFZjDJfWXN9vRbcn9GEmVNdsTzhZeMZKVWwD8xH9mOey7V Iglhswxz/MQ+5+L5qoOC0luYcqP6U0/ohFrC9N+Jfqr95LI2A2tVoxto0pSZez0CIbe8 RYpYXSCJ+/jn7mlsjc/bN2ccpU04S5cS1ItWMoOx89cJUGv/uBNuEdh2ybTv7w1F85mX SdCo67Si2GcTQlsBf+8ooOThdi7CXIRmSda7Hkd+6SrEwixecjsB0ZpjiCALkWmUo07Y PLxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bxrt098uKotopdT0jKedbelI5VVyI1SpIwdqU3eMoeg=; b=r/pr4maqX+8wl4kQNSWXwUM8A7eTCfJg2oXzOp2AAPSHpaKE8wlxG/VNmedL5yaXQU RBvVmtD0gZSBzHe/B4w4MqMVXTxJpqdCQIiq2PCLHrUDdIFhF84LsGpvNIiba2UXpT0a v9GMa5F0NSxZVLtvT8y4DJ9R61+mBeO71qYJHOlBseYTfdLSDKkL+7ZaSaUL/Mw4/is5 sHKtubUeLZP+4jckRHTuZ+M1x8mMdqtRBXjidzBCdN/u2O1okT9TvgKq87pyyNytB7/+ uMklSRuiT3wwCF8NSBU3qm6EiBm79d2447L2V5859Cx6XdXuj8S5CoGsDiRjgKjpoae4 mLFQ== X-Gm-Message-State: AGi0Pub2rxkk77hRcKIqXYodAnjxg9NhJaLnIQccTOyJ0Dq4J9Xhiu4T airkWc+vXttYAZB740joFj7/bQ== X-Google-Smtp-Source: APiQypK/voiuCrA2gvxdjue5svDnfLoF06wthG2Q07YiU98NaxF0oKtepghSJMjISo2AOFLyGXYZHw== X-Received: by 2002:a5d:5187:: with SMTP id k7mr1067009wrv.217.1586363169922; Wed, 08 Apr 2020 09:26:09 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id e5sm37449044wru.92.2020.04.08.09.26.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2020 09:26:09 -0700 (PDT) Date: Wed, 8 Apr 2020 17:26:07 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Samer.El-Haj-Mahmoud@arm.com Subject: Re: [PATCH edk2-platforms 0/2] SynQuacer: fix driver model integration of NetSec Message-ID: <20200408162607.GW14075@vanye> References: <20200408161138.18289-1-ard.biesheuvel@arm.com> MIME-Version: 1.0 In-Reply-To: <20200408161138.18289-1-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 08, 2020 at 18:11:36 +0200, Ard Biesheuvel wrote: > Currently, the way the SynQuacer NetSec driver implements the EFI driver > model is slightly quirky. Two changes are needed to move it closer to the > intent of the driver model, which is the ability to boot using only the > drivers that are required to drive the devices that are needed at boot. > This series does not complete the picture entirely yet for SynQuacer, and > it still relies on the unconditional EfiBootManagerConnectAll() call that > exists in the PlatformBootManagerLib implementation in ArmPkg. This is left > for future work. > > Ard Biesheuvel (2): > Silicon/SynQuacer/PlatformDxe: defer device registration until > EndOfDxe > Silicon/SynQuacer/NetsecDxe: move device path to root device LGTM. For the series: Reviewed-by: Leif Lindholm > .../Drivers/Net/NetsecDxe/NetsecDxe.c | 12 --- > .../Drivers/Net/NetsecDxe/NetsecDxe.h | 9 -- > .../Drivers/PlatformDxe/PlatformDxe.c | 92 +++++++++++++++++-- > .../Drivers/PlatformDxe/PlatformDxe.h | 1 + > .../Drivers/PlatformDxe/PlatformDxe.inf | 3 + > 5 files changed, 86 insertions(+), 31 deletions(-) > > -- > 2.17.1 >