From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web12.6470.1586429213163757194 for ; Thu, 09 Apr 2020 03:46:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=uLXH/Cil; spf=pass (domain: nuviainc.com, ip: 209.85.221.65, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f65.google.com with SMTP id f10so1683530wrr.9 for ; Thu, 09 Apr 2020 03:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=h8dVRE85dDnGjsQwE7LLPGvueFr3z8T4D+BFcbx134c=; b=uLXH/CilETHBX9dgNZrOXqFtUgmDENKMuu8cU1PkgIQBWWD2sVD7cH5t1eFl7IYKro hG4xYTM3ARWXZ9ziDFvIQjhvppUazictymbqxNhIZRKrlnZL23+dTAN1IpYzuS6aOBJg apDJiNc7jq2xn+43kONlMdlLFoNd1Rhq5VMN6Oem+VjXzvij8iuJEx8ag0wlWRelBcXW fPtAGNheH2KiKMwKPZsJJTQ3mXlgeFSaX+KJsDDqwBI6XmFyDjovWckvu78zpzqEkLOo wVFKNCDzOo+zxgNzlNmYkIlNWwRtjs7jVxsO4QvC03I/qGZjijKGBjW2C9uludACzO35 LyqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=h8dVRE85dDnGjsQwE7LLPGvueFr3z8T4D+BFcbx134c=; b=KTq3p+FJ5YzFcNlhsd9r2mygu+x1CdKuIhxKo8KOyNLNNYHcx4ZFs/6sumx224cl07 ++yS0wq3bG6ZEpn36jOeww+LhtoRrJvQD65bV6INnuSFuN/gPhbFYlkUVtt89s2XeAzK 6/nVf7E4FdfUNAQlpaj2sePa20dk/3S/u3Qg6uO0L2iLl/jIlZxXE4ym4GV2+zYi3cWG YLWL6bLxM+rfrOtyYlpXJg5M17u4ky1OPx39ixro4UuSra5wehMCT97DbwiWox6iyOcy XvPQGPEHHN+SN5QZmjrbZu6wtHRuZBATukBkROh/G+HPTHs+w1JkVye160CXMRvSxCMP xAkw== X-Gm-Message-State: AGi0PubsFD8xJkax3L3Kbd8TpDqnxrw8FACRWbBZC79S3+DV/xW2rCub xSugTvx699DJUK2XKEXyZeO+4Q== X-Google-Smtp-Source: APiQypLUujABHAljGOZg8JDV5wfwR5sXM7w8wxLENPY4QcRhIh+q6seuN5RkZHwMHj66wq+PvzW9/w== X-Received: by 2002:a5d:69ce:: with SMTP id s14mr13661818wrw.413.1586429211724; Thu, 09 Apr 2020 03:46:51 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id t8sm638930wrq.88.2020.04.09.03.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 03:46:51 -0700 (PDT) Date: Thu, 9 Apr 2020 11:46:49 +0100 From: "Leif Lindholm" To: Varun Sethi Cc: "Pankaj Bansal (OSS)" , Meenakshi Aggarwal , Michael D Kinney , "devel@edk2.groups.io" , Samer El-Haj-Mahmoud , Jon Nettleton Subject: Re: [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib Message-ID: <20200409104649.GA14075@vanye> References: <20200320143543.18615-1-pankaj.bansal@oss.nxp.com> <20200320143543.18615-8-pankaj.bansal@oss.nxp.com> <20200401095329.GO7468@vanye> <20200406112453.GC14075@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 09, 2020 at 07:44:48 +0000, Varun Sethi wrote: > > > Now, neither appears to have happened, as .c still comes before .inf > > > and paths are still truncated. > > > > I had executed the SetupGit.py script, I will check again. > > > > > But in addition to that, we realised that git happily ignores > > > settings for --stat. So, please, execute aforementioned script, but > > > then generate v3 with --stat=1000 --stat-graph-width=20. > > > > Ok. I will follow these steps as well. > > > > > For this particular patch, the side discussion on the edk2 portion > > > may make it redundant, so I'm deferring review. > > > > Right now, I am yet to work on the review comments of other edk2 patch > > and since it touches other platforms as well, it requires thorough > > vetting from other platform maintainers. It seems like that would take > > more time. If I send this patch series without removing DuartLib (i.e. > > drop patches 7, 8, 9 from this series), can you please merge. > > Parallelly, I will work on edk2 patch and once that is accepted, I > > will send patches 7, 8, 9 after that in new series ? > > >See comment in my previous email on merging code only to remove it > >shortly afterwards. > > We will certainly take of this going forward. > > >As you have seen on that thread, a couple of proposals have been > >made for how to fix this without affecting other platforms (the HOB > >variant[1] and the separate .inf[2] variant). I will keep chasing > >on that >occasionally, but please also contribute to that > >conversation yourself. > > Pankaj would be responding to this thread and make changes > accordingly. Please allow us to pursue this patchset as a separate > thread. We need the base patches to be merged asap so that we can > submit patches for LX2160A and LS1046A. We have urgent releases > planned for these platforms. I (intimately) understand the situation you're in, but we cannot compromise normal development process of the upstream project due to project plans of individual contributors. My suggestion is that if this is holding your release back, then drop the console changes completely from this set and do your release based on upstream plus specifically those patches cherry-picked on top. I would not (for example) mind those patches being sent out to the list with a --subject-prefix of "DO NOT MERGE edk2-platforms" instead of "PATCH edk2-platforms". While staying close to upstream is both laudable and more efficient, productising based *only* on upstream is ... shall we say extremely optimistic. If you prepare to do the cherry-pick solution, then you can very quickly revert that and use upstream only if the full solution gets there in time. / Leif