From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web12.10028.1586442664450548110 for ; Thu, 09 Apr 2020 07:31:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=t+0qtK+i; spf=pass (domain: nuviainc.com, ip: 209.85.221.67, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f67.google.com with SMTP id g3so12211640wrx.2 for ; Thu, 09 Apr 2020 07:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=a99dwBM4jABIsD9rP4Pc1yUt5bhEZ+H7MlC9D3D0ivU=; b=t+0qtK+i6qCBx/lY6Q47zAtG5nWVjaKPSYh/dRwyboCecJN/ayJ4tIR/fIrdIYHtxX 83RA8NqJsGyc8Zll4y7RQXHYZFLC4ey/o/PO2qLpNqZtfE5fK49wAiVSaDlO9OAnkfk7 IeDMhLVe8rKrF9gJqAjWvn7a2X9T+a8R+TGgWJLXzqhv/W3NwcFsGzHc4n1cmoL30LzF QflTa0MmxWPbPkaflZ4oiZBpILPINdgxwZYsa0v6oQcDDO4xkRCFCnFiEMfD/6B+E2qW 8vNAtZl1fMs2TZiO1XMyqR3JBTu4HEGyMUnhCuAh8IjmRFt2UmXP/uN/bHXJ64r5SjK8 LSlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=a99dwBM4jABIsD9rP4Pc1yUt5bhEZ+H7MlC9D3D0ivU=; b=O3qdRM3OR/9rzed/bPgw4SF4unFaFbI6WvFBU3eLxGF7S26REKuENqHOscbmQk6pt/ rdKvUjThJd2K+9VPUPCT3sbkfj8NQWvIqeGYROJv4g3PI/0tjIFdTJ3P/dVA6loKY07g AVmKgqcNFuGuP6c90vSbfazd/KaZlhfEml0Y99mXbi3HcIgw79eH+5ZzjqMc2FkgC/B8 XtXImNC4zFn+zTb+NrKJMP0Pki9NfHQtWvhEO8AuDK5z4Uh2FPcFHFSl9K3JSuM//tc/ /wgDpU1kVuiV7BQSx+Sq2iPkKqOj9F2b2KiYOlGmQJnatM/X+D7jwpC3dLVBsvf5WvBf ySuw== X-Gm-Message-State: AGi0PuZ0ybdlzfwXD5c40CAcA3E+znnfZ5reIpxA9TOAAgRgvDWO/L0G Sgsb+ILdw55v9MMjlepWC9Tzyg== X-Google-Smtp-Source: APiQypIlJvEXXOBDhQ0isc8o7x3+SYdyp3u7SVL2NQBfMW4h+crnt9wAhHaPu6dlHVJDBdHw5+K7bA== X-Received: by 2002:a5d:53c4:: with SMTP id a4mr5488134wrw.47.1586442663000; Thu, 09 Apr 2020 07:31:03 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id y7sm39031270wrq.54.2020.04.09.07.31.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 07:31:02 -0700 (PDT) Date: Thu, 9 Apr 2020 15:31:00 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Laszlo Ersek , Leendert van Doorn Subject: Re: [PATCH 1/1] ArmVirtPkg: Include NVMe support in ArmVirtQemu* Message-ID: <20200409143100.GB14075@vanye> References: <20200409121050.15387-1-leif@nuviainc.com> <27590721-972f-7d2f-d5d9-d8c8a77d0199@arm.com> MIME-Version: 1.0 In-Reply-To: <27590721-972f-7d2f-d5d9-d8c8a77d0199@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 09, 2020 at 15:07:30 +0200, Ard Biesheuvel wrote: > On 4/9/20 2:10 PM, Leif Lindholm wrote: > > From: Leendert van Doorn > > > > Enable conditional support for NVMe storage in ArmVirtQemu/ > > QemVirtQemuKernel in order to simplify booting/installing operating > > systems that don't support virtio. > > > > [Conditionalised driver inclusion] > > Why? Well, it adds size and complexity for a target most frequently used to model a pure virtual environment? Size difference isn't huge though: FVMAIN [99%Full] 5337920 total, 5337864 used, 56 free FVMAIN_COMPACT [39%Full] 2093056 total, 829392 used, 1263664 free vs. FVMAIN [99%Full] 5300992 total, 5300936 used, 56 free FVMAIN_COMPACT [38%Full] 2093056 total, 804128 used, 1288928 free If that's not an issue, I'm happy to drop it and my bracketing. / Leif > > Signed-off-by: Leif Lindholm > > --- > > ArmVirtPkg/ArmVirtQemu.dsc | 8 ++++++++ > > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 7 +++++++ > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 8 ++++++++ > > 3 files changed, 23 insertions(+) > > > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > > index 8c77fc46427b..6f93032ac064 100644 > > --- a/ArmVirtPkg/ArmVirtQemu.dsc > > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > > @@ -28,6 +28,7 @@ [Defines] > > # -D FLAG=VALUE > > # > > DEFINE TTY_TERMINAL = FALSE > > + DEFINE NVME_ENABLE = FALSE > > DEFINE SECURE_BOOT_ENABLE = FALSE > > DEFINE TPM2_ENABLE = FALSE > > DEFINE TPM2_CONFIG_ENABLE = FALSE > > @@ -447,6 +448,13 @@ [Components.common] > > MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > > + # > > + # NVME Driver > > + # > > +!if $(NVME_ENABLE) == TRUE > > + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > > +!endif > > + > > # > > # SMBIOS Support > > # > > diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > > index aaba0b1c8840..45f0dd65be33 100644 > > --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > > +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > > @@ -128,6 +128,13 @@ [FV.FvMain] > > INF MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > > INF MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > > + # > > + # NVME Driver > > + # > > +!if $(NVME_ENABLE) == TRUE > > + INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > > +!endif > > + > > # > > # SMBIOS Support > > # > > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > > index 4d82a77213ec..5dd4b1cf29f4 100644 > > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > > @@ -28,6 +28,7 @@ [Defines] > > # -D FLAG=VALUE > > # > > DEFINE TTY_TERMINAL = FALSE > > + DEFINE NVME_ENABLE = FALSE > > DEFINE SECURE_BOOT_ENABLE = FALSE > > # > > @@ -382,6 +383,13 @@ [Components.common] > > MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf > > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > > + # > > + # NVME Driver > > + # > > +!if $(NVME_ENABLE) == TRUE > > + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > > +!endif > > + > > # > > # SMBIOS Support > > # > > >