From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web10.10283.1586443117425539256 for ; Thu, 09 Apr 2020 07:38:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=fz7OH/0B; spf=pass (domain: nuviainc.com, ip: 209.85.221.68, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f68.google.com with SMTP id v5so12182610wrp.12 for ; Thu, 09 Apr 2020 07:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WxKs/PXgfbLxPtjQyL5E6qdRNJfMkHh4UB5Wv2ejv5U=; b=fz7OH/0BYw0mTBeSLHFhcvmMUba5U0nfEKoA3eA3FJUcWdgNVHhpMamX44jHpxPZFd SuItQszdqe96gibF9Hw6sPA3CV9vaxmXW8dRKYmrR7c9Id4P5dl/2D/NCnUFccACplYy 6Z4AHp3GcrPdQhEk7iJAh2iCZ1Y+H4uwAgaWngu+keOZW/ZWDihZAoUqmOorlyjXVdlx 8b+1p+Zp4D+bF9Ci8UQESSFAePOYse7UkyGkzBiGBxagcu478zEm+vlTTSv7fX6bHUf9 6Un6cl26sPj7xLPupdcZj4kNmDGl0sqTG0f15tfarXW9OycBS4nud9ZPoVDA3P0Wrgwy dY6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WxKs/PXgfbLxPtjQyL5E6qdRNJfMkHh4UB5Wv2ejv5U=; b=WI2ceKZDfti9DGbQaaaU7YEE1tb6iIAjXrNR88WOi0buoCq+MuY6x7zb7erhka9hL1 MaZtE7Lqwgtyh65vg6p/y4dRxZM8ojUxnaaYNkiYd2F0LAYheUaVPnZRhqFTlOsvvi7Y Gx3ijBq5RFVZoq0kaGYFnRX9mYEttbJVUWWAvnwge9ZXzqoNsix545cVoBV7YalDNhrF xkYigZDgQ4nS/g6cVqzRfssdG80wcW8Rc/ew3kbHrUoW4CMfWf+2zdhRH5ZpmwwdTlNL UdHqm9wa7bz2/Gj0zoAst3AxU53ol9VYEt7ZXccsWER9D3KNa7Ofi6WdCqDjqIpiN/1F Kv0w== X-Gm-Message-State: AGi0PuZ3UI6WAZ/YSpRoxSjAbbveepztidXHH3vb/1vOrxWxECW5dkxT cdRQ9p9gY63Xo6x8WuyPMYYziA== X-Google-Smtp-Source: APiQypL9v6K5mfP4zpg9fTalt4fIH9W68qhd+DyT9Iagz3vQ3ZzZm/RZgpp3bgODVBOoOA/Wu1gf3Q== X-Received: by 2002:adf:9441:: with SMTP id 59mr2672122wrq.211.1586443115744; Thu, 09 Apr 2020 07:38:35 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id w7sm40928469wrr.60.2020.04.09.07.38.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 07:38:35 -0700 (PDT) Date: Thu, 9 Apr 2020 15:38:33 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: michael.kubacki@outlook.com, devel@edk2.groups.io, Ard Biesheuvel Subject: Re: [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI Message-ID: <20200409143833.GC14075@vanye> References: <20200408181327.4324-1-michael.kubacki@outlook.com> <20200409092345.GZ14075@vanye> <81bf053e-d35b-67a6-5869-73087b9fc857@redhat.com> MIME-Version: 1.0 In-Reply-To: <81bf053e-d35b-67a6-5869-73087b9fc857@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 09, 2020 at 15:18:42 +0200, Laszlo Ersek wrote: > On 04/09/20 11:23, Leif Lindholm wrote: > > On Thu, Apr 09, 2020 at 11:17:31 +0200, Laszlo Ersek wrote: > >> Hi Michael, > >> > >> On 04/08/20 20:13, michael.kubacki@outlook.com wrote: > >>> From: Sean Brogan > >>> > >>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570 > >>> > >>> Add new Azure Pipeline definitions to build and run ArmVirtPkg with: > >>> * Ubuntu GCC5 > >>> Add PyTool based build of ArmVirtPkg > >>> Add extdep for managing the iasl dependency > >>> Add ArmVirtPkg.ci.yaml for Core CI > >>> Add README-pytools for details and instructions > >>> > >>> Cc: Laszlo Ersek > >>> Cc: Ard Biesheuvel > >>> Cc: Leif Lindholm > >>> Signed-off-by: Sean Brogan > >> > >> The commit message is missing your Signed-off-by. You can & should > >> keep Sean's of course, but since you are submitting it, I think yours > >> (too) is required, per "Developer Certificate of Origin" in > >> "Readme.md". > > > > Michael cannot attest for Sean's legal opinions about this > > contribution, only Sean can do that. > > Not so sure about that (see below), but here I'm not questioning that. > > > The attribution of authorship is already covered by the From: tag. > > Agreed. > > My point is that Michael is technically partaking in the contribution of > this patch, even if he's only forwarding (upstreaming) Sean's patch > verbatim. Therefore the language in "Readme.md" applies to him as a > contributor: Yes, Michael's SoB is absolutely required. > > # Code Contributions > > To make a contribution to a TianoCore project, follow these steps. > > [...] > > 2. Your commit message must include your `Signed-off-by` signature > > [...] > > > > # Developer Certificate of Origin > > > > Your change description should use the standard format for a > > commit message, and must include your `Signed-off-by` signature. > > > > [...] > > > > By making a contribution to this project, I certify that: > > > > (a) The contribution was created in whole or in part by me and I > > have the right to submit it under the open source license > > indicated in the file; or > > > > (b) The contribution is based upon previous work that, to the best > > of my knowledge, is covered under an appropriate open source > > license and I have the right under that license to submit that > > work with modifications, whether created in whole or in part > > by me, under the same open source license (unless I am > > permitted to submit under a different license), as indicated > > in the file; or > > > > (c) The contribution was provided directly to me by some other > > person who certified (a), (b) or (c) and I have not modified > > it. > > > > [...] > > So, two points: > - under case (c), I do think Michael would attest for Sean's legal > opinions, > - even if it's not case (c) that applies, a Signed-off-by is needed from > Michael, for one of the other cases. > > The DCO that's included in "Readme.md" spells out the following goal (or > "spirit"): > > > In order to keep track of who did what, all patches contributed must > > include a statement that to the best of the contributor's knowledge > > they have the right to contribute it under the specified license. Yes. > If we don't include an S-o-b from Michael on the patch, his > participation in the upstreaming of this code change will disappear > entirely. The Committer field will refer to the mergify bot, the Author > field will refer (correctly) to Sean, and the [f]act of Michael posting > the patch to the list will be lost from the git history. > > The one S-o-b that we could technically do without, IMO, is Sean's. Yes, we're agreed on that bit. My statement is that unless Sean has himself given his SoB *in this context*, leaving that in is at best misleading and at worst directly false. Regards, Leif