From: "Samer El-Haj-Mahmoud" <samer@elhajmahmoud.com>
To: devel@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Pete Batard <pete@akeo.ie>,
Andrei Warkentin <awarkentin@vmware.com>
Subject: [edk2-platform][PATCH v2 1/3] Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe
Date: Tue, 14 Apr 2020 11:43:56 -0400 [thread overview]
Message-ID: <20200414154358.5161-2-samer@elhajmahmoud.com> (raw)
In-Reply-To: <20200414154358.5161-1-samer@elhajmahmoud.com>
Switch from the PI specific GraphicsConsoleDxe driver to the
common driver in MdeModulePkg. There is no need to carry RPi specific
version.
This resolves https://github.com/pftf/RPi4/issues/32
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
---
Notes:
v2:
- Set PcdUgaConsumeSupport to FALSE [Ard]
Platform/RaspberryPi/RPi4/RPi4.dsc | 3 ++-
Platform/RaspberryPi/RPi4/RPi4.fdf | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index 4fe4d810a0bc..835b558423a5 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -264,6 +264,7 @@ [PcdsFeatureFlag.common]
# It could be set FALSE to save size.
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
+ gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport|FALSE
[PcdsFixedAtBuild.common]
gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000
@@ -582,7 +583,7 @@ [Components.common]
MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
- Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
+ MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf
diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4/RPi4.fdf
index a59d3b601a86..b21643639131 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.fdf
+++ b/Platform/RaspberryPi/RPi4/RPi4.fdf
@@ -194,7 +194,7 @@ [FV.FvMain]
#
INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf
INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf
- INF Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
+ INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf
INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf
INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
INF Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf
--
2.17.1
next prev parent reply other threads:[~2020-04-14 15:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 15:43 [edk2-platform][PATCH v2 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe Samer El-Haj-Mahmoud
2020-04-14 15:43 ` Samer El-Haj-Mahmoud [this message]
2020-04-14 15:43 ` [edk2-platform][PATCH v2 2/3] Platform/RaspberryPi/RPi3: " Samer El-Haj-Mahmoud
2020-04-14 16:24 ` Andrei Warkentin
2020-04-14 15:43 ` [edk2-platform][PATCH v2 3/3] Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe Samer El-Haj-Mahmoud
2020-04-14 16:23 ` [edk2-platform][PATCH v2 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe Andrei Warkentin
2020-04-14 16:53 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414154358.5161-2-samer@elhajmahmoud.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox