From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by mx.groups.io with SMTP id smtpd.web12.14038.1586879042536936195 for ; Tue, 14 Apr 2020 08:44:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@elhajmahmoud-com.20150623.gappssmtp.com header.s=20150623 header.b=iVxDossd; spf=none, err=permanent DNS error (domain: banawan.net, ip: 209.85.222.193, mailfrom: samer@banawan.net) Received: by mail-qk1-f193.google.com with SMTP id l25so13721881qkk.3 for ; Tue, 14 Apr 2020 08:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elhajmahmoud-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iD8kWMgKHuWsSmBjL7DwSzuNhGnuG6bEYZxeSQ6ceNE=; b=iVxDossdRzXPOH0nusvMkH83IBJOa/MubAJZo0yumBo1PGjHJBd351Bqo+LrAG/y5u Ckx6gXQRps+5JQEK6LF4hM0v/B3SqzDcuS6lcBh5PuXzcPd7N6CqvkyAq9GkmTYIiZxN Pcacjh3yZL3D0x2vh1J9Sx1BbAma1PKUK/+g9MOiD8W9QOWOZJF770WZMAYsYJp8vdmt VMNtxZa3Jiy2xZjP6CyBjejHcKma7+Hh7XR8uAe4EzvhG+k9riEOTE8TCalsM+I8kNoB 0dXoj4kiw66Z4Epe07hek7Lfq2s0jlPcE6yULxtc/gDgel/sqd+LSa+20j30EcubA1PH KsHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iD8kWMgKHuWsSmBjL7DwSzuNhGnuG6bEYZxeSQ6ceNE=; b=cSJ3magdBd/TLmJvlSuonGvqvjomA8Agj1BjwgOh+yfolngWZcOmbmxAglEs+NCTo4 tQoF+5oYs5YO0XnfUd1ek/qAZgGnudOxSZcHCNer9nnZWUSsskvf89aB4t5peEZ2XQ4s jwN1rwmP9PTj1/IZk3K0H9vp7X+g+gWegLU7THXDTwha2KEpxsF+fJqOk32w+p9zvQlP OE+MPIgAT6sikYjpyNH1u1rX3WwryB4kpgqUjnyYEr2RoD5iEn2rLMO3phoViEmod6ew WHJweog3kwzSsbVRE+H9nHNS/kjvrttL3aRkAcXzRYuYFdMDFRF86U6Dy5exTSqu9t2+ 3rrw== X-Gm-Message-State: AGi0PuYNbG9yGJ8a0k0BPUaDK+zbF8yqT0XZAEALZf1PTGvrXR5czFL6 q9HLXL28kl86YRlpA+mHucMNGBMa2/ReOQ== X-Google-Smtp-Source: APiQypLyXeq6bg94U1nMK3HUWAEKu7vaw/n2mATyCNTTQimVtrIUK1Ozf0PjhGTZXvgEox2Q8Kq5hw== X-Received: by 2002:a37:a0d6:: with SMTP id j205mr22099391qke.455.1586879041381; Tue, 14 Apr 2020 08:44:01 -0700 (PDT) Return-Path: Received: from localhost.localdomain (99-132-126-10.lightspeed.chrlnc.sbcglobal.net. [99.132.126.10]) by smtp.gmail.com with ESMTPSA id y126sm10667585qke.28.2020.04.14.08.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 08:44:00 -0700 (PDT) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Pete Batard , Andrei Warkentin Subject: [edk2-platform][PATCH v2 1/3] Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe Date: Tue, 14 Apr 2020 11:43:56 -0400 Message-Id: <20200414154358.5161-2-samer@elhajmahmoud.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200414154358.5161-1-samer@elhajmahmoud.com> References: <20200414154358.5161-1-samer@elhajmahmoud.com> Switch from the PI specific GraphicsConsoleDxe driver to the common driver in MdeModulePkg. There is no need to carry RPi specific version. This resolves https://github.com/pftf/RPi4/issues/32 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Notes: v2: - Set PcdUgaConsumeSupport to FALSE [Ard] Platform/RaspberryPi/RPi4/RPi4.dsc | 3 ++- Platform/RaspberryPi/RPi4/RPi4.fdf | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc index 4fe4d810a0bc..835b558423a5 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.dsc +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc @@ -264,6 +264,7 @@ [PcdsFeatureFlag.common] # It could be set FALSE to save size. gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE + gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport|FALSE [PcdsFixedAtBuild.common] gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 @@ -582,7 +583,7 @@ [Components.common] MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf - Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf + MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf MdeModulePkg/Universal/SerialDxe/SerialDxe.inf Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4/RPi4.fdf index a59d3b601a86..b21643639131 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.fdf +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf @@ -194,7 +194,7 @@ [FV.FvMain] # INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf - INF Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf + INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf INF Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf -- 2.17.1