From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) by mx.groups.io with SMTP id smtpd.web12.14039.1586879043505485007 for ; Tue, 14 Apr 2020 08:44:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@elhajmahmoud-com.20150623.gappssmtp.com header.s=20150623 header.b=CRqgXaZ3; spf=none, err=permanent DNS error (domain: banawan.net, ip: 209.85.219.65, mailfrom: samer@banawan.net) Received: by mail-qv1-f65.google.com with SMTP id 37so10737qvc.8 for ; Tue, 14 Apr 2020 08:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elhajmahmoud-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jKWXbkYzgBLynnY3wHQOnWGE3o2aOFKcwwfYOWtrR+o=; b=CRqgXaZ3vA7pGupHZ9LBLMHS1zTNScFoErQGHY8f5sGgORx0qTlZouRpa4l2fu5DD4 6Y/ziOpS5M0CtibQq4Wr+vfNRLyWgD9nPQ0CxXG+ey+TL/JzOACU3wQ5TE/zzf54cqdT N+E4MMRDlpPJygfcpvmNrD+0QQ7fD2FOZfWYZiSNVkQ+AGgfbXRyKWag7OJ31Z4WGOYn KVMJBYBO8wmltdLysrXwERBrFyadrqAHPp0VAVXuVFv0gdYFR0q023kt3VyL7Q9l15RX I6hqTpJ6nazPvAM89iWNJUnq+Z1dL70osZk579am5G37kjqfvFcHQ2gR67VvXCLGz0zl bdlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jKWXbkYzgBLynnY3wHQOnWGE3o2aOFKcwwfYOWtrR+o=; b=hSIoOlB7rz0Yag+byAVkCe1A9iCaj4j8/TBa7hGAzUZbaaboccKX8ohl78Y/PWjPyb V+p3sB43R8sCX8b7OsgPB+PfxmFxVuQ4SUwKII+MTtQ8inyi9IZ+GA4QrMrWLF3iCMg9 tijzUoV8ZrVY6rjMZH/hdAZcGNmt9L/CDUvKZZ4SyAU+9n0Ov4dPuRZa/MPgjjl0ljO8 03hD1dwNb90o09biFbCU7sTQiy4HcO+LKiIcmE0x9lnFKIfIEE9G/vM+49ZZTPlAD/as ObJc8nYXpNwyUWRbOpO4MuzjyhtNffMfdDTSTy7hXwwJXGygWVLq98ezsmDkL9b+sI1S H4TA== X-Gm-Message-State: AGi0PuYS/bLgN7DmRWVien3jgf2JjB4yTOAdjqazNfNptqnv52mDkcHd wLRGk7walDwZiQQ2Pfu7iBqS8REDriYrVw== X-Google-Smtp-Source: APiQypLIOFO8cBYKrfu3prTRbOqidjw/YfMbEqz1Zh9kENEWu4NkgyNos6vx64d1ED6+uexDEZlRmA== X-Received: by 2002:a0c:eb0e:: with SMTP id j14mr573382qvp.230.1586879042435; Tue, 14 Apr 2020 08:44:02 -0700 (PDT) Return-Path: Received: from localhost.localdomain (99-132-126-10.lightspeed.chrlnc.sbcglobal.net. [99.132.126.10]) by smtp.gmail.com with ESMTPSA id y126sm10667585qke.28.2020.04.14.08.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 08:44:01 -0700 (PDT) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Pete Batard , Andrei Warkentin Subject: [edk2-platform][PATCH v2 2/3] Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe Date: Tue, 14 Apr 2020 11:43:57 -0400 Message-Id: <20200414154358.5161-3-samer@elhajmahmoud.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200414154358.5161-1-samer@elhajmahmoud.com> References: <20200414154358.5161-1-samer@elhajmahmoud.com> Switch from the PI specific GraphicsConsoleDxe driver to the common driver in MdeModulePkg. There is no need to carry RPi specific version. This resolves https://github.com/pftf/RPi4/issues/32 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Notes: v2: - Set PcdUgaConsumeSupport to FALSE [Ard] Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++- Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc index 9ceb0f11c7fe..a451e2a82b59 100644 --- a/Platform/RaspberryPi/RPi3/RPi3.dsc +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc @@ -240,6 +240,7 @@ [PcdsFeatureFlag.common] # It could be set FALSE to save size. gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE + gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport|FALSE [PcdsFixedAtBuild.common] gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 @@ -545,7 +546,7 @@ [Components.common] MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf - Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf + MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf MdeModulePkg/Universal/SerialDxe/SerialDxe.inf Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf diff --git a/Platform/RaspberryPi/RPi3/RPi3.fdf b/Platform/RaspberryPi/RPi3/RPi3.fdf index 66c2cbada59b..e467b5cd31df 100644 --- a/Platform/RaspberryPi/RPi3/RPi3.fdf +++ b/Platform/RaspberryPi/RPi3/RPi3.fdf @@ -206,7 +206,7 @@ [FV.FvMain] # INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf INF MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe.inf - INF Platform/RaspberryPi/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf + INF MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsoleDxe.inf INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf INF Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.inf -- 2.17.1