From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.70]) by mx.groups.io with SMTP id smtpd.web11.9731.1586866498573649346 for ; Tue, 14 Apr 2020 05:14:58 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=hWa8Skuk; spf=pass (domain: oss.nxp.com, ip: 40.107.5.70, mailfrom: pankaj.bansal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QTshyu9xTctPE4MaJeVjYiwYhE2jk4X2D70RA4j/+TYf4zp2RcZZIWz/86dMF/qEVRRm5beksKg2k5K9tyyLo7zGuAZDx0sXQwqP6fwj7oZ/D2sCfjBmuByIYOH7hH41+3mlgIj2QdTwohuEY6xp3O0lbHYlsKJNphA9EJezkwcAiDbMgfX3TKgMCb/QUzO2sgAWmf2CZ552rmxy0lknKwAO7s05dg2ywWRKaxI1uI0YCuRiQVZiE7R7vf4QemPzouhLandyX8HzlcIeRJaMwgQwgtr+FM0sCbZqKSDB3NUA6DIiCu4OmBQ5x9gdB+lT2PgkSXj7MLGgVox1wNVCQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c5q13mwrE0gzl3zrGAPXiDG2aE4t/4MFUyeKpX9cAQ8=; b=Mr0h2c5CwjabzCMqD/LmgH5JBGgHZ4TWtaxCrw4yjEOHRhcsLfALuFHBtSPt5DYYmdtGh0UpMFWG7ObL8w7nhjFIwDhwmcPCkAtzz4urr/gDOFguFYo3NSXYayPFwn5H+Yi3SFqwQPGWRpPcDjeV2f7nWkp2gVidF+hSH8WCe8tvxW1HZwJ4Z/xoF5VNryGD3+oE4O9/3kZsJTehS1V/+zvWu/8gVyy9sFeXrfVz1csj55mdSfUuFa8JXp412kMqm2VNrLQAOJQX06/mKHl6IOn1QM2EIynT+LV92jCyH+v0IrGionw5GXp8vQSB2x4ePpeFek7juhv3NcoAgpo3uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c5q13mwrE0gzl3zrGAPXiDG2aE4t/4MFUyeKpX9cAQ8=; b=hWa8Skuk1d5tyKetorKek2PeiEeRAHof5mBxZFEonsnm8NBoHmX34v28GTvRS5N7TS0cxt44M5rPmMheQYjUXgFbdPH4b6/vI3xzNYAyQ8u7bivzfYf+Il7VbO8M1pOHrasVs7nqG9tU09AY2KbWRU0KzmfPycoq19Ufwx56O5s= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=pankaj.bansal@oss.nxp.com; Received: from VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) by VI1PR04MB4461.eurprd04.prod.outlook.com (2603:10a6:803:70::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.28; Tue, 14 Apr 2020 12:14:56 +0000 Received: from VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513]) by VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513%7]) with mapi id 15.20.2900.028; Tue, 14 Apr 2020 12:14:56 +0000 From: "Pankaj Bansal" To: Leif Lindholm , Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton , Ard Biesheuvel Subject: [PATCH edk2-platforms v3 04/24] Silicon/Maxim: Fix bug in RtcWrite in Ds1307RtcLib Date: Wed, 15 Apr 2020 17:43:22 +0530 Message-ID: <20200415121342.9246-5-pankaj.bansal@oss.nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200415121342.9246-1-pankaj.bansal@oss.nxp.com> References: <20200415121342.9246-1-pankaj.bansal@oss.nxp.com> X-ClientProxiedBy: SG2PR01CA0092.apcprd01.prod.exchangelabs.com (2603:1096:3:15::18) To VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) Return-Path: pankaj.bansal@oss.nxp.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from uefi-workstation.ap.freescale.net (92.120.0.69) by SG2PR01CA0092.apcprd01.prod.exchangelabs.com (2603:1096:3:15::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Tue, 14 Apr 2020 12:14:53 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [92.120.0.69] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 0a36e803-e6c3-45ce-109b-08d7e06d71b4 X-MS-TrafficTypeDiagnostic: VI1PR04MB4461:|VI1PR04MB4461: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-Forefront-PRVS: 0373D94D15 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5933.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(366004)(346002)(136003)(39850400004)(396003)(966005)(1076003)(186003)(8936002)(16526019)(86362001)(110136005)(26005)(478600001)(81156014)(8676002)(6512007)(66946007)(316002)(44832011)(66476007)(66556008)(52116002)(5660300002)(6666004)(2906002)(6486002)(6506007)(956004)(19627235002)(2616005);DIR:OUT;SFP:1101; Received-SPF: None (protection.outlook.com: oss.nxp.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XrOkOzf2ghCN+6118DjTv8jN8vz06eBTnIHXeJcvkSV4wCzdSxmFC2t9afRfP2AEc4Paz2zRWwBvzZJKZUGqCpHkFfTmlLDauomXR87krEsadqBmaH5Brl+Deu5FlXH7ElamhliMwzr4OZcSVJOAgKMwOZu1gRYeYBkbJwuiQskBGoOgIVUev7MaqN1Hr0mTjf+g84anIXnWDFAaOcmQ0v6L3r/yGoiyuKZMqtbi1LkzS8U2hyQ9iREFkdPmSlyFlEtXXxBi91S9v8BMWHebUVqWUqctqy3XF8KKM/fagcb+QkP6FiHIY1ERP/3gkJSzGenVorv0Mph/pOoVutb8Tu+nKBtYr9SF+mXvzWkZtCtm81suhtfCv3jCml1VcryH1PHeFR7ZNShxAciXpXe/DL4tPhkLttVO0jhn5YzazfW0Ker5ao2c2HvR2YE+7CZ2XMGCioiLrB/hItH94wr4qpJJndoK134ImfienluJB/V9FBk5zqUIewMAcPPJUjDQo31mxA/3d5qUXf+iFFwdUg== X-MS-Exchange-AntiSpam-MessageData: mPx9WdMaLPhLnH1w1LfkOppc2PvZZ+zufZFpxmt3xTGxRQdcMS7+sKR4I95vxtxX3Sn4NpMA9gQo43HMviNrBfRygkkKWJKxg9CjQVtIc3U//COqBgpFnQ2msuCZr80aS/YwtkuH4Mh6lKahJGgWnw== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a36e803-e6c3-45ce-109b-08d7e06d71b4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2020 12:14:56.2786 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v6YOvbX/Ki9q/qrUwvptubaen9NPo/t+xGLeVh9e6QVw05hDwYm65/k2SoTAcZSt78XP+2rLDfyHm/tefPIhdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4461 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Pankaj Bansal There was a bug in I2C DXE implementation, which caused the Ds1307 RTC device to issue two operation for register write, while this is a single operation task. refer page 12 (Slave Receiver Mode (Write Mode)) on https://datasheets.maximintegrated.com/en/ds/DS1307.pdf Modify ds1307 RtcWrite code accordingly. Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: - No change Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c b/Silicon/Ma= xim/Library/Ds1307RtcLib/Ds1307RtcLib.c index 88dc198ffec8..fd7a8696e405 100644 --- a/Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c +++ b/Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c @@ -5,7 +5,7 @@ EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c =20 Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
- Copyright 2017 NXP + Copyright 2017, 2020 NXP =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -84,16 +84,15 @@ RtcWrite ( { RTC_I2C_REQUEST Req; EFI_STATUS Status; + UINT8 Buffer[2]; =20 - Req.OperationCount =3D 2; + Req.OperationCount =3D 1; + Buffer[0] =3D RtcRegAddr; + Buffer[1] =3D Val; =20 Req.SetAddressOp.Flags =3D 0; - Req.SetAddressOp.LengthInBytes =3D sizeof (RtcRegAddr); - Req.SetAddressOp.Buffer =3D &RtcRegAddr; - - Req.GetSetDateTimeOp.Flags =3D 0; - Req.GetSetDateTimeOp.LengthInBytes =3D sizeof (Val); - Req.GetSetDateTimeOp.Buffer =3D &Val; + Req.SetAddressOp.LengthInBytes =3D sizeof (Buffer); + Req.SetAddressOp.Buffer =3D Buffer; =20 Status =3D mI2cMaster->StartRequest (mI2cMaster, FixedPcdGet8 (PcdI2cSla= veAddress), (VOID *)&Req, --=20 2.17.1