From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.65]) by mx.groups.io with SMTP id smtpd.web12.9829.1586866501684566016 for ; Tue, 14 Apr 2020 05:15:02 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=ApVa6EtC; spf=pass (domain: oss.nxp.com, ip: 40.107.5.65, mailfrom: pankaj.bansal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y76rjK2NUd9PqTJvBhqV0/3qn/r1ij9YljBzG6ZzHsdxcXyNZPGBesJLzTOL1xXMnYYVD2wM1CZqmm93K8eNVBzdH1BXGDQFCadtswrW3AblPaVgetthnUOFCpRsIdBhhjAM/B1oMqFwMnVuqeGyZzW28z/FGl6WHmk1hA4j6yRqqNuA7eE9m2R+c8hexUNs9j5FzNMfAQ1gnpE5BSD+PZb1Ebtc9WsuOOd1bt4niwhRTmNXIV4hCjHotcORM0iqpsEDCXpcHrJDIU0XC34/WnipFb9GAcgJNk1K3g27f7RQgL8AdQ5M/whmD5s/a5rqn4DPT+wbIaiPxso56Kc6Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f+wmOD67biN1Pe9VgRbEB8QazUqBb2djLUlw36SCRF4=; b=D9u2VmmC+IY/X1AX+3v+MozzHWKYEHCjlY80L+279ot+ByPIXArs/CwnfIho8Ulxe06LUqGlaJqCA1CxabYZo8dOUpahqvtcrmsWSPxxTxDOqXoCfVuhLMimmKhKmcHmbgW1Hc6TRsNTlu6oqq05i0k69IkHzcQ14i8jSmxlzKPxQTeyTSdSM/6bLuyVTPB6K0t6YABrEzIJGaxbUZFwnu85hgSp4AeVHk2kr4loR/bKhChI0pyYXG8cidH20uDMeBHlUsE7QOxCYLqLbE+hmhUIkKorznckva2I6nC+UdiKEA8XlGCndJIRc/ctgI9Xo0LnsVS82ostfC4KFWzMeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f+wmOD67biN1Pe9VgRbEB8QazUqBb2djLUlw36SCRF4=; b=ApVa6EtCSet6TE5NfwgPBYPIMs9D2WVDqEsZAxbw9Mw/URfIxldEVrmAsGg3/vIlIBtAAIULrit5zhuNKBU+NcUENP2y9HhMHFCBTzcTMVVyGKbMFhlC3/QFR2aTRoqhcAhA9P1GJW5Aos5POp4FWrJ4+GFVQosJjYjqvWPAHeA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=pankaj.bansal@oss.nxp.com; Received: from VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) by VI1PR04MB4461.eurprd04.prod.outlook.com (2603:10a6:803:70::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.28; Tue, 14 Apr 2020 12:14:59 +0000 Received: from VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513]) by VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513%7]) with mapi id 15.20.2900.028; Tue, 14 Apr 2020 12:14:59 +0000 From: "Pankaj Bansal" To: Leif Lindholm , Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton , Ard Biesheuvel Subject: [PATCH edk2-platforms v3 05/24] Silicon/Maxim: Add comments in Ds1307RtcLib Date: Wed, 15 Apr 2020 17:43:23 +0530 Message-ID: <20200415121342.9246-6-pankaj.bansal@oss.nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200415121342.9246-1-pankaj.bansal@oss.nxp.com> References: <20200415121342.9246-1-pankaj.bansal@oss.nxp.com> X-ClientProxiedBy: SG2PR01CA0092.apcprd01.prod.exchangelabs.com (2603:1096:3:15::18) To VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) Return-Path: pankaj.bansal@oss.nxp.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from uefi-workstation.ap.freescale.net (92.120.0.69) by SG2PR01CA0092.apcprd01.prod.exchangelabs.com (2603:1096:3:15::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Tue, 14 Apr 2020 12:14:56 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [92.120.0.69] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: e24395f8-075b-4a67-e82c-08d7e06d7382 X-MS-TrafficTypeDiagnostic: VI1PR04MB4461:|VI1PR04MB4461: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 0373D94D15 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5933.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(366004)(346002)(136003)(39850400004)(396003)(966005)(1076003)(186003)(8936002)(16526019)(86362001)(110136005)(26005)(478600001)(81156014)(8676002)(6512007)(66946007)(316002)(44832011)(66476007)(66556008)(52116002)(5660300002)(6666004)(2906002)(6486002)(6506007)(956004)(19627235002)(2616005);DIR:OUT;SFP:1101; Received-SPF: None (protection.outlook.com: oss.nxp.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lvSr3OszvkwdxZXckNTS0SMEI4Lj4Zac64dVZetwx1BSA5SmL6hfqPYXg/3y/PV1DzuSTAuLhSnsNJi6ExWHsTchTvkV/Ayn5QNXGZWKZNVqGDGeY3aWkmD6ZXY9Gx/4ThJazl+KT4vu0yC6oMimHFZWKtOeAUIHfhdFIDruI6mY144LOPYFySxBIGNQEUi2/S7xdUoKdp1i6XpFG2Sa0zkeeaVDCd9Fduue+KcnLg3wfm7QFCsOl1bexV8Hk267wwCgOOEUSeEW1AWhcQKsbatbnWGWDCWZgWBs4Gtg9R+tmQx8CiIli5TqktVlrlwW1WI3XKGygvC0r+jFr+dbQv8UHHTTJB2yK3qQpX6T/h0D/3cIsETCh587DXLWV7ovJ1ENCpc1cuRG9tngWFDZiy2OF2dFH4bPpuvWXt7yVwStV4L+NEXuTyJB1Kh/I5FLD1uptTbFmSBsIyCn+oXjfv9B2W0yt7HR1vwK/dIIOcstdutaxbaSUCPRZOBwknLiAOinxwK5H1xbjn0EB+QThQ== X-MS-Exchange-AntiSpam-MessageData: X6rCUKSa5eR69V//ASkrx2U5fJUhyG2dokapJFMfWYeKURg82K2Uc6FVtevvIGsgLD156I5/JBjyjtszmgfgCMHul6auRbiXG7uW99z1/fUNikmVnd7Rl7dKSt0Qb7G+u8mPxDsu2Dr9ExNsAoFpqA== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e24395f8-075b-4a67-e82c-08d7e06d7382 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2020 12:14:59.3009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tmjh0YLV/+1IcQAVSgpX1UbOQ9Eb4+bCYlfdM33hi2UdiFQw+kGgfBn8tkjgkZJig9zm2R/sYPR5MdEzREQwGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4461 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Pankaj Bansal Add comments to explain the register read and write operation on Ds1307. These comments have been referred from data sheet: https://datasheets.maximintegrated.com/en/ds/DS1307.pdf Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: - No change Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c b/Silicon/Ma= xim/Library/Ds1307RtcLib/Ds1307RtcLib.c index fd7a8696e405..444e01124811 100644 --- a/Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c +++ b/Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c @@ -28,6 +28,11 @@ STATIC EFI_I2C_MASTER_PROTOCOL *mI2cMaster; =20 /** Read RTC register. + Data Read-Slave Transmitter Mode + + = + + The first byte is received and handled as in the slave receiver mode. =20 @param RtcRegAddr Register offset of RTC to be read. =20 @@ -69,6 +74,9 @@ RtcRead ( =20 /** Write RTC register. + Data Write-Slave Receiver Mode + + =20 @param RtcRegAddr Register offset of RTC to write. @param Val Value to be written --=20 2.17.1