From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) by mx.groups.io with SMTP id smtpd.web12.16096.1587301461957836646 for ; Sun, 19 Apr 2020 06:04:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@elhajmahmoud-com.20150623.gappssmtp.com header.s=20150623 header.b=qdboXUUY; spf=none, err=permanent DNS error (domain: banawan.net, ip: 209.85.219.65, mailfrom: samer@banawan.net) Received: by mail-qv1-f65.google.com with SMTP id p19so3331384qve.0 for ; Sun, 19 Apr 2020 06:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elhajmahmoud-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MgoZdtKsxG6nYJd+AFkCzCqjEFU7ueFlm7ygD0DY3x4=; b=qdboXUUYy5DNOYsYcbt1e6D/GZ9+QN0CuDy85dm3kaBCxeqDeSZOggsWPi9t+aAcUU yAGgu4QSmB12gmatcprO5YYkQMNbrxfwXPqapJhOJju0daOLHTSmj2IsB9FmhOvheYrM 5r4owL05tFNNYElGV8Vk8SmYgnU3GNXq8BgqWraWQSUm7r7BdLwnUwm0JAfpgCkZkyPx WCYTRe9VL6L0/AgWE5MsdEUbsSOiD/Y6WyuPAP6p/3krMwzwrWWskL+ARBc+P41gVcy0 cCkeBd2XI6r+pS+jRw/LCFT1WyHxhIw3e8kJOrbzZBb6o95al6OV6fCUt6yeUsTVglQY hxgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MgoZdtKsxG6nYJd+AFkCzCqjEFU7ueFlm7ygD0DY3x4=; b=cf5fiaOeittj8XZub0ZPQ5/2mY1lVl/sERYlrxzb2vhf/Od1OKmjvgsBMGVrmEHv6C jDKqELkp+drAuB3KOuYN7UEGY25z17ioWlHTcreVbfW9SUC/emSCjFcFjecWts3YrkN4 2mZx6SQDPj8DUO6nwoCxTbZas2/H8ZyOeWopDZguuySQFAxmsJIiduxJLpxMuVQwc+sY Xa8J5RAKrTBMuXGOfTn4Dr8p+TpeAcr06JHdqCebBOcN0266bwXDBiuo5Oz6aOF9MQ31 9xj7b4QX55ZLTi8Hfqon7cR2ISqABbX+n2RMKlO+VyJ8AfcBltRhPxPs1bOZsZZc+y4T aIYg== X-Gm-Message-State: AGi0PuZixsR0Wps7gyLt7pzYezSKebpKvUukboqEDln9xP48J2tNlwpJ Lgn1YGLKNw8hFcxrnw0VAoiMrEiTdxR2gA== X-Google-Smtp-Source: APiQypKwYxC9XcLv2ffJYGclwnchqLx0nfUVlMH7y33JfPpf3pk7YMYW3IH0wbJYBN2lXhgzySj2wA== X-Received: by 2002:a0c:9aea:: with SMTP id k42mr10762598qvf.91.1587301460860; Sun, 19 Apr 2020 06:04:20 -0700 (PDT) Return-Path: Received: from localhost.localdomain (99-132-126-10.lightspeed.chrlnc.sbcglobal.net. [99.132.126.10]) by smtp.gmail.com with ESMTPSA id z65sm10992917qka.60.2020.04.19.06.04.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2020 06:04:20 -0700 (PDT) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Pete Batard , Andrei Warkentin Subject: [edk2-platform][PATCH v1 1/4] Platform/RaspberryPi/RPi3: Fix TFTP dynamic command initialization Date: Sun, 19 Apr 2020 09:04:14 -0400 Message-Id: <20200419130417.3298-2-samer@elhajmahmoud.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200419130417.3298-1-samer@elhajmahmoud.com> References: <20200419130417.3298-1-samer@elhajmahmoud.com> Set the PcdShellLibAutoInitialize for the TFTP dynamic Shell command. This fixes an ASSERT observed in https://github.com/pftf/RPi3/issues/11 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi3/RPi3.dsc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc index a451e2a82b59..54ebfdfbb05a 100644 --- a/Platform/RaspberryPi/RPi3/RPi3.dsc +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc @@ -662,5 +662,8 @@ [Components.common] gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|0x200000 } !if $(INCLUDE_TFTP_COMMAND) == TRUE - ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { + + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE + } !endif -- 2.17.1