public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Samer El-Haj-Mahmoud" <samer@elhajmahmoud.com>
To: devel@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>,
	Pete Batard <pete@akeo.ie>,
	Andrei Warkentin <awarkentin@vmware.com>
Subject: [edk2-platform][PATCH v1 2/4] Platform/RaspberryPi/RPi4: Fix TFTP dynamic command initialization
Date: Sun, 19 Apr 2020 09:04:15 -0400	[thread overview]
Message-ID: <20200419130417.3298-3-samer@elhajmahmoud.com> (raw)
In-Reply-To: <20200419130417.3298-1-samer@elhajmahmoud.com>

Set the PcdShellLibAutoInitialize for the TFTP dynamic Shell command.
This fixes an ASSERT observed in https://github.com/pftf/RPi4/issues/38

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
---
 Platform/RaspberryPi/RPi4/RPi4.dsc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
index 835b558423a5..de32aab2df3c 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -716,5 +716,8 @@ [Components.common]
       gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|0x200000
   }
 !if $(INCLUDE_TFTP_COMMAND) == TRUE
-  ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
+  ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf  {
+    <PcdsFixedAtBuild>
+      gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
+  }
 !endif
-- 
2.17.1


  parent reply	other threads:[~2020-04-19 13:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-19 13:04 [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command Samer El-Haj-Mahmoud
2020-04-19 13:04 ` [edk2-platform][PATCH v1 1/4] Platform/RaspberryPi/RPi3: Fix TFTP dynamic command initialization Samer El-Haj-Mahmoud
2020-04-19 13:04 ` Samer El-Haj-Mahmoud [this message]
2020-04-19 13:04 ` [edk2-platform][PATCH v1 3/4] Platform/RaspberryPi/RPi3: Enable TFTP command by default Samer El-Haj-Mahmoud
2020-04-19 13:04 ` [edk2-platform][PATCH v1 4/4] Platform/RaspberryPi/RPi4: " Samer El-Haj-Mahmoud
2020-04-19 13:33 ` [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command Ard Biesheuvel
2020-04-19 14:00   ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-04-19 14:04     ` Ard Biesheuvel
2020-04-19 14:19   ` Pete Batard
2020-04-19 19:56     ` Andrei Warkentin
2020-04-19 20:06       ` [edk2-devel] " Pete Batard
2020-04-19 20:21         ` Andrei Warkentin
2020-04-19 20:24           ` Pete Batard
2020-04-19 20:42             ` Andrei Warkentin
     [not found]             ` <160753416257B0CA.29096@groups.io>
2020-04-19 23:50               ` Andrei Warkentin
2020-04-20  1:03                 ` Andrew Fish
2020-04-20  2:41                   ` Andrei Warkentin
2020-04-20  6:45                     ` Ard Biesheuvel
2020-04-20 11:55                       ` Pete Batard
2020-04-20 12:43                         ` Ard Biesheuvel
2020-04-20 14:18                           ` Pete Batard
2020-04-20 11:23       ` Leif Lindholm
2020-04-20 13:17         ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-04-20 13:24 ` Ard Biesheuvel
2020-04-20 13:30   ` [edk2-devel] " Samer El-Haj-Mahmoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200419130417.3298-3-samer@elhajmahmoud.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox