From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by mx.groups.io with SMTP id smtpd.web10.16246.1587301462939066753 for ; Sun, 19 Apr 2020 06:04:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@elhajmahmoud-com.20150623.gappssmtp.com header.s=20150623 header.b=H6DB09P+; spf=none, err=permanent DNS error (domain: banawan.net, ip: 209.85.222.195, mailfrom: samer@banawan.net) Received: by mail-qk1-f195.google.com with SMTP id b62so7632385qkf.6 for ; Sun, 19 Apr 2020 06:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elhajmahmoud-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FlGv82A0Kqck44VbcgWSuOwHFfqkhSCwyqnk5ggh0yY=; b=H6DB09P+LTx+w2LuwV0bZvqGKF2TjyN0HRtCGg9/nxtHvysJIl4t1Z6FCXNXWRxvHq qUeVZsMIKJAdXOINXxVU09352Sy8aoAVXOCysxx5ySOtivi1wX3eWoJ/CS80ZZ1H/EUQ xVJrnZiMHRcZN8DOo1WBWKmR0G0+BciaGHuIzWMrBnnNKZs9gcaXErXfCdsolfeiOlwO 5BQspeRqc1k/mR35uuxvoNn/Gx3dthXjdpIbYI+SeiXjSr4o8TVIjXy4HCuJgrDnJIQX 8TYKV2Z7ZBhDx6RaqupPOw5eTMTLre/uvkrvZdtWeGpkM/ZK0bsW4GS7efyiyxzsugw3 bp0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FlGv82A0Kqck44VbcgWSuOwHFfqkhSCwyqnk5ggh0yY=; b=fM9AWXvDo6TpeM/BpfV8sPOwoLLeKHgT0eOCKua5XlLk89eSjQQJTgtLmuN+pB9KeZ Mf43AExFHRvIauL8igX+iAROgjrBhse6loVvrr99on3ai6J8szNBIiMbD4wrJcxFLo0j wcy0GcGHDAoVKfZsCcWMVR8lnwdJPXZCuzo42IpITyihKDhyn+A2oPjVW2KXMi7L+p/l UjBPhp53tDiRFFritCRN7op3DPojJxOtK4q4V34XXsp8sUMOt3WY2c4jAE3FdJpClWMn MR5vufRnYAYsHBhVPm067zbt7+WKGgz8qaz7s3q0ckXNB+kHGCt4akMv8nkG3M1PN/K8 h5jg== X-Gm-Message-State: AGi0PuYPFjNq1pIQYp/If8Fe/wVtJXgirMUIVNH4GTUs8//2mh0/0ezB jGQX1x04TrU8gW/IE8/vDwAlOu9tJQfx2w== X-Google-Smtp-Source: APiQypLjzYKsCDPc5lXhE1slVvHZphT2k7JFuJtrmiTJieNMQzEdmx2AsEcz0QIMfhdHNN/9jFescQ== X-Received: by 2002:a05:620a:41a:: with SMTP id 26mr11253781qkp.421.1587301461870; Sun, 19 Apr 2020 06:04:21 -0700 (PDT) Return-Path: Received: from localhost.localdomain (99-132-126-10.lightspeed.chrlnc.sbcglobal.net. [99.132.126.10]) by smtp.gmail.com with ESMTPSA id z65sm10992917qka.60.2020.04.19.06.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2020 06:04:21 -0700 (PDT) From: "Samer El-Haj-Mahmoud" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Pete Batard , Andrei Warkentin Subject: [edk2-platform][PATCH v1 2/4] Platform/RaspberryPi/RPi4: Fix TFTP dynamic command initialization Date: Sun, 19 Apr 2020 09:04:15 -0400 Message-Id: <20200419130417.3298-3-samer@elhajmahmoud.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200419130417.3298-1-samer@elhajmahmoud.com> References: <20200419130417.3298-1-samer@elhajmahmoud.com> Set the PcdShellLibAutoInitialize for the TFTP dynamic Shell command. This fixes an ASSERT observed in https://github.com/pftf/RPi4/issues/38 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi4/RPi4.dsc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc index 835b558423a5..de32aab2df3c 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.dsc +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc @@ -716,5 +716,8 @@ [Components.common] gEfiShellPkgTokenSpaceGuid.PcdShellFileOperationSize|0x200000 } !if $(INCLUDE_TFTP_COMMAND) == TRUE - ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { + + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE + } !endif -- 2.17.1