public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: awarkentin@vmware.com, Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>,
	Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command
Date: Mon, 20 Apr 2020 12:23:16 +0100	[thread overview]
Message-ID: <20200420112316.GG14075@vanye> (raw)
In-Reply-To: <BN6PR05MB34114BA7A2CC295D657EEEAAB9D70@BN6PR05MB3411.namprd05.prod.outlook.com>

Hi Andrei,

On Sun, Apr 19, 2020 at 19:56:32 +0000, awarkentin@vmware.com wrote:
> If we have to choose abstract goodness over functionality, why
> wouldn't we choose functionality? Functionality that's part of
> Tiano? The real world doesn't care about the TFTP command being an
> "unsupported hack" or not. So there's Tiano-specific code here. Big
> deal? To rephrase differently, why would either Pi 4 developers or
> Pi 4 UEFI users pay the cost of Tiano carrying code that somehow
> isn't "legit enough" to be enabled?

I agree there is confusion caused by this weird second implementation
of TFTP in Tianocore. It is yet another piece of unfortunate legacy
caused by ARM's initial focus on trying to make EDK2 look and work
like u-boot instead of understanding how to use it as a generic UEFI
implementation.

For that reason, it should have gone the same way as the ArmBds and
the built-in linux loader, but people kept arguing it was really
useful for debugging - so we let it be, and permitted platforms to
include it as long as it was not included by default.

But since its main contribution to TianoCore seems to be causing
arguments on the mailing list, perhaps we should finally bite the
bullet and nuke it.

The idea (which was probably mine) that "only permit platforms to
include it if it is disabled by default and people will get the hint"
has demonstrably failed.

/
    Leif

  parent reply	other threads:[~2020-04-20 11:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-19 13:04 [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command Samer El-Haj-Mahmoud
2020-04-19 13:04 ` [edk2-platform][PATCH v1 1/4] Platform/RaspberryPi/RPi3: Fix TFTP dynamic command initialization Samer El-Haj-Mahmoud
2020-04-19 13:04 ` [edk2-platform][PATCH v1 2/4] Platform/RaspberryPi/RPi4: " Samer El-Haj-Mahmoud
2020-04-19 13:04 ` [edk2-platform][PATCH v1 3/4] Platform/RaspberryPi/RPi3: Enable TFTP command by default Samer El-Haj-Mahmoud
2020-04-19 13:04 ` [edk2-platform][PATCH v1 4/4] Platform/RaspberryPi/RPi4: " Samer El-Haj-Mahmoud
2020-04-19 13:33 ` [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command Ard Biesheuvel
2020-04-19 14:00   ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-04-19 14:04     ` Ard Biesheuvel
2020-04-19 14:19   ` Pete Batard
2020-04-19 19:56     ` Andrei Warkentin
2020-04-19 20:06       ` [edk2-devel] " Pete Batard
2020-04-19 20:21         ` Andrei Warkentin
2020-04-19 20:24           ` Pete Batard
2020-04-19 20:42             ` Andrei Warkentin
     [not found]             ` <160753416257B0CA.29096@groups.io>
2020-04-19 23:50               ` Andrei Warkentin
2020-04-20  1:03                 ` Andrew Fish
2020-04-20  2:41                   ` Andrei Warkentin
2020-04-20  6:45                     ` Ard Biesheuvel
2020-04-20 11:55                       ` Pete Batard
2020-04-20 12:43                         ` Ard Biesheuvel
2020-04-20 14:18                           ` Pete Batard
2020-04-20 11:23       ` Leif Lindholm [this message]
2020-04-20 13:17         ` Samer El-Haj-Mahmoud
2020-04-20 13:24 ` Ard Biesheuvel
2020-04-20 13:30   ` [edk2-devel] " Samer El-Haj-Mahmoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200420112316.GG14075@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox