From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web10.100.1587381800556005982 for ; Mon, 20 Apr 2020 04:23:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=LWYJKNAJ; spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f66.google.com with SMTP id j1so6226322wrt.1 for ; Mon, 20 Apr 2020 04:23:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CMnTCBRr5XadQZlYH0Gej8wSvdUNNaqv6QdhvrXIz1Q=; b=LWYJKNAJRHk2QIPO0onutxw6O/+Ey4zboMrAc1iJwYzDOOZH61xzV+3otjQQj+uqkP 2vX2l67EjMXZP9ghvUI/t5tEPGfBnvjYcwBKNCBEn/36s+1Rw5QyCyUzB7dC2+iDkLSz /RG62rhYw2Ec0n8ybAbnXGHoBasZZgyMxNQA3T4LM4CthVo3Sg1W4CrrnohI+RVvWUW+ 1nZurpAujXcHYnKt9kwjZSA3n+zV7C4lLxrqFUBIV4Ardnn8buGE5ydHc7jwj9Mm4TKW 83olm+gZ9va2w+n7LIZdCsQuh5z3FRymA5BphZGuuCy/roF3cVUq9D03+w9uc1HtrDhc VHUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CMnTCBRr5XadQZlYH0Gej8wSvdUNNaqv6QdhvrXIz1Q=; b=Dj/ATNrYEXcwPquPBc/KP5l5NgYIF0tC4jQVVUxSjOvJbTRFm/octfRx+XRGqXpWeI f0t0CLhYdkXlkASsnhpJEo8crI+cNAmQ/qVE6d+sdYDOJmfzM/9CjQ+RX5AfUjGzkGoU QoX1AC7plo7OsZCVGReKC0TuGHgpUNplS1A+8Y/Y0sRDmPE6bih7YeQ/VE0BZko6ofK0 E8NAqKh1MYkjvfAmd2Q4Pv1MFT9zFEq5c3eqM3P5qxnNgxymJN138V2qzCVAyO3lUPYE sOgDlCyWQNmr5TlxtS0SI3XQDT8hBDmfTn4GgYG0fXfRM0W8PX6a5APJOHAZ+mnjT7Rz kngw== X-Gm-Message-State: AGi0Pua3jxRMhDnM0mkdXZaVZFlui/I6YiPETC9Peyw6Q0Iax/t77Adc XzE0LosFA2owbOdAT4l598uI/Q== X-Google-Smtp-Source: APiQypKu7cpXfBCcAuiL4fJDwAT1gvLRutUybqdL3F7509n1wKET6TRbANeBs1jagzUZ9mLeP2wMHw== X-Received: by 2002:a05:6000:1287:: with SMTP id f7mr18769135wrx.345.1587381799120; Mon, 20 Apr 2020 04:23:19 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id h16sm845247wrw.36.2020.04.20.04.23.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2020 04:23:18 -0700 (PDT) Date: Mon, 20 Apr 2020 12:23:16 +0100 From: "Leif Lindholm" To: awarkentin@vmware.com, Ard Biesheuvel Cc: Pete Batard , Samer El-Haj-Mahmoud , "devel@edk2.groups.io" Subject: Re: [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command Message-ID: <20200420112316.GG14075@vanye> References: <20200419130417.3298-1-samer@elhajmahmoud.com> <8d59e616-9910-4935-2e1f-5da75fc1d34a@arm.com> <831705c6-0915-ba1a-adc0-3078b2af1a43@akeo.ie> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Andrei, On Sun, Apr 19, 2020 at 19:56:32 +0000, awarkentin@vmware.com wrote: > If we have to choose abstract goodness over functionality, why > wouldn't we choose functionality? Functionality that's part of > Tiano? The real world doesn't care about the TFTP command being an > "unsupported hack" or not. So there's Tiano-specific code here. Big > deal? To rephrase differently, why would either Pi 4 developers or > Pi 4 UEFI users pay the cost of Tiano carrying code that somehow > isn't "legit enough" to be enabled? I agree there is confusion caused by this weird second implementation of TFTP in Tianocore. It is yet another piece of unfortunate legacy caused by ARM's initial focus on trying to make EDK2 look and work like u-boot instead of understanding how to use it as a generic UEFI implementation. For that reason, it should have gone the same way as the ArmBds and the built-in linux loader, but people kept arguing it was really useful for debugging - so we let it be, and permitted platforms to include it as long as it was not included by default. But since its main contribution to TianoCore seems to be causing arguments on the mailing list, perhaps we should finally bite the bullet and nuke it. The idea (which was probably mine) that "only permit platforms to include it if it is disabled by default and people will get the hint" has demonstrably failed. / Leif