From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.2878.1587392387848129191 for ; Mon, 20 Apr 2020 07:19:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QSzA+q1e; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587392387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H7USdtUoz3kSSU0UZKyTCfogB5EO4ouDL7SXvdREnsg=; b=QSzA+q1evcyIPLT3kdjb7Y6a9/O/1jmLODhVDycxRj/sFyr7OIo57r9k9F1dPPljR8QIwn KmfptC4l2MfMBIMlo/poCR1U/RhE68AJPrO4rhQ9cMmY44UR8oywP2CKvSgE8+rK1H1JT0 mQcY592pKqklakQS0hwOB81+FuPM4PQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-144-I_BBzPMNOwiHR-TE6moM9g-1; Mon, 20 Apr 2020 10:19:44 -0400 X-MC-Unique: I_BBzPMNOwiHR-TE6moM9g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 47BCF8026BF; Mon, 20 Apr 2020 14:19:43 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-113-193.ams2.redhat.com [10.36.113.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id EFC241001B09; Mon, 20 Apr 2020 14:19:41 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 758F717532; Mon, 20 Apr 2020 16:19:40 +0200 (CEST) Date: Mon, 20 Apr 2020 16:19:40 +0200 From: Gerd Hoffmann To: Hou Qiming Cc: Laszlo Ersek , valerij zaporogeci , discuss@edk2.groups.io, "Marcel Apfelbaum (GMail address)" , edk2-devel-groups-io , qemu devel list Subject: Re: [edk2-discuss] Load Option passing. Either bugs or my confusion. Message-ID: <20200420141940.tpkhv6zqjkv25h5i@sirius.home.kraxel.org> References: <623b1855-285c-cce3-c806-c17e5fd217ea@redhat.com> <5211.1586899245384995995@groups.io> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi, > The proper way to enable ramfb resolution change again is adding sanity > checks for ramfb resolution / pointer / etc. on the QEMU side. Pointer *is* checked. ramfb creates a mapping, and if that fails due to the pointer not being valid it bails out. Sanity-checking the resolution is the job of the UI code. cheers, Gerd