* [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency
@ 2020-04-22 6:55 Wu, Hao A
2020-04-22 8:10 ` [edk2-devel] " Ni, Ray
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wu, Hao A @ 2020-04-22 6:55 UTC (permalink / raw)
To: devel; +Cc: Hao A Wu, Eric Dong, Ray Ni, Laszlo Ersek
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2632
Both PEI and DXE instances of the MpInitLib are using PcdLib APIs, but
none of them list the dependency of the PcdLib in INF & header files.
This commit will explicitly add such dependency in .H and .INF files.
Test done:
Library level build pass for VS2015x86 tool chain
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
---
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 +
UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 1 +
UefiCpuPkg/Library/MpInitLib/MpLib.h | 1 +
3 files changed, 3 insertions(+)
diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
index a51a9ec1d2..9907f4157b 100644
--- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
+++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
@@ -51,6 +51,7 @@ [LibraryClasses]
UefiBootServicesTableLib
DebugAgentLib
SynchronizationLib
+ PcdLib
[Protocols]
gEfiTimerArchProtocolGuid ## SOMETIMES_CONSUMES
diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
index d78d328b42..89ee9a79d8 100644
--- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
+++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
@@ -50,6 +50,7 @@ [LibraryClasses]
UefiCpuLib
SynchronizationLib
PeiServicesLib
+ PcdLib
[Pcd]
gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ## CONSUMES
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
index 74e919dae0..a8ca03efb8 100755
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
@@ -31,6 +31,7 @@
#include <Library/SynchronizationLib.h>
#include <Library/MtrrLib.h>
#include <Library/HobLib.h>
+#include <Library/PcdLib.h>
#include <Guid/MicrocodePatchHob.h>
--
2.12.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency
2020-04-22 6:55 [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency Wu, Hao A
@ 2020-04-22 8:10 ` Ni, Ray
2020-04-22 16:14 ` Laszlo Ersek
2020-04-23 8:50 ` [edk2-devel] " Wu, Hao A
2 siblings, 0 replies; 4+ messages in thread
From: Ni, Ray @ 2020-04-22 8:10 UTC (permalink / raw)
To: devel@edk2.groups.io, Wu, Hao A; +Cc: Dong, Eric, Laszlo Ersek
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wu, Hao
> A
> Sent: Wednesday, April 22, 2020 2:56 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Dong, Eric <eric.dong@intel.com>; Ni,
> Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit
> PcdLib dependency
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2632
>
> Both PEI and DXE instances of the MpInitLib are using PcdLib APIs, but
> none of them list the dependency of the PcdLib in INF & header files.
>
> This commit will explicitly add such dependency in .H and .INF files.
>
> Test done:
> Library level build pass for VS2015x86 tool chain
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
> ---
> UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 +
> UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 1 +
> UefiCpuPkg/Library/MpInitLib/MpLib.h | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> index a51a9ec1d2..9907f4157b 100644
> --- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> @@ -51,6 +51,7 @@ [LibraryClasses]
> UefiBootServicesTableLib
> DebugAgentLib
> SynchronizationLib
> + PcdLib
>
> [Protocols]
> gEfiTimerArchProtocolGuid ## SOMETIMES_CONSUMES
> diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> index d78d328b42..89ee9a79d8 100644
> --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> @@ -50,6 +50,7 @@ [LibraryClasses]
> UefiCpuLib
> SynchronizationLib
> PeiServicesLib
> + PcdLib
>
> [Pcd]
> gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ##
> CONSUMES
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h
> b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> index 74e919dae0..a8ca03efb8 100755
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> @@ -31,6 +31,7 @@
> #include <Library/SynchronizationLib.h>
> #include <Library/MtrrLib.h>
> #include <Library/HobLib.h>
> +#include <Library/PcdLib.h>
>
> #include <Guid/MicrocodePatchHob.h>
>
> --
> 2.12.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency
2020-04-22 6:55 [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency Wu, Hao A
2020-04-22 8:10 ` [edk2-devel] " Ni, Ray
@ 2020-04-22 16:14 ` Laszlo Ersek
2020-04-23 8:50 ` [edk2-devel] " Wu, Hao A
2 siblings, 0 replies; 4+ messages in thread
From: Laszlo Ersek @ 2020-04-22 16:14 UTC (permalink / raw)
To: Hao A Wu, devel; +Cc: Eric Dong, Ray Ni
On 04/22/20 08:55, Hao A Wu wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2632
>
> Both PEI and DXE instances of the MpInitLib are using PcdLib APIs, but
> none of them list the dependency of the PcdLib in INF & header files.
>
> This commit will explicitly add such dependency in .H and .INF files.
>
> Test done:
> Library level build pass for VS2015x86 tool chain
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
> ---
> UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 +
> UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 1 +
> UefiCpuPkg/Library/MpInitLib/MpLib.h | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> index a51a9ec1d2..9907f4157b 100644
> --- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> @@ -51,6 +51,7 @@ [LibraryClasses]
> UefiBootServicesTableLib
> DebugAgentLib
> SynchronizationLib
> + PcdLib
>
> [Protocols]
> gEfiTimerArchProtocolGuid ## SOMETIMES_CONSUMES
> diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> index d78d328b42..89ee9a79d8 100644
> --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> @@ -50,6 +50,7 @@ [LibraryClasses]
> UefiCpuLib
> SynchronizationLib
> PeiServicesLib
> + PcdLib
>
> [Pcd]
> gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ## CONSUMES
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> index 74e919dae0..a8ca03efb8 100755
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> @@ -31,6 +31,7 @@
> #include <Library/SynchronizationLib.h>
> #include <Library/MtrrLib.h>
> #include <Library/HobLib.h>
> +#include <Library/PcdLib.h>
>
> #include <Guid/MicrocodePatchHob.h>
>
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency
2020-04-22 6:55 [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency Wu, Hao A
2020-04-22 8:10 ` [edk2-devel] " Ni, Ray
2020-04-22 16:14 ` Laszlo Ersek
@ 2020-04-23 8:50 ` Wu, Hao A
2 siblings, 0 replies; 4+ messages in thread
From: Wu, Hao A @ 2020-04-23 8:50 UTC (permalink / raw)
To: devel@edk2.groups.io, Ni, Ray, Laszlo Ersek; +Cc: Dong, Eric
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Wednesday, April 22, 2020 2:56 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Dong, Eric; Ni, Ray; Laszlo Ersek
> Subject: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit
> PcdLib dependency
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2632
>
> Both PEI and DXE instances of the MpInitLib are using PcdLib APIs, but
> none of them list the dependency of the PcdLib in INF & header files.
>
> This commit will explicitly add such dependency in .H and .INF files.
>
> Test done:
> Library level build pass for VS2015x86 tool chain
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
Thanks Ray and Laszlo,
Patch pushed via commit d5339c04d7.
Best Regards,
Hao Wu
> ---
> UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 +
> UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 1 +
> UefiCpuPkg/Library/MpInitLib/MpLib.h | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> index a51a9ec1d2..9907f4157b 100644
> --- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf
> @@ -51,6 +51,7 @@ [LibraryClasses]
> UefiBootServicesTableLib
> DebugAgentLib
> SynchronizationLib
> + PcdLib
>
> [Protocols]
> gEfiTimerArchProtocolGuid ## SOMETIMES_CONSUMES
> diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> index d78d328b42..89ee9a79d8 100644
> --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf
> @@ -50,6 +50,7 @@ [LibraryClasses]
> UefiCpuLib
> SynchronizationLib
> PeiServicesLib
> + PcdLib
>
> [Pcd]
> gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ##
> CONSUMES
> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h
> b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> index 74e919dae0..a8ca03efb8 100755
> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
> @@ -31,6 +31,7 @@
> #include <Library/SynchronizationLib.h>
> #include <Library/MtrrLib.h>
> #include <Library/HobLib.h>
> +#include <Library/PcdLib.h>
>
> #include <Guid/MicrocodePatchHob.h>
>
> --
> 2.12.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-23 8:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-22 6:55 [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency Wu, Hao A
2020-04-22 8:10 ` [edk2-devel] " Ni, Ray
2020-04-22 16:14 ` Laszlo Ersek
2020-04-23 8:50 ` [edk2-devel] " Wu, Hao A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox