From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.groups.io with SMTP id smtpd.web11.3808.1587551517633763885 for ; Wed, 22 Apr 2020 03:31:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=IdLuo79u; spf=pass (domain: nuviainc.com, ip: 209.85.221.46, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f46.google.com with SMTP id k13so1757884wrw.7 for ; Wed, 22 Apr 2020 03:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zU1LdtfaViOCA58WHKk9qHUvcenFT0WI7Lsak4XTdeM=; b=IdLuo79uMrkU5Jw9QdE6JFxidR85juo8LdtTGBi+BCn3bXNkd8MleSuZxZZLTKbv02 PrdmFKWDd2Dbf9pkqkKc0/PbTeYMtciUMXlNwlrUGdpi3v6e2KDyv+WxmSOpgP27B0FR kyw5fN7ryAadIIs8iIWFIAo6wkWyZqe8WFUxGdYTYIZk2u0fIu5KtvYqXWuSCTnbsN9A 1/QGf5o8zTWsrm+M8bLMVqF7H0WDckrpRWos7ArI2Z7bwopX0MkjB5VVs0iZShSp8BVa FbXgDxJUfg7+HVcoFoDyz+TxWlMTxpazdYr8Rt9E+elUujmDjc2eDMnZW7L7gptF6gJ2 SF8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zU1LdtfaViOCA58WHKk9qHUvcenFT0WI7Lsak4XTdeM=; b=MBl8yexyNvfmgGJyXP5RXRsA5lv7iE9dq107LqBrvTvYHmExXnUXMShDQu891RaCTW zaUkIdILSWaYTgbz677R+ve5imdItMchKD4kETFDVdfEY17oio6/wnCL76X+gmHogsen 4pQ+f4Tui22jZLYGZzgMyeIIYFvlx7K28j1RGDVpPHlsLkPOQc8YSJhlqMnCxWqpmToQ CJlUM0Sy7gi2kEZjPK+RxJdbG4ygKQp+pI2LIRA6kwhiHZNAUdZLq6/akpxxOWp8diQx 3GfIcEcVJ9X/k+Xtz+6aCLe7duokcBSK/8yfdtXxgq/xxHM2NBEnE4qjb6mF2PPlbr23 9oGw== X-Gm-Message-State: AGi0PuZu4ZMUH3V6I16/ARqTWN4dqDOf7YtqrXCgB323Wx3Zd9+ul491 NzkV2NFkt/esTh2QFkwsdgnv16Qm055ky7QJnSL/h2+sU4ZhqE0URPbBIK1HsHAvYwlZv3zrF0e hwNWc66fVgKA/pGv66G16qV8cmwTq5FvtH5ZAyhNQ1S9A+KN6nFMDzKwHyQU5mg0= X-Google-Smtp-Source: APiQypKadXZFCiK8l8ZxQxXOpXs8UoM1nOsf/CVCd08S0M6HgzUjGY6quexYoKceXGg3VB+cvMrC4A== X-Received: by 2002:a5d:5304:: with SMTP id e4mr27474514wrv.87.1587551515739; Wed, 22 Apr 2020 03:31:55 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id h2sm7902972wro.9.2020.04.22.03.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2020 03:31:55 -0700 (PDT) Date: Wed, 22 Apr 2020 11:31:53 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com Cc: "Agyeman, Prince" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 00/11] Add BDS Hook Points Message-ID: <20200422103153.GK14075@vanye> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Nate, On Tue, Apr 21, 2020 at 20:37:39 +0000, Nate DeSimone wrote: > This patch series has gotten very old and the review comments were > minor and cosmetic. Since this is a good new feature, I have made > the cosmetic fixes and pushed the patch series as > 765cbda6~..5a60c2de. Could you make sure the BZ gets updated/closed as well? Regards, Leif > > Thanks, > Nate > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Agyeman, Prince > Sent: Friday, December 13, 2019 5:32 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [edk2-platforms] [PATCH 00/11] Add BDS Hook Points > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2336 > > This patch series implements BDS hook points as defined in the EDK II Minimum Platform Specification. For details, see https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification/appendix_a_full_maps/a3_bds_hook_points.html > > What was done: > > * MinplatformPkg: Three BDS event group PCDs were added > - gBdsEventBeforeConsoleAfterTrustedConsoleGuid > - gBdsEventBeforeConsoleBeforeEndOfDxeGuid > - gBdsEventAfterConsoleReadyBeforeBootOptionGuid > > * DxePlatformBootManager: MinplatformPkg's DxePlatformBootManager library instance was modified to signal the three newly added BDS events groups > > * BoardBdsHookLib: BDS event callback library was added. > This library implements the callbacks for the three Bds event groups as well as callbacks for already existing gEfiEndOfDxeEventGroupGuid, gEfiPciEnumerationCompleteProtocolGuid and gEfiDxeSmmReadyToLockProtocolGuid event groups > - A default implementation of the board BDS hook library > was added to BoardModulePkg > - A SimicOpenBoardPkg specific implementation of the Board BDS > hook library was also added > > * BoardBdsHookDxe: A generic DXE driver that registers the callbacks implemented in the Board BDS hook library was added > > * BoardBootManagerLib: A board boot manager library was added. > This library implements PlatformBootManagerWaitCallback and PlatformBootManagerUnableToBoot needed by Minplatform's PlatformBootManager libary instance. > - A null instance of this library was added to MinplatformPkg > - A default instance of this library was added to BoardModulePkg > - A SimicOpenBoardPkg instance was implemented > > * Support for the BDS Hook points were added to all the Minplatform boards > > Prince Agyeman (11): > MinPlatformPkg: Add BDS Hook Point Guids > BoardModulePkg: Add BDS Hook Library > BoardModulePkg: Add BDS Hook DXE Driver > MinPlatformPkg: Add BDS Board Boot Manager library > MinPlatformPkg: Add BDS Hook Points > BoardModulePkg: Add Generic BoardBootManagerLib > KabylakeOpenBoardPkg: Add BDS Hook Dxe Driver > WhiskeylakeOpenBoardPkg: Add BDS Hook Dxe Driver > SimicsOpenBoardPkg: Add Bds Hook Library > SimicsOpenBoardPkg: Add BDS Board Boot Manager library > SimicsOpenBoardPkg: Add Bds Hook Points > > .../BoardBdsHookDxe/BoardBdsHookDxe.c | 121 ++ > .../BoardBdsHookDxe/BoardBdsHookDxe.inf | 46 + > .../Include/Library/BoardBdsHookLib.h | 100 + > .../Library/BoardBdsHookLib/BoardBdsHook.h | 211 +++ > .../Library/BoardBdsHookLib/BoardBdsHookLib.c | 1390 ++++++++++++++ > .../BoardBdsHookLib/BoardBdsHookLib.inf | 95 + > .../BoardBdsHookLib/BoardBootOption.c} | 87 +- > .../BoardBdsHookLib/BoardMemoryTest.c} | 4 +- > .../BoardBootManagerLib/BoardBootManager.c | 103 ++ > .../BoardBootManagerLib.inf | 39 + > .../GalagoPro3/OpenBoardPkg.dsc | 7 + > .../GalagoPro3/OpenBoardPkg.fdf | 1 + > .../KabylakeRvp3/OpenBoardPkg.dsc | 6 + > .../KabylakeRvp3/OpenBoardPkg.fdf | 1 + > .../BoardBootManagerLib.c | 38 + > .../BoardBootManagerLibNull.inf | 31 + > .../DxePlatformBootManagerLib/BdsPlatform.c | 1262 +------------ > .../DxePlatformBootManagerLib/BdsPlatform.h | 181 +- > .../DxePlatformBootManagerLib.inf | 51 +- > .../Include/Library/BoardBootManagerLib.h | 39 + > .../Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 + > .../BoardX58Ich10/OpenBoardPkg.dsc | 10 +- > .../BoardX58Ich10/OpenBoardPkg.fdf | 1 + > .../Library/BoardBdsHookLib/BoardBdsHook.h | 173 ++ > .../Library/BoardBdsHookLib/BoardBdsHookLib.c | 1630 +++++++++++++++++ > .../BoardBdsHookLib/BoardBdsHookLib.inf | 81 + > .../BoardBootManagerLib/BoardBootManager.c | 67 + > .../BoardBootManagerLib.inf | 45 + > .../WhiskeylakeURvp/OpenBoardPkg.dsc | 4 + > .../WhiskeylakeURvp/OpenBoardPkg.fdf | 1 + > 30 files changed, 4421 insertions(+), 1409 deletions(-) create mode 100644 Platform/Intel/BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.c > create mode 100644 Platform/Intel/BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > create mode 100644 Platform/Intel/BoardModulePkg/Include/Library/BoardBdsHookLib.h > create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHook.h > create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c > create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.inf > rename Platform/Intel/{MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/PlatformBootOption.c => BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c} (87%) rename Platform/Intel/{MinPlatformPkg/Bds/Library/DxePlatformBootManagerLib/MemoryTest.c => BoardModulePkg/Library/BoardBdsHookLib/BoardMemoryTest.c} (93%) create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBootManagerLib/BoardBootManager.c > create mode 100644 Platform/Intel/BoardModulePkg/Library/BoardBootManagerLib/BoardBootManagerLib.inf > create mode 100644 Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/BoardBootManagerLib.c > create mode 100644 Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/BoardBootManagerLibNull.inf > create mode 100644 Platform/Intel/MinPlatformPkg/Include/Library/BoardBootManagerLib.h > create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h > create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHookLib.c > create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHookLib.inf > create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootManagerLib/BoardBootManager.c > create mode 100644 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootManagerLib/BoardBootManagerLib.inf > > -- > 2.19.1.windows.1 > > > > > > >