From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web10.3694.1587637877657940424 for ; Thu, 23 Apr 2020 03:31:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=JDEXRbUZ; spf=pass (domain: nuviainc.com, ip: 209.85.128.68, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f68.google.com with SMTP id v4so7101740wme.1 for ; Thu, 23 Apr 2020 03:31:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+iNJZ6wBkS7/lBNcxpVebINM/KE+4I6LdujcIMYttqY=; b=JDEXRbUZyix1IW39N0wB54WUPJOO8k/FPxlL2ruWuZBg9RWftwa7wig3aqkgbIUWxy sXWLKcASq8JW/fLia6V6sQAIKn5wr4DvBiqr37G8epp0gbtJCt/QdvStdzA998/2HVHH Cqi0wpznzzyuZCleXXL+V6A9gv2y3YltqxFcQx7lt8SB4lEqhnSojL10619nyZJupk6c hVLVvsJBLSQkEek/kYJINxNFufRMEcXZ/iecK+pN+PifMZlS403/Dap+uHJQ7URicCtF neLRPLhEz0Gkd5J+yWppZ1ntomg1oOjft0LrKzKzsDQtujLJHMZj3huQedrVO346xgZ/ Q0+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+iNJZ6wBkS7/lBNcxpVebINM/KE+4I6LdujcIMYttqY=; b=MpmvxOsWhe5NCgrTt1M38yM46f3vg+fKlM9AVwjl/Mbr5YcUEk5l3CRA+YiPFhrpmd XlZcyYcU/bSj1R2AcOPcK/CCz9Vkzqe2BZdAtvQr9BcKl5jJmAYAQ7+fRFlxuTNvbrSu J2cZAFViK1H38Oh/CqrG6ce531OT0CeBggySiFWHKDx6DYvMF0KOl6C6zw7CLkN9DYfv +/BrNthV4FPs0r42YMGMNAFjYf1L3IFXCzVvla/MIUhnvnkr/0DkMHy9PVHk7KW7IyV1 uytaSeDoeiVtEog70UV/HH3Z8edGI9hNpbGvTRA2SoOBEy/yPtl+PpFVqkPn9OYtrvaL suow== X-Gm-Message-State: AGi0PuagUB7TT1k356tcwXr0jHkmIPjL+U1ch+r/kMmVyFr20uOvT2LM bvJqq4nUjMZzmNT2Wqwq3SGjRQ== X-Google-Smtp-Source: APiQypJeHHPmF+RGtsBI09q8vqDdinfH7S/jnr08WkD/TVIR3co/c3mh95taEXbLkHQhGNSJ469HyA== X-Received: by 2002:a1c:9891:: with SMTP id a139mr3613374wme.129.1587637876264; Thu, 23 Apr 2020 03:31:16 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id k133sm3324324wma.0.2020.04.23.03.31.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2020 03:31:15 -0700 (PDT) Date: Thu, 23 Apr 2020 11:31:13 +0100 From: "Leif Lindholm" To: Pankaj Bansal Cc: Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton , Ard Biesheuvel Subject: Re: [PATCH edk2-platforms v3 21/24] Platform/NXP: Use FV rules from ArmVirtPkg Message-ID: <20200423103113.GY14075@vanye> References: <20200415121342.9246-1-pankaj.bansal@oss.nxp.com> <20200415121342.9246-22-pankaj.bansal@oss.nxp.com> MIME-Version: 1.0 In-Reply-To: <20200415121342.9246-22-pankaj.bansal@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 15, 2020 at 17:43:39 +0530, Pankaj Bansal wrote: > From: Pankaj Bansal > > FVRules.fdf.inc is being replaced by the ArmVirtPkg/ArmVirtRules.fdf.inc > at commit hash 746c5b6238f1ee55deb4b3ec32a6d732e27eeeaa This is better - but why? / Leif > Signed-off-by: Pankaj Bansal > --- > > Notes: > - Modify commit description > > Platform/NXP/FVRules.fdf.inc | 59 +++++++++++++------- > 1 file changed, 38 insertions(+), 21 deletions(-) > > diff --git a/Platform/NXP/FVRules.fdf.inc b/Platform/NXP/FVRules.fdf.inc > index c9fba65dae85..63de26abe056 100644 > --- a/Platform/NXP/FVRules.fdf.inc > +++ b/Platform/NXP/FVRules.fdf.inc > @@ -1,8 +1,7 @@ > -# FvRules.fdf.inc > # > -# Rules for creating FD. > -# > -# Copyright 2017-2019 NXP > +# Copyright (c) 2011-2015, ARM Limited. All rights reserved. > +# Copyright (c) 2014-2016, Linaro Limited. All rights reserved. > +# Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -16,40 +15,49 @@ > # > ################################################################################ > > + > +############################################################################ > +# Example of a DXE_DRIVER FFS file with a Checksum encapsulation section # > +############################################################################ > +# > +#[Rule.Common.DXE_DRIVER] > +# FILE DRIVER = $(NAMED_GUID) { > +# DXE_DEPEX DXE_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > +# COMPRESS PI_STD { > +# GUIDED { > +# PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > +# UI STRING="$(MODULE_NAME)" Optional > +# VERSION STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER) > +# } > +# } > +# } > +# > +############################################################################ > + > [Rule.Common.SEC] > - FILE SEC = $(NAMED_GUID) RELOCS_STRIPPED { > - TE TE Align = 32 $(INF_OUTPUT)/$(MODULE_NAME).efi > + FILE SEC = $(NAMED_GUID) RELOCS_STRIPPED FIXED { > + TE TE Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi > } > > [Rule.Common.PEI_CORE] > - FILE PEI_CORE = $(NAMED_GUID) { > - TE TE $(INF_OUTPUT)/$(MODULE_NAME).efi > + FILE PEI_CORE = $(NAMED_GUID) FIXED { > + TE TE Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi > UI STRING ="$(MODULE_NAME)" Optional > } > > [Rule.Common.PEIM] > - FILE PEIM = $(NAMED_GUID) { > + FILE PEIM = $(NAMED_GUID) FIXED { > PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > + TE TE Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi > UI STRING="$(MODULE_NAME)" Optional > } > > -[Rule.Common.PEIM.TIANOCOMPRESSED] > - FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 { > - PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > - GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE { > - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > - UI STRING="$(MODULE_NAME)" Optional > - } > - } > - > [Rule.Common.DXE_CORE] > FILE DXE_CORE = $(NAMED_GUID) { > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > UI STRING="$(MODULE_NAME)" Optional > } > > - > [Rule.Common.UEFI_DRIVER] > FILE DRIVER = $(NAMED_GUID) { > DXE_DEPEX DXE_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > @@ -62,6 +70,8 @@ > DXE_DEPEX DXE_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > UI STRING="$(MODULE_NAME)" Optional > + RAW ACPI Optional |.acpi > + RAW ASL Optional |.aml > } > > [Rule.Common.DXE_RUNTIME_DRIVER] > @@ -73,7 +83,7 @@ > > [Rule.Common.UEFI_APPLICATION] > FILE APPLICATION = $(NAMED_GUID) { > - UI STRING ="$(MODULE_NAME)" Optional > + UI STRING ="$(MODULE_NAME)" Optional > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > } > > @@ -91,3 +101,10 @@ > UI STRING="$(MODULE_NAME)" Optional > VERSION STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER) > } > + > +[Rule.Common.USER_DEFINED.ACPITABLE] > + FILE FREEFORM = $(NAMED_GUID) { > + RAW ACPI |.acpi > + RAW ASL |.aml > + UI STRING="$(MODULE_NAME)" Optional > + } > -- > 2.17.1 >