From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175])
 by mx.groups.io with SMTP id smtpd.web12.37.1587997174294888379
 for <devel@edk2.groups.io>;
 Mon, 27 Apr 2020 07:19:34 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@citrix.com header.s=securemail header.b=W4EJddOi;
 spf=pass (domain: citrix.com, ip: 216.71.155.175, mailfrom: anthony.perard@citrix.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1587997174;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=Pq2dinV5cvyud5nk7B7aigiRNPNV+xK6OSdHrXD9PyM=;
  b=W4EJddOiLQFJjaYoCdfpNSo0mVl66iAWIMpyy1pIdWiBKDNjWLb0BJbH
   9ZAmi/sL/bsrSqBjrczncxqbAkzLG5BKb7Pzn3mipwi2gN1IQp5sfPATr
   Pd6u2mfEDtlT9TXgXbdyZfX9HAAn8ixySQobgbRDBADljT5qCUclMUfSl
   0=;
Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com
Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender
  authenticity information available from domain of
  anthony.perard@citrix.com) identity=pra;
  client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com;
  envelope-from="anthony.perard@citrix.com";
  x-sender="anthony.perard@citrix.com";
  x-conformance=sidf_compatible
Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of
  anthony.perard@citrix.com designates 162.221.158.21 as
  permitted sender) identity=mailfrom;
  client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com;
  envelope-from="anthony.perard@citrix.com";
  x-sender="anthony.perard@citrix.com";
  x-conformance=sidf_compatible; x-record-type="v=spf1";
  x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133
  ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4
  ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88
  ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83
  ip4:168.245.78.127 ~all"
Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender
  authenticity information available from domain of
  postmaster@mail.citrix.com) identity=helo;
  client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com;
  envelope-from="anthony.perard@citrix.com";
  x-sender="postmaster@mail.citrix.com";
  x-conformance=sidf_compatible
IronPort-SDR: XEDJu/+UJadgh/E2Bi/C+Jtaqh/JRGojH4qvrg7OYOl03Q8Yv4LjD8qvj1QsxdXxm6KgWteJjr
 AVzEei1lUslQaTOzj5Gmp+t2269SnkC1LcB5iGSMhBSLBIlwZ7pTybSv4HvSF/QTDnAQe8f9Va
 0gC0QDC47NXL/FwBEbokF5gu2sdfLtHvJc97onAoHIMV/w/iy7s2Dh5Eb6wThDbn7pWNC0NqLi
 0RG0d+zf85tYQOiWzv8oiXGByzENclqkwoTiaJE5c44l1bCoz0fWZPpdFnd+bFrNY6pYjyBCJF
 cks=
X-SBRS: 2.7
X-MesageID: 16706609
X-Ironport-Server: esa6.hc3370-68.iphmx.com
X-Remote-IP: 162.221.158.21
X-Policy: $RELAYED
X-IronPort-AV: E=Sophos;i="5.73,324,1583211600"; 
   d="scan'208";a="16706609"
Date: Mon, 27 Apr 2020 15:19:30 +0100
From: "Anthony PERARD" <anthony.perard@citrix.com>
To: Laszlo Ersek <lersek@redhat.com>
CC: <devel@edk2.groups.io>, Ard Biesheuvel <ard.biesheuvel@arm.com>, "Jordan
 Justen" <jordan.l.justen@intel.com>, Julien Grall <julien@xen.org>
Subject: Re: [edk2-devel] [PATCH v2 4/5] OvmfPkg/PlatformDebugLibIoPort: Introduce a Nocheck variant
Message-ID: <20200427141930.GA2116@perard.uk.xensource.com>
References: <20200423095358.2518197-1-anthony.perard@citrix.com>
 <20200423095358.2518197-5-anthony.perard@citrix.com>
 <1f5cc358-7338-08e8-7761-6bdfa286e196@redhat.com>
MIME-Version: 1.0
In-Reply-To: <1f5cc358-7338-08e8-7761-6bdfa286e196@redhat.com>
Return-Path: anthony.perard@citrix.com
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

On Fri, Apr 24, 2020 at 07:58:48PM +0200, Laszlo Ersek wrote:
> On 04/23/20 11:53, Anthony PERARD wrote:
> > @@ -24,10 +23,10 @@ [Defines]
> >  #
> >  
> >  [Sources]
> > -  DebugIoPortQemu.c
> > +  DebugIoPortNocheck.c
> >    DebugLib.c
> > -  DebugLibDetect.h
> >    DebugLibDetectRom.c
> > +  DebugLibDetect.h
> 
> (2) The re-ordering of "DebugLibDetect.h" is curious. Maybe you may have
> an LC_COLLATE setting that sorts "." after "R"?

I think it's more likely that I've copied the .inf that uses
"DebugLibDetect.c", edited that line to add "Rom" and forgot to resort
the list.

> Anyway I can re-sort this when I merge the series.
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks.

-- 
Anthony PERARD