From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by mx.groups.io with SMTP id smtpd.web12.133.1587997359927317216 for ; Mon, 27 Apr 2020 07:22:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@citrix.com header.s=securemail header.b=Ucf6mNGa; spf=pass (domain: citrix.com, ip: 216.71.145.153, mailfrom: anthony.perard@citrix.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1587997360; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vE3qGS5eMCJz6vd/q9HznGzA81tlGpTo7z6rzkwQCMg=; b=Ucf6mNGazcjj7MVIvOJtoyuOJA9D114KmkfhwPMXiCiN+98MigZgLXs6 tZwyWvxIlGsFOSwvzzd0kkJWTEwo5QABMdqQfSwDrNvqRlqKFps0eh0yC gU+K00+ghDiVejIiB5V+i7jewiqZKVeSrdfYNNW1eVRe5kmOArWQkH5f3 g=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: r4ITBKr0eWCbIc/TdboHt3vJE2mKMAR7Zyluj6dawzi+FiT6U+JXGy+ZEO+VMMlwleORXgd8Z5 9U6dCE6I+vMPUrODtsI3/e+ZDJuwQP9tF92zV7JRehDAQ0l5diBtzExoDi1cckjYuvM4BtRNaU WSHKwbQ+0G98uCRt8yVgWLKZgZNbCRXbalMeO1TNpl+GiiPG4NUaHu6HdSfIVd4pDxEmn0OkJ5 kIXWULfatp6058DlTkMa0w+N47Jb3H40L36FOQWwOeb+qj1XyGIVjbjFz3qS99rLam73jui5Ek ZSI= X-SBRS: 2.7 X-MesageID: 16321006 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,324,1583211600"; d="scan'208";a="16321006" Date: Mon, 27 Apr 2020 15:22:36 +0100 From: "Anthony PERARD" To: Laszlo Ersek CC: , Ard Biesheuvel , Jordan Justen , Julien Grall Subject: Re: [edk2-devel] [PATCH v2 5/5] OvmfPkg/OvmfXen: Introduce DEBUG_ON_HYPERVISOR_CONSOLE build flag Message-ID: <20200427142236.GB2116@perard.uk.xensource.com> References: <20200423095358.2518197-1-anthony.perard@citrix.com> <20200423095358.2518197-6-anthony.perard@citrix.com> MIME-Version: 1.0 In-Reply-To: Return-Path: anthony.perard@citrix.com Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Fri, Apr 24, 2020 at 08:05:53PM +0200, Laszlo Ersek wrote: > On 04/23/20 11:53, Anthony PERARD wrote: > > [LibraryClasses.common.SEC] > > QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf > > +!ifdef $(DEBUG_ON_HYPERVISOR_CONSOLE) > > + DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformRomDebugLibIoPortNocheck.inf > > +!else > > DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformRomDebugLibIoPort.inf > > +!endif > > (1) This part can be simplified with an !ifndef, instead, I think. (When > DEBUG_ON_HYPERVISOR_CONSOLE is defined, then the default resolution can > take effect for SEC too.) Sounds good. > If you wish I can change this for you as well. Alternatively, if you'd > rather repost, that's OK too. (And maybe Phil intends to review more of > the patches in this series; I'm not sure.) Feel free to edit on commit. > With (1) updated: > > Reviewed-by: Laszlo Ersek Thanks, -- Anthony PERARD