* [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
@ 2020-04-28 1:21 GH Cao
2020-04-28 23:04 ` [edk2-devel] " Andrei Warkentin
0 siblings, 1 reply; 4+ messages in thread
From: GH Cao @ 2020-04-28 1:21 UTC (permalink / raw)
To: devel; +Cc: GH Cao
The original comment incorrectly named the PWM controller as Power Management
Contoller, this commit fixes it.
Signed-off-by: GH Cao <driver1998@foxmail.com>
---
Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
index e2581b8..2d7da75 100644
--- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
+++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
@@ -11,7 +11,7 @@
#ifndef __BCM2836_PWM_H__
#define __BCM2836_PWM_H__
-/* Power Management constants */
+/* PWM controller constants */
#define BCM2836_PWM_DMA_OFFSET 0x00007B00
#define BCM2836_PWM_DMA_BASE_ADDRESS (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
@ 2020-04-28 5:08 driver1998
2020-04-28 9:46 ` Pete Batard
0 siblings, 1 reply; 4+ messages in thread
From: driver1998 @ 2020-04-28 5:08 UTC (permalink / raw)
To: devel; +Cc: ard.biesheuvel, leif, pete, GH Cao
The original comment incorrectly named the PWM controller as Power Management
Contoller, this commit fixes it.
Signed-off-by: GH Cao <driver1998@foxmail.com>
---
Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
index e2581b8..2d7da75 100644
--- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
+++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
@@ -11,7 +11,7 @@
#ifndef __BCM2836_PWM_H__
#define __BCM2836_PWM_H__
-/* Power Management constants */
+/* PWM controller constants */
#define BCM2836_PWM_DMA_OFFSET 0x00007B00
#define BCM2836_PWM_DMA_BASE_ADDRESS (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
2020-04-28 5:08 driver1998
@ 2020-04-28 9:46 ` Pete Batard
0 siblings, 0 replies; 4+ messages in thread
From: Pete Batard @ 2020-04-28 9:46 UTC (permalink / raw)
To: GH Cao, devel; +Cc: ard.biesheuvel, leif
On 2020.04.28 06:08, GH Cao wrote:
> The original comment incorrectly named the PWM controller as Power Management
> Contoller, this commit fixes it.
>
> Signed-off-by: GH Cao <driver1998@foxmail.com>
> ---
> Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> index e2581b8..2d7da75 100644
> --- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> +++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> @@ -11,7 +11,7 @@
> #ifndef __BCM2836_PWM_H__
> #define __BCM2836_PWM_H__
>
> -/* Power Management constants */
> +/* PWM controller constants */
>
> #define BCM2836_PWM_DMA_OFFSET 0x00007B00
> #define BCM2836_PWM_DMA_BASE_ADDRESS (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
>
Reviewed-by: Pete Batard <pete@akeo.ie>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
2020-04-28 1:21 [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h GH Cao
@ 2020-04-28 23:04 ` Andrei Warkentin
0 siblings, 0 replies; 4+ messages in thread
From: Andrei Warkentin @ 2020-04-28 23:04 UTC (permalink / raw)
To: devel, driver1998
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
Reviewed-by: Andrei Warkentin <andrey.warkentin@gmail.com>
On Tue, Apr 28, 2020 at 1:34 AM GH Cao <driver1998@foxmail.com> wrote:
> The original comment incorrectly named the PWM controller as Power
> Management
> Contoller, this commit fixes it.
>
> Signed-off-by: GH Cao <driver1998@foxmail.com>
> ---
> Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> index e2581b8..2d7da75 100644
> --- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> +++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> @@ -11,7 +11,7 @@
> #ifndef __BCM2836_PWM_H__
> #define __BCM2836_PWM_H__
>
> -/* Power Management constants */
> +/* PWM controller constants */
>
> #define BCM2836_PWM_DMA_OFFSET 0x00007B00
> #define BCM2836_PWM_DMA_BASE_ADDRESS
> (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
> --
> 2.17.1
>
>
>
>
>
--
A
[-- Attachment #2: Type: text/html, Size: 1714 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-28 23:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-28 1:21 [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h GH Cao
2020-04-28 23:04 ` [edk2-devel] " Andrei Warkentin
-- strict thread matches above, loose matches on Subject: below --
2020-04-28 5:08 driver1998
2020-04-28 9:46 ` Pete Batard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox