* [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
@ 2020-04-28 5:08 driver1998
2020-04-28 9:46 ` Pete Batard
2020-04-28 11:25 ` [edk2-devel] " Philippe Mathieu-Daudé
0 siblings, 2 replies; 5+ messages in thread
From: driver1998 @ 2020-04-28 5:08 UTC (permalink / raw)
To: devel; +Cc: ard.biesheuvel, leif, pete, GH Cao
The original comment incorrectly named the PWM controller as Power Management
Contoller, this commit fixes it.
Signed-off-by: GH Cao <driver1998@foxmail.com>
---
Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
index e2581b8..2d7da75 100644
--- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
+++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
@@ -11,7 +11,7 @@
#ifndef __BCM2836_PWM_H__
#define __BCM2836_PWM_H__
-/* Power Management constants */
+/* PWM controller constants */
#define BCM2836_PWM_DMA_OFFSET 0x00007B00
#define BCM2836_PWM_DMA_BASE_ADDRESS (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
2020-04-28 5:08 [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h driver1998
@ 2020-04-28 9:46 ` Pete Batard
2020-04-28 11:25 ` [edk2-devel] " Philippe Mathieu-Daudé
1 sibling, 0 replies; 5+ messages in thread
From: Pete Batard @ 2020-04-28 9:46 UTC (permalink / raw)
To: GH Cao, devel; +Cc: ard.biesheuvel, leif
On 2020.04.28 06:08, GH Cao wrote:
> The original comment incorrectly named the PWM controller as Power Management
> Contoller, this commit fixes it.
>
> Signed-off-by: GH Cao <driver1998@foxmail.com>
> ---
> Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> index e2581b8..2d7da75 100644
> --- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> +++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> @@ -11,7 +11,7 @@
> #ifndef __BCM2836_PWM_H__
> #define __BCM2836_PWM_H__
>
> -/* Power Management constants */
> +/* PWM controller constants */
>
> #define BCM2836_PWM_DMA_OFFSET 0x00007B00
> #define BCM2836_PWM_DMA_BASE_ADDRESS (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
>
Reviewed-by: Pete Batard <pete@akeo.ie>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
2020-04-28 5:08 [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h driver1998
2020-04-28 9:46 ` Pete Batard
@ 2020-04-28 11:25 ` Philippe Mathieu-Daudé
2020-04-30 7:42 ` Ard Biesheuvel
1 sibling, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-04-28 11:25 UTC (permalink / raw)
To: devel, driver1998; +Cc: ard.biesheuvel, leif, pete
On 4/28/20 7:08 AM, GH Cao wrote:
> The original comment incorrectly named the PWM controller as Power Management
> Contoller, this commit fixes it.
>
> Signed-off-by: GH Cao <driver1998@foxmail.com>
> ---
> Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> index e2581b8..2d7da75 100644
> --- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> +++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> @@ -11,7 +11,7 @@
> #ifndef __BCM2836_PWM_H__
> #define __BCM2836_PWM_H__
>
> -/* Power Management constants */
> +/* PWM controller constants */
>
> #define BCM2836_PWM_DMA_OFFSET 0x00007B00
> #define BCM2836_PWM_DMA_BASE_ADDRESS (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
2020-04-28 11:25 ` [edk2-devel] " Philippe Mathieu-Daudé
@ 2020-04-30 7:42 ` Ard Biesheuvel
0 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2020-04-30 7:42 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, devel, driver1998; +Cc: leif, pete
On 4/28/20 1:25 PM, Philippe Mathieu-Daudé wrote:
> On 4/28/20 7:08 AM, GH Cao wrote:
>> The original comment incorrectly named the PWM controller as Power
>> Management
>> Contoller, this commit fixes it.
>>
>> Signed-off-by: GH Cao <driver1998@foxmail.com>
>> ---
>> Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
>> b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
>> index e2581b8..2d7da75 100644
>> --- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
>> +++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
>> @@ -11,7 +11,7 @@
>> #ifndef __BCM2836_PWM_H__
>> #define __BCM2836_PWM_H__
>> -/* Power Management constants */
>> +/* PWM controller constants */
>> #define BCM2836_PWM_DMA_OFFSET 0x00007B00
>> #define BCM2836_PWM_DMA_BASE_ADDRESS
>> (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
>>
>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>
Thanks all
Series pushed as 6e4ebde90186..1b2461ea7f2f
^ permalink raw reply [flat|nested] 5+ messages in thread
* [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
@ 2020-04-28 1:21 GH Cao
0 siblings, 0 replies; 5+ messages in thread
From: GH Cao @ 2020-04-28 1:21 UTC (permalink / raw)
To: devel; +Cc: GH Cao
The original comment incorrectly named the PWM controller as Power Management
Contoller, this commit fixes it.
Signed-off-by: GH Cao <driver1998@foxmail.com>
---
Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
index e2581b8..2d7da75 100644
--- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
+++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
@@ -11,7 +11,7 @@
#ifndef __BCM2836_PWM_H__
#define __BCM2836_PWM_H__
-/* Power Management constants */
+/* PWM controller constants */
#define BCM2836_PWM_DMA_OFFSET 0x00007B00
#define BCM2836_PWM_DMA_BASE_ADDRESS (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-30 7:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-28 5:08 [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h driver1998
2020-04-28 9:46 ` Pete Batard
2020-04-28 11:25 ` [edk2-devel] " Philippe Mathieu-Daudé
2020-04-30 7:42 ` Ard Biesheuvel
-- strict thread matches above, loose matches on Subject: below --
2020-04-28 1:21 GH Cao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox