From: "Miki Shindo" <miki.shindo@intel.com>
To: devel@edk2.groups.io
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>,
Chasel Chiu <chasel.chiu@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Prince Agyeman <prince.agyeman@intel.com>,
Ray Ni <ray.ni@intel.com>
Subject: [edk2-platforms:PATCH v4 6/7] CoffeelakeSiliconPkg/DxeAslUpdateLib: Cleans up APIs
Date: Tue, 28 Apr 2020 19:32:02 -0700 [thread overview]
Message-ID: <20200429023203.37544-7-miki.shindo@intel.com> (raw)
In-Reply-To: <20200429023203.37544-1-miki.shindo@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2536
Callers of DxeAslUpdateLib don't have to call InitializeAslUpdateLib()
but the library itself runs it internally. This commit deletes
the redundant calls in caller side and makes it an internal call.
LocateAcpiTableByOemTableId() is unreferenced externally
so this commit makes it an internal call.
PSS_PACKAGE_LAYOUT and AML_RESRC_TEMP_END_TAG are both unreferenced
so they are removed.
AslUpdateLib.h is cleaned up accordingly.
Signed-off-by: Miki Shindo <miki.shindo@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
---
Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c | 190 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------------------------
Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------
Silicon/Intel/CoffeelakeSiliconPkg/Pch/PchInit/Dxe/PchAcpi.c | 3 ---
Silicon/Intel/CoffeelakeSiliconPkg/Include/Library/AslUpdateLib.h | 114 +++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------
4 files changed, 180 insertions(+), 221 deletions(-)
diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
index 04cf66fd2f..f18ca835ad 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.c
@@ -6,7 +6,7 @@
This library uses the ACPI Support protocol.
- Copyright (c) 2019 Intel Corporation. All rights reserved. <BR>
+ Copyright (c) 2019 -2020, Intel Corporation. All rights reserved. <BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -51,6 +51,62 @@ InitializeAslUpdateLib (
return Status;
}
+/**
+ This function uses the ACPI SDT protocol to locate an ACPI SSDT table.
+
+ @param[in] TableId - Pointer to an ASCII string containing the OEM Table ID from the ACPI table header
+ @param[in] TableIdSize - Length of the TableId to match. Table ID are 8 bytes long, this function
+ will consider it a match if the first TableIdSize bytes match
+ @param[in, out] Table - Updated with a pointer to the table
+ @param[in, out] Handle - AcpiSupport protocol table handle for the table found
+
+ @retval EFI_SUCCESS - The function completed successfully.
+ @retval EFI_NOT_FOUND - Failed to locate AcpiTable.
+ @retval EFI_NOT_READY - Not ready to locate AcpiTable.
+**/
+EFI_STATUS
+LocateAcpiTableByOemTableId (
+ IN UINT8 *TableId,
+ IN UINT8 TableIdSize,
+ IN OUT EFI_ACPI_DESCRIPTION_HEADER **Table,
+ IN OUT UINTN *Handle
+ )
+{
+ EFI_STATUS Status;
+ INTN Index;
+ EFI_ACPI_TABLE_VERSION Version;
+ EFI_ACPI_DESCRIPTION_HEADER *OrgTable;
+
+ if (mAcpiSdt == NULL) {
+ InitializeAslUpdateLib ();
+ if (mAcpiSdt == NULL) {
+ return EFI_NOT_READY;
+ }
+ }
+ ///
+ /// Locate table with matching ID
+ ///
+ Version = 0;
+ Index = 0;
+ do {
+ Status = mAcpiSdt->GetAcpiTable (Index, (EFI_ACPI_SDT_HEADER **)&OrgTable, &Version, Handle);
+ if (Status == EFI_NOT_FOUND) {
+ break;
+ }
+ ASSERT_EFI_ERROR (Status);
+ Index++;
+ } while (CompareMem (&(OrgTable->OemTableId), TableId, TableIdSize));
+
+ if (Status != EFI_NOT_FOUND) {
+ *Table = AllocateCopyPool (OrgTable->Length, OrgTable);
+ ASSERT (*Table);
+ }
+
+ ///
+ /// If we found the table, there will be no error.
+ ///
+ return Status;
+}
/**
This procedure will update immediate value assigned to a Name
@@ -61,8 +117,10 @@ InitializeAslUpdateLib (
@retval EFI_SUCCESS - The function completed successfully.
@retval EFI_NOT_FOUND - Failed to locate AcpiTable.
+ @retval EFI_NOT_READY - Not ready to locate AcpiTable.
**/
EFI_STATUS
+EFIAPI
UpdateNameAslCode (
IN UINT32 AslSignature,
IN VOID *Buffer,
@@ -154,6 +212,29 @@ UpdateNameAslCode (
return EFI_NOT_FOUND;
}
+/**
+ This procedure will update immediate value assigned to a Name in SSDT table
+
+ @param[in] TableId - Pointer to an ASCII string containing the OEM Table ID from the ACPI table header
+ @param[in] TableIdSize - Length of the TableId to match. Table ID are 8 bytes long, this function
+ @param[in] Buffer - source of data to be written over original aml
+ @param[in] Length - length of data to be overwritten
+
+ @retval EFI_UNSUPPORTED The function is not supported in this library.
+**/
+EFI_STATUS
+EFIAPI
+UpdateSsdtNameAslCode (
+ IN UINT8 *TableId,
+ IN UINT8 TableIdSize,
+ IN UINT32 AslSignature,
+ IN VOID *Buffer,
+ IN UINTN Length
+ )
+{
+ return EFI_UNSUPPORTED;
+}
+
/**
This procedure will update the name of ASL Method
@@ -163,8 +244,10 @@ UpdateNameAslCode (
@retval EFI_SUCCESS - The function completed successfully.
@retval EFI_NOT_FOUND - Failed to locate AcpiTable.
+ @retval EFI_NOT_READY - Not ready to locate AcpiTable.
**/
EFI_STATUS
+EFIAPI
UpdateMethodAslCode (
IN UINT32 AslSignature,
IN VOID *Buffer,
@@ -253,11 +336,13 @@ UpdateMethodAslCode (
@param[in] Signature - Pointer to an ASCII string containing the OEM Table ID from the ACPI table header
@param[in, out] Table - Updated with a pointer to the table
@param[in, out] Handle - AcpiSupport protocol table handle for the table found
- @param[in, out] Version - The version of the table desired
@retval EFI_SUCCESS - The function completed successfully.
+ @retval EFI_NOT_FOUND - Failed to locate AcpiTable.
+ @retval EFI_NOT_READY - Not ready to locate AcpiTable.
**/
EFI_STATUS
+EFIAPI
LocateAcpiTableBySignature (
IN UINT32 Signature,
IN OUT EFI_ACPI_DESCRIPTION_HEADER **Table,
@@ -300,104 +385,3 @@ LocateAcpiTableBySignature (
///
return Status;
}
-
-/**
- This function uses the ACPI SDT protocol to locate an ACPI SSDT table.
-
- @param[in] TableId - Pointer to an ASCII string containing the OEM Table ID from the ACPI table header
- @param[in] TableIdSize - Length of the TableId to match. Table ID are 8 bytes long, this function
- will consider it a match if the first TableIdSize bytes match
- @param[in, out] Table - Updated with a pointer to the table
- @param[in, out] Handle - AcpiSupport protocol table handle for the table found
- @param[in, out] Version - See AcpiSupport protocol, GetAcpiTable function for use
-
- @retval EFI_SUCCESS - The function completed successfully.
-**/
-EFI_STATUS
-LocateAcpiTableByOemTableId (
- IN UINT8 *TableId,
- IN UINT8 TableIdSize,
- IN OUT EFI_ACPI_DESCRIPTION_HEADER **Table,
- IN OUT UINTN *Handle
- )
-{
- EFI_STATUS Status;
- INTN Index;
- EFI_ACPI_TABLE_VERSION Version;
- EFI_ACPI_DESCRIPTION_HEADER *OrgTable;
-
- if (mAcpiSdt == NULL) {
- InitializeAslUpdateLib ();
- if (mAcpiSdt == NULL) {
- return EFI_NOT_READY;
- }
- }
- ///
- /// Locate table with matching ID
- ///
- Version = 0;
- Index = 0;
- do {
- Status = mAcpiSdt->GetAcpiTable (Index, (EFI_ACPI_SDT_HEADER **)&OrgTable, &Version, Handle);
- if (Status == EFI_NOT_FOUND) {
- break;
- }
- ASSERT_EFI_ERROR (Status);
- Index++;
- } while (CompareMem (&(OrgTable->OemTableId), TableId, TableIdSize));
-
- if (Status != EFI_NOT_FOUND) {
- *Table = AllocateCopyPool (OrgTable->Length, OrgTable);
- ASSERT (*Table);
- }
-
- ///
- /// If we found the table, there will be no error.
- ///
- return Status;
-}
-
-/**
- This function calculates and updates an UINT8 checksum.
-
- @param[in] Buffer Pointer to buffer to checksum
- @param[in] Size Number of bytes to checksum
- @param[in] ChecksumOffset Offset to place the checksum result in
-
- @retval EFI_SUCCESS The function completed successfully.
-**/
-EFI_STATUS
-AcpiChecksum (
- IN VOID *Buffer,
- IN UINTN Size,
- IN UINTN ChecksumOffset
- )
-{
- UINT8 Sum;
- UINT8 *Ptr;
-
- Sum = 0;
- ///
- /// Initialize pointer
- ///
- Ptr = Buffer;
-
- ///
- /// set checksum to 0 first
- ///
- Ptr[ChecksumOffset] = 0;
-
- ///
- /// add all content of buffer
- ///
- while (Size--) {
- Sum = (UINT8) (Sum + (*Ptr++));
- }
- ///
- /// set checksum
- ///
- Ptr = Buffer;
- Ptr[ChecksumOffset] = (UINT8) (0xff - Sum + 1);
-
- return EFI_SUCCESS;
-}
diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
index a7ce92b7c3..63e232f04b 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/Library/DxeAslUpdateLibNull/DxeAslUpdateLibNull.c
@@ -6,7 +6,7 @@
This library uses the ACPI Support protocol.
- Copyright (c) 2019 Intel Corporation. All rights reserved. <BR>
+ Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved. <BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -40,6 +40,27 @@ InitializeAslUpdateLib (
return EFI_SUCCESS;
}
+/**
+ This function uses the ACPI SDT protocol to locate an ACPI SSDT table.
+
+ @param[in] TableId - Pointer to an ASCII string containing the OEM Table ID from the ACPI table header
+ @param[in] TableIdSize - Length of the TableId to match. Table ID are 8 bytes long, this function
+ will consider it a match if the first TableIdSize bytes match
+ @param[in, out] Table - Updated with a pointer to the table
+ @param[in, out] Handle - AcpiSupport protocol table handle for the table found
+
+ @retval EFI_SUCCESS - The function completed successfully.
+**/
+EFI_STATUS
+LocateAcpiTableByOemTableId (
+ IN UINT8 *TableId,
+ IN UINT8 TableIdSize,
+ IN OUT EFI_ACPI_DESCRIPTION_HEADER **Table,
+ IN OUT UINTN *Handle
+ )
+{
+ return EFI_SUCCESS;
+}
/**
This procedure will update immediate value assigned to a Name
@@ -51,6 +72,7 @@ InitializeAslUpdateLib (
@retval EFI_SUCCESS - The function completed successfully.
**/
EFI_STATUS
+EFIAPI
UpdateNameAslCode (
IN UINT32 AslSignature,
IN VOID *Buffer,
@@ -60,66 +82,66 @@ UpdateNameAslCode (
return EFI_SUCCESS;
}
-
/**
- This function uses the ACPI SDT protocol to locate an ACPI table.
- It is really only useful for finding tables that only have a single instance,
- e.g. FADT, FACS, MADT, etc. It is not good for locating SSDT, etc.
+ This procedure will update immediate value assigned to a Name in SSDT table
- @param[in] Signature - Pointer to an ASCII string containing the OEM Table ID from the ACPI table header
- @param[in, out] Table - Updated with a pointer to the table
- @param[in, out] Handle - AcpiSupport protocol table handle for the table found
- @param[in, out] Version - The version of the table desired
+ @param[in] TableId - Pointer to an ASCII string containing the OEM Table ID from the ACPI table header
+ @param[in] TableIdSize - Length of the TableId to match. Table ID are 8 bytes long, this function
+ @param[in] Buffer - source of data to be written over original aml
+ @param[in] Length - length of data to be overwritten
- @retval EFI_SUCCESS - The function completed successfully.
+ @retval EFI_SUCCESS - The function completed successfully.
**/
EFI_STATUS
-LocateAcpiTableBySignature (
- IN UINT32 Signature,
- IN OUT EFI_ACPI_DESCRIPTION_HEADER **Table,
- IN OUT UINTN *Handle
+EFIAPI
+UpdateSsdtNameAslCode (
+ IN UINT8 *TableId,
+ IN UINT8 TableIdSize,
+ IN UINT32 AslSignature,
+ IN VOID *Buffer,
+ IN UINTN Length
)
{
return EFI_SUCCESS;
}
/**
- This function uses the ACPI SDT protocol to locate an ACPI SSDT table.
+ This procedure will update the name of ASL Method
- @param[in] TableId - Pointer to an ASCII string containing the OEM Table ID from the ACPI table header
- @param[in] TableIdSize - Length of the TableId to match. Table ID are 8 bytes long, this function
- will consider it a match if the first TableIdSize bytes match
- @param[in, out] Table - Updated with a pointer to the table
- @param[in, out] Handle - AcpiSupport protocol table handle for the table found
- @param[in, out] Version - See AcpiSupport protocol, GetAcpiTable function for use
+ @param[in] AslSignature - The signature of Operation Region that we want to update.
+ @param[in] Buffer - source of data to be written over original aml
+ @param[in] Length - length of data to be overwritten
@retval EFI_SUCCESS - The function completed successfully.
**/
EFI_STATUS
-LocateAcpiTableByOemTableId (
- IN UINT8 *TableId,
- IN UINT8 TableIdSize,
- IN OUT EFI_ACPI_DESCRIPTION_HEADER **Table,
- IN OUT UINTN *Handle
+EFIAPI
+UpdateMethodAslCode (
+ IN UINT32 AslSignature,
+ IN VOID *Buffer,
+ IN UINTN Length
)
{
return EFI_SUCCESS;
}
/**
- This function calculates and updates an UINT8 checksum.
-
- @param[in] Buffer Pointer to buffer to checksum
- @param[in] Size Number of bytes to checksum
- @param[in] ChecksumOffset Offset to place the checksum result in
+ This function uses the ACPI SDT protocol to locate an ACPI table.
+ It is really only useful for finding tables that only have a single instance,
+ e.g. FADT, FACS, MADT, etc. It is not good for locating SSDT, etc.
- @retval EFI_SUCCESS The function completed successfully.
+ @param[in] Signature - Pointer to an ASCII string containing the OEM Table ID from the ACPI table header
+ @param[in, out] Table - Updated with a pointer to the table
+ @param[in, out] Handle - AcpiSupport protocol table handle for the table found
+s
+ @retval EFI_SUCCESS - The function completed successfully.
**/
EFI_STATUS
-AcpiChecksum (
- IN VOID *Buffer,
- IN UINTN Size,
- IN UINTN ChecksumOffset
+EFIAPI
+LocateAcpiTableBySignature (
+ IN UINT32 Signature,
+ IN OUT EFI_ACPI_DESCRIPTION_HEADER **Table,
+ IN OUT UINTN *Handle
)
{
return EFI_SUCCESS;
diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/PchInit/Dxe/PchAcpi.c b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/PchInit/Dxe/PchAcpi.c
index 12f1a7f4fe..807cdb92f7 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/PchInit/Dxe/PchAcpi.c
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/PchInit/Dxe/PchAcpi.c
@@ -438,9 +438,6 @@ PatchPchNvsAreaAddress (
UINT32 Address;
UINT16 Length;
- Status = InitializeAslUpdateLib ();
- ASSERT_EFI_ERROR (Status);
-
Address = (UINT32) (UINTN) mPchNvsAreaProtocol.Area;
Length = (UINT16) sizeof (PCH_NVS_AREA);
DEBUG ((DEBUG_INFO, "PatchPchNvsAreaAddress: PCH NVS Address %x Length %x\n", Address, Length));
diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Library/AslUpdateLib.h b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Library/AslUpdateLib.h
index 39baa6c03a..1a0ec4fa16 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Library/AslUpdateLib.h
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Library/AslUpdateLib.h
@@ -5,7 +5,7 @@
Make sure you meet the requirements for the library (protocol dependencies, use
restrictions, etc).
- Copyright (c) 2019 Intel Corporation. All rights reserved. <BR>
+ Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved. <BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -16,61 +16,50 @@
//
// Include files
//
+#include <Uefi/UefiBaseType.h>
#include <IndustryStandard/Acpi.h>
#include <Protocol/AcpiTable.h>
#include <Protocol/AcpiSystemDescriptionTable.h>
-//
-// AML parsing definitions
-//
-#define AML_RESRC_TEMP_END_TAG 0x0079
-
-//
-// ASL PSS package structure layout
-//
-#pragma pack (1)
-typedef struct {
- UINT8 NameOp; // 12h ;First opcode is a NameOp.
- UINT8 PackageLead; // 20h ;First opcode is a NameOp.
- UINT8 NumEntries; // 06h ;First opcode is a NameOp.
- UINT8 DwordPrefix1; // 0Ch
- UINT32 CoreFrequency; // 00h
- UINT8 DwordPrefix2; // 0Ch
- UINT32 Power; // 00h
- UINT8 DwordPrefix3; // 0Ch
- UINT32 TransLatency; // 00h
- UINT8 DwordPrefix4; // 0Ch
- UINT32 BmLatency; // 00h
- UINT8 DwordPrefix5; // 0Ch
- UINT32 Control; // 00h
- UINT8 DwordPrefix6; // 0Ch
- UINT32 Status; // 00h
-} PSS_PACKAGE_LAYOUT;
-#pragma pack()
-
/**
- Initialize the ASL update library state.
- This must be called prior to invoking other library functions.
+ This procedure will update immediate value assigned to a Name
+ @param[in] AslSignature The signature of Operation Region that we want to update.
+ @param[in] Buffer source of data to be written over original aml
+ @param[in] Length length of data to be overwritten
@retval EFI_SUCCESS The function completed successfully.
+ @retval EFI_NOT_FOUND Failed to locate AcpiTable.
+ @retval EFI_NOT_READY Not ready to locate AcpiTable.
+ @retval EFI_UNSUPPORTED The function is not supported in this library.
**/
EFI_STATUS
-InitializeAslUpdateLib (
- VOID
+EFIAPI
+UpdateNameAslCode(
+ IN UINT32 AslSignature,
+ IN VOID *Buffer,
+ IN UINTN Length
);
/**
- This procedure will update immediate value assigned to a Name
+ This procedure will update the name of ASL Method
- @param[in] AslSignature The signature of Operation Region that we want to update.
- @param[in] Buffer source of data to be written over original aml
- @param[in] Length length of data to be overwritten
+ @param[in] TableId - Pointer to an ASCII string containing the OEM Table ID from the ACPI table header
+ @param[in] TableIdSize - Length of the TableId to match. Table ID are 8 bytes long, this function
+ @param[in] AslSignature - The signature of Operation Region that we want to update.
+ @param[in] Buffer - source of data to be written over original aml
+ @param[in] Length - length of data to be overwritten
- @retval EFI_SUCCESS The function completed successfully.
+ @retval EFI_SUCCESS - The function completed successfully.
+ @retval EFI_NOT_FOUND - Failed to locate AcpiTable.
+ @retval EFI_NOT_READY - Not ready to locate AcpiTable.
+ @retval EFI_UNSUPPORTED - The function is not supported in this library.
**/
EFI_STATUS
-UpdateNameAslCode(
+EFIAPI
+UpdateSsdtNameAslCode (
+ IN UINT8 *TableId,
+ IN UINT8 TableIdSize,
IN UINT32 AslSignature,
IN VOID *Buffer,
IN UINTN Length
@@ -85,8 +74,11 @@ UpdateNameAslCode(
@retval EFI_SUCCESS - The function completed successfully.
@retval EFI_NOT_FOUND - Failed to locate AcpiTable.
+ @retval EFI_NOT_READY - Not ready to locate AcpiTable.
+ @retval EFI_UNSUPPORTED - The function is not supported in this library.
**/
EFI_STATUS
+EFIAPI
UpdateMethodAslCode (
IN UINT32 AslSignature,
IN VOID *Buffer,
@@ -103,55 +95,19 @@ UpdateMethodAslCode (
@param[in] Signature Pointer to an ASCII string containing the Signature to match
@param[in, out] Table Updated with a pointer to the table
@param[in, out] Handle AcpiSupport protocol table handle for the table found
- @param[in, out] Version On input, the version of the table desired,
- on output, the versions the table belongs to
@see AcpiSupport protocol for details
@retval EFI_SUCCESS The function completed successfully.
+ @retval EFI_NOT_FOUND Failed to locate AcpiTable.
+ @retval EFI_NOT_READY Not ready to locate AcpiTable.
+ @retval EFI_UNSUPPORTED The function is not supported in this library.
**/
EFI_STATUS
+EFIAPI
LocateAcpiTableBySignature (
IN UINT32 Signature,
IN OUT EFI_ACPI_DESCRIPTION_HEADER **Table,
IN OUT UINTN *Handle
);
-/**
- This function uses the ACPI support protocol to locate an ACPI SSDT table.
- The table is located by searching for a matching OEM Table ID field.
- Partial match searches are supported via the TableIdSize parameter.
-
- @param[in] TableId Pointer to an ASCII string containing the OEM Table ID from the ACPI table header
- @param[in] TableIdSize Length of the TableId to match. Table ID are 8 bytes long, this function
- will consider it a match if the first TableIdSize bytes match
- @param[in, out] Table Updated with a pointer to the table
- @param[in, out] Handle AcpiSupport protocol table handle for the table found
- @param[in, out] Version See AcpiSupport protocol, GetAcpiTable function for use
-
- @retval EFI_SUCCESS The function completed successfully.
-**/
-EFI_STATUS
-LocateAcpiTableByOemTableId (
- IN UINT8 *TableId,
- IN UINT8 TableIdSize,
- IN OUT EFI_ACPI_DESCRIPTION_HEADER **Table,
- IN OUT UINTN *Handle
- );
-
-/**
- This function calculates and updates an UINT8 checksum.
-
- @param[in] Buffer Pointer to buffer to checksum
- @param[in] Size Number of bytes to checksum
- @param[in] ChecksumOffset Offset to place the checksum result in
-
- @retval EFI_SUCCESS The function completed successfully.
-**/
-EFI_STATUS
-AcpiChecksum (
- IN VOID *Buffer,
- IN UINTN Size,
- IN UINTN ChecksumOffset
- );
-
#endif
--
2.16.2.windows.1
next prev parent reply other threads:[~2020-04-29 2:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 2:31 [edk2-platforms:PATCH v4 0/7] IntelSiliconPkg DxeAslUpdateLib support Miki Shindo
2020-04-29 2:31 ` [edk2-platforms:PATCH v4 1/7] WhiskeylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Miki Shindo
2020-04-30 1:40 ` Chaganty, Rangasai V
2020-04-30 2:54 ` Chiu, Chasel
2020-04-29 2:31 ` [edk2-platforms:PATCH v4 2/7] KabylakeOpenBoardPkg/TbtDxe: " Miki Shindo
2020-04-30 1:47 ` Chaganty, Rangasai V
2020-04-30 2:55 ` Chiu, Chasel
2020-04-29 2:31 ` [edk2-platforms:PATCH v4 3/7] CometlakeOpenBoardPkg/TbtDxe: " Miki Shindo
2020-04-30 1:53 ` Chaganty, Rangasai V
2020-04-30 2:55 ` Chiu, Chasel
2020-04-29 2:32 ` [edk2-platforms:PATCH v4 4/7] MinPlatformPkg/DxeAslUpdateLib: Cleans up APIs Miki Shindo
2020-04-30 2:56 ` Chiu, Chasel
2020-04-30 5:00 ` Chaganty, Rangasai V
2020-04-29 2:32 ` [edk2-platforms:PATCH v4 5/7] KabylakeSiliconPkg/DxeAslUpdateLib: " Miki Shindo
2020-04-30 2:56 ` Chiu, Chasel
2020-04-30 5:02 ` Chaganty, Rangasai V
2020-04-29 2:32 ` Miki Shindo [this message]
2020-04-30 2:57 ` [edk2-platforms:PATCH v4 6/7] CoffeelakeSiliconPkg/DxeAslUpdateLib: " Chiu, Chasel
2020-04-30 5:03 ` Chaganty, Rangasai V
2020-04-29 2:32 ` [edk2-platforms:PATCH v4 7/7] IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support Miki Shindo
2020-04-30 2:57 ` Chiu, Chasel
2020-04-30 5:13 ` Chaganty, Rangasai V
2020-04-30 8:14 ` [edk2-platforms:PATCH v4 0/7] IntelSiliconPkg " Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429023203.37544-7-miki.shindo@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox