From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.groups.io with SMTP id smtpd.web10.1782.1588158982743986110 for ; Wed, 29 Apr 2020 04:16:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=wZBfh0f0; spf=pass (domain: nuviainc.com, ip: 209.85.128.48, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f48.google.com with SMTP id v8so4664945wma.0 for ; Wed, 29 Apr 2020 04:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NRsyCpzxKhlcrOsY4qwhk4Ms16OohlexGEkx1e/cSvk=; b=wZBfh0f0LbAfN4Xav64K3mTBn3sCyNuZ7IMBdlqmBDlEu6Hj7OgdKJ9B1k3ItXO2aI DSZ8l28SEZFV2+1tb9WXOA/8JzjCQc6z0L58Zz8Ci6zyMdezXwJf2QRsW08sx75S6kXl gE8G8tjpqi6uzlud2DqoNibs7cIZn+6YwQxRSapulNyAcD7GapeOukDaLXUwlmW+90dD ZEAMWjxymN2gIBjqJ9Tj7b9BzQaw/eMCQHuCn7M6daGmw/pAGwqLaoDa0BTPtl+67C3D pUmevJPQDCYGuMXGfec8AN0F5kD6t8RdOQDpxoqY+9waLknq8QWc954d/3aqqU10/Mv8 n4FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NRsyCpzxKhlcrOsY4qwhk4Ms16OohlexGEkx1e/cSvk=; b=nnL8ysRUUoKoXlSB0ybVyvD6nsq2l4LpncNuX+WcQnwC/o1v0QeVC3fiB/sY6d+XxE 72WJYL7x/+rFRWlWy5RuxYIJP8AhPOsLKMTZroTGo+4CfbF4IqzmvS5jzh/DkuWG92rK susAWgFQRdMJhh3cHdZASAVqSibeMCi7IyTTwIOnW7I7tXab02nnm6kvscOq3bJ/MOHT 50wHQQmtAF1E3je42bR7aIevYuzDzsnk5J/UMD27gSkfKCq3Go+Gx15F4kiWU6EjU1kj lkLQP10n8shsd4Ow4vPQfxmRG35EV3BsrWozV/mPchRIIffnKHGJkuVv+XcvPgZq+Mnn rU1A== X-Gm-Message-State: AGi0PuZHiEgtE6bKILDgiL9/KWz3S3cgmssTy3KEl/GVPq7eEQhkNXG/ qxW57pISXG/8anLMKu0OKmw2Jw== X-Google-Smtp-Source: APiQypKnDZJOKl4b22gzjdcNxJ3BAkgQyvxJ6tP88+iFAWm4gVzSsweMlcs6O1NicJMIlLYqkXTh9A== X-Received: by 2002:a05:600c:2:: with SMTP id g2mr2789212wmc.85.1588158981225; Wed, 29 Apr 2020 04:16:21 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id 17sm7155065wmo.2.2020.04.29.04.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 04:16:20 -0700 (PDT) Date: Wed, 29 Apr 2020 12:16:18 +0100 From: "Leif Lindholm" To: "Loh, Tien Hock" Cc: Pankaj Bansal , Ard Biesheuvel , Gaurav Jain , Meenakshi Aggarwal , "devel@edk2.groups.io" , Haojian Zhuang , Varun Sethi Subject: Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer Limit 65535 in R/W. Message-ID: <20200429111618.GF21486@vanye> References: <1585905847-16380-1-git-send-email-gaurav.jain@nxp.com> <20200406140819.GI14075@vanye> <3d55018b-8751-bbe1-b1ac-98ac36e16e1c@arm.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Tien Hock, Can I take that as a Reviewed-by:? Regards, Leif On Wed, Apr 29, 2020 at 05:17:18 +0000, Loh, Tien Hock wrote: > Hi Ard, > > I have checked the patch and it looks good. > > However, I can no longer test the patch as the new DwMmc driver no longer uses the protocol. > Sorry for the delay, I initially thought I can test it until I investigated further today. > > Thanks > > > > -----Original Message----- > > From: Pankaj Bansal > > Sent: Monday, April 27, 2020 2:19 PM > > To: Ard Biesheuvel ; Leif Lindholm > > ; Gaurav Jain ; Meenakshi > > Aggarwal > > Cc: devel@edk2.groups.io; Haojian Zhuang ; Loh, > > Tien Hock ; Varun Sethi > > Subject: RE: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer > > Limit 65535 in R/W. > > > > + Meenakshi > > > > > -----Original Message----- > > > From: Ard Biesheuvel > > > Sent: Monday, April 6, 2020 7:42 PM > > > To: Leif Lindholm ; Gaurav Jain > > > > > > Cc: devel@edk2.groups.io; Pankaj Bansal ; > > > Haojian Zhuang ; Loh, Tien Hock > > > > > > Subject: Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer > > > Limit 65535 in R/W. > > > > > > On 4/6/20 4:08 PM, Leif Lindholm wrote: > > > > Hi Gaurav, > > > > > > > > Haojian, Tien Hock - can you help review/test this change? > > > > > > > > Best Regards, > > > > > > > > Leif > > > > > > > > On Fri, Apr 03, 2020 at 14:54:07 +0530, Gaurav Jain wrote: > > > >> Moved BlockCount calculation below BufferSize Validation checks. > > > >> First Ensure Buffersize is Not Zero and multiple of Media BlockSize. > > > >> then calculate BlockCount and perform Block checks. > > > >> > > > >> Corrected BlockCount calculation, as BufferSize is multiple of > > > >> BlockSize, So adding (BlockSize-1) bytes to BufferSize and then > > > >> divide by BlockSize will have no impact on BlockCount. > > > >> > > > >> Reading Large Images from MMC causes errors. > > > >> As per SD Host Controller Spec version 4.20, Restriction of 16-bit > > > >> Block Count transfer is 65535. > > > >> Max block transfer limit in single cmd is 65535 blocks. > > > >> Added Max Block check that can be processed is 0xFFFF. > > > >> then Update BlockCount on the basis of MaxBlock. > > > >> > > > >> Signed-off-by: Gaurav Jain > > > > > > > > > Hello Gaurav, > > > > > > Could you please elaborate on the underlying need for this change? If > > > you are considering using this driver for future NXP platforms, I > > > should point out that this legacy driver is only kept around for > > > existing users, and new users should use the driver stack in > > > MdeModulePkg, which is based on the UEFI spec. > > > > > > -- > > > Ard. > > > > > > > > > >