public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: devel@edk2.groups.io
Cc: Bob Feng <bob.c.feng@intel.com>, Liming Gao <liming.gao@intel.com>
Subject: [PATCH 1/3] BaseTools: add handling for 'S:' flag to GetMaintainer.py
Date: Wed, 29 Apr 2020 17:36:14 +0100	[thread overview]
Message-ID: <20200429163616.5951-2-leif@nuviainc.com> (raw)
In-Reply-To: <20200429163616.5951-1-leif@nuviainc.com>

GetMaintainer.py already extracts the value of any S: tags for sections,
but it doesn't do anything with that information.

Print a warning message, with the status, for each matching section with
a status explicitly set to anything other than 'Supported' or
'Maintained'.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
---
 BaseTools/Scripts/GetMaintainer.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/BaseTools/Scripts/GetMaintainer.py b/BaseTools/Scripts/GetMaintainer.py
index fbc63522db77..2ec550e86d36 100644
--- a/BaseTools/Scripts/GetMaintainer.py
+++ b/BaseTools/Scripts/GetMaintainer.py
@@ -77,8 +77,12 @@ def get_section_maintainers(path, section):
        matching the provided path in the provided section."""
     maintainers = []
     lists = []
+    nowarn_status = ['Supported', 'Maintained']
 
     if path_in_section(path, section):
+        for status in section['status']:
+            if status not in nowarn_status:
+                print('WARNING: Maintained status for "%s" is \'%s\'!' % (path, status))
         for address in section['maintainer'], section['reviewer']:
             # Convert to list if necessary
             if isinstance(address, list):
-- 
2.20.1


  reply	other threads:[~2020-04-29 16:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 16:36 [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers Leif Lindholm
2020-04-29 16:36 ` Leif Lindholm [this message]
2020-04-30  7:00   ` [PATCH 1/3] BaseTools: add handling for 'S:' flag to GetMaintainer.py Bob Feng
2020-04-29 16:36 ` [PATCH 2/3] Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete Leif Lindholm
2020-04-29 20:12   ` [edk2-devel] " Laszlo Ersek
2020-04-29 16:36 ` [PATCH 3/3] Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete Leif Lindholm
2020-04-29 20:14   ` [edk2-devel] " Laszlo Ersek
2020-04-29 17:51 ` [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers Ard Biesheuvel
2020-04-29 19:53   ` Leif Lindholm
2020-04-29 20:04     ` Ard Biesheuvel
2020-04-29 21:45       ` Leif Lindholm
2020-04-29 21:47         ` Ard Biesheuvel
2020-04-30 11:17           ` Laszlo Ersek
2020-04-30 13:28             ` Leif Lindholm
2020-04-30 13:43               ` Ard Biesheuvel
2020-04-30 14:59                 ` Leif Lindholm
2020-04-29 20:14 ` [edk2-devel] " Andrei Warkentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429163616.5951-2-leif@nuviainc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox