public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>,
	Laszlo Ersek <lersek@redhat.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: [PATCH 3/3] Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete
Date: Wed, 29 Apr 2020 17:36:16 +0100	[thread overview]
Message-ID: <20200429163616.5951-4-leif@nuviainc.com> (raw)
In-Reply-To: <20200429163616.5951-1-leif@nuviainc.com>

A bunch of legacy drivers (most not compliant with UEFI driver model)
added for various ARM development platforms are still in EmbeddedPkg,
which was arguably the only possible location for them before
edk2-platforms was added.

DwEmmcDxe, Isp1761UsbDxe, Lan9118Dxe, and Lan91xDxe all use a
Pcd*BaseAddress mechanism making them *fundamentally* incompatible
with the UEFI driver model, and preventing use of more than one device
instance per system.

SataSiI3132Dxe *looks* like a proper UEFI driver, but would need
re-review with that in mind for moving to edk2-platforms.

Mark these as Status: Obsolete in Maintainers.txt to at the very least
indicate that they are not suitable references.

Cc: Andrew Fish <afish@apple.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
---
 Maintainers.txt | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 4d62e0b334f3..3415a0410b7b 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -172,6 +172,11 @@ M: Alexei Fedorov <Alexei.Fedorov@arm.com>
 
 EmbeddedPkg
 F: EmbeddedPkg/
+X: EmbeddedPkg/Drivers/DwEmmcDxe/
+X: EmbeddedPkg/Drivers/Isp1761UsbDxe/
+X: EmbeddedPkg/Drivers/Lan9118Dxe/
+X: EmbeddedPkg/Drivers/Lan91xDxe/
+X: EmbeddedPkg/Drivers/SataSiI3132Dxe/
 X: EmbeddedPkg/Include/Protocol/MmcHost.h
 X: EmbeddedPkg/Universal/MmcDxe/
 W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg
@@ -179,6 +184,11 @@ M: Leif Lindholm <leif@nuviainc.com>
 M: Ard Biesheuvel <ard.biesheuvel@arm.com>
 
 EmbeddedPkg obsolete code
+F: EmbeddedPkg/Drivers/DwEmmcDxe/
+F: EmbeddedPkg/Drivers/Isp1761UsbDxe/
+F: EmbeddedPkg/Drivers/Lan9118Dxe/
+F: EmbeddedPkg/Drivers/Lan91xDxe/
+F: EmbeddedPkg/Drivers/SataSiI3132Dxe/
 F: EmbeddedPkg/Include/Protocol/MmcHost.h
 F: EmbeddedPkg/Universal/MmcDxe/
 S: Obsolete
-- 
2.20.1


  parent reply	other threads:[~2020-04-29 16:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 16:36 [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers Leif Lindholm
2020-04-29 16:36 ` [PATCH 1/3] BaseTools: add handling for 'S:' flag to GetMaintainer.py Leif Lindholm
2020-04-30  7:00   ` Bob Feng
2020-04-29 16:36 ` [PATCH 2/3] Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete Leif Lindholm
2020-04-29 20:12   ` [edk2-devel] " Laszlo Ersek
2020-04-29 16:36 ` Leif Lindholm [this message]
2020-04-29 20:14   ` [edk2-devel] [PATCH 3/3] Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete Laszlo Ersek
2020-04-29 17:51 ` [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers Ard Biesheuvel
2020-04-29 19:53   ` Leif Lindholm
2020-04-29 20:04     ` Ard Biesheuvel
2020-04-29 21:45       ` Leif Lindholm
2020-04-29 21:47         ` Ard Biesheuvel
2020-04-30 11:17           ` Laszlo Ersek
2020-04-30 13:28             ` Leif Lindholm
2020-04-30 13:43               ` Ard Biesheuvel
2020-04-30 14:59                 ` Leif Lindholm
2020-04-29 20:14 ` [edk2-devel] " Andrei Warkentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429163616.5951-4-leif@nuviainc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox