From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web11.1178.1588190027428795813 for ; Wed, 29 Apr 2020 12:53:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=eJ+kDmIR; spf=pass (domain: nuviainc.com, ip: 209.85.128.68, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f68.google.com with SMTP id v4so5750607wme.1 for ; Wed, 29 Apr 2020 12:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ps/vAaGBAN9zqsI9XPZK1BAsj/Umgb79OrIRVAtB9lc=; b=eJ+kDmIRCMt42LNrXS7c2EIcxyRtsM9m5M9uKfqX6LzV5hOHV7RnsWqjPT0nwAVFFJ Mbjo2bwT0/ZdxYasDdE71jW/CJ0/esX3l6aDyVS1+K546gzBrv0TdckyL7KjQvWfjjPU xBUQvs5nygGvo+sDHN5N/Yyv/bQHa+RT0Sul2mMeKERvtfXFVYu4ETFjHO86CURrkTTg eBTmxljmFq4qKpoVdusUyxycurZtifjiVxNHzR5w+oqmwBHY7qWxLeBA8mqTAaBld5ME undeYGQ+njSF18hv6cVd8woNNsHddeUTgZv8GDXTUv9JoDg3nkLGv+7W38wVpdAyBsXS VdNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ps/vAaGBAN9zqsI9XPZK1BAsj/Umgb79OrIRVAtB9lc=; b=n1yyCMN167wh26aR9Cmia6zknvblAqdovk2xVLk9i++V2K/LcyRiBfnaabK46Lbz/b V0Vvbb+bTHT6u/XoMYFUMZZTrRlfoPgT3pGcv3dypBeTLl8Ac15E4/rhcPOpjfEQL1xZ c+JDDmHL9QlLtG2UI/bg2rkkwDmtFwg9ycDQUFZoU2+48OZ0rKpbMMLQXbYvFRWoOMyd EX7VqBqLKKMQ1cnUnpR56oSCGIAAZhxg6ZndghMTVKJf1dsLDU3uBwZa2uvqkgyDO5Ku D/WhN0gM8IhyPS+WmR+MI5gTMUFDIKMywQq6To7AV6OSK94++6QzL6+YszgTg2jmM07F jftg== X-Gm-Message-State: AGi0PuZkb7TYPKouVjjH8tVcoWugz5ftpkgqM5ZUzOA1dalcJw+4hxFx NJgDt2VtIggiZkvBzmrcm3cpcg== X-Google-Smtp-Source: APiQypIefcmCE1pc4be3PR2E3NwRhtgHFqs+WFqypGiXkwAGprPUA6kYxg6jGqfS52buSRZm3b8fZQ== X-Received: by 2002:a1c:4d18:: with SMTP id o24mr4765394wmh.141.1588190025993; Wed, 29 Apr 2020 12:53:45 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id q10sm374366wrv.95.2020.04.29.12.53.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 12:53:45 -0700 (PDT) Date: Wed, 29 Apr 2020 20:53:43 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Andrew Fish , Bob Feng , Laszlo Ersek , Liming Gao , Michael D Kinney Subject: Re: [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers Message-ID: <20200429195343.GI21486@vanye> References: <20200429163616.5951-1-leif@nuviainc.com> <10151f16-f903-6fcf-92c8-f28f269eab53@arm.com> MIME-Version: 1.0 In-Reply-To: <10151f16-f903-6fcf-92c8-f28f269eab53@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 29, 2020 at 19:51:12 +0200, Ard Biesheuvel wrote: > On 4/29/20 6:36 PM, Leif Lindholm wrote: > > We keep seeing new users (and copies) of EmbeddedPkg:s MmcDxe, which > > while it predates the MdeModulePkg SD/(E)MMCsupport is in effect > > unmaintained and also duplicates core industry standard definitions. > > > > Since we now have GetMaintainers.py to parse Maintainers.txt for us, > > extend its functionality to warn about less supported code. > > > > Then as an indication of its unsuitability for reference (or use), set > > its Status flag in Maintainers.txt to Obsolete. > > > > Once this is done, follow up and do the same with the hardware drivers > > (not the software ones) still left in EmbeddedPkg/Drivers. They were > > added back when not using the UEFI driver model was still cool, or > > simply before edk2-platforms existed. > > They should move to edk2-platforms, but most of them require some > > level of rewriting before that. > > > > 1/3 adds a warning printout to GetMaintainer.py > > > > 2/3 obsoletes EmbeddedPkg/Universal/MmcDxe/ > > > > 3/3 obsoletes remaining hw drivers in EmbeddedPkg/Drivers > > Cc: Andrew Fish > > > > Cc: Ard Biesheuvel > > Cc: Bob Feng > > Cc: Laszlo Ersek > > Cc: Liming Gao > > Cc: Michael D Kinney > > > > Leif Lindholm (3): > > BaseTools: add handling for 'S:' flag to GetMaintainer.py > > Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete > > Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete > > > > Acked-by: Ard Biesheuvel > > I am mostly concerned about the use of MmcDxe in new platforms. The other > bits I'm not too worried about, and I think it would be fine to move those > into Platform/ARM/VExpressPkg in edk2-platforms, instead of hoping that > someone will turn up and turn them into driver model drivers. We could, although I would prefer not adding code to edk2-platforms that would not be accepted was it submitted as a new contribution. The SATA controller, I would ideally re-review and merge properly. If we do include the other drivers in platform-specific directories, I want them to come with ... strongly worded readmes. > One thing I'd like to do in the short term is renaming > gEfiMmcHostProtocolGuid, given that it violates the naming rules, and move > the PL180 driver to edk2-platforms. I did think about moving PL180 as well. I'm not opposed to moving it. I don't think it's widely used. > Any thoughts about DwEmmcDxe? Only HiKey uses that at the moment, > given that socfpga apparently switched to the generic version. Well, if nothing else it might be a useful scream test. Same comment on strongly worded readme. / Leif