Re: [PATCH] EmbeddedPkg: rename gEfiMmcHostProtocolGuid to gEdkiiMmcHostProtocolGuid

["Leif Lindholm" <leif@nuviainc.com>]

On Wed, Apr 29, 2020 at 23:27:52 +0200, Ard Biesheuvel wrote:
> On 4/29/20 10:06 PM, Leif Lindholm wrote:
> > On Wed, Apr 29, 2020 at 20:27:04 +0200, Ard Biesheuvel wrote:
> > > In EDK2, identifiers carrying the EFI prefix are reserved for ones
> > > that are defined in the UEFI or PI specifications. For protocols that
> > > are part of the internal EDK2 implementation, we use EDKII instead.
> > > 
> > > Since the MMC host protocol defined in EmbeddedPkg is not the one that
> > > the UEFI spec defines, and given the confusion around this, let's rename
> > > it to gEdkiiMmcHostProtocolGuid.
> > 
> > 1) Yes, please, let's change this.
> > 2) But not s/Efi/Edkii/ please.
> > 
> > We want to get rid of this thing - and the "replacement" in
> > MdeModulePkg has things called gEdkiiPeiSdMmcHostControllerPpiGuid and
> > gEdkiiSdMmcOverrideProtocolGuid, so I think this would still be
> > confusing.
> > 
> > Could we call it plain gEmbeddedPkgMmcHostProtocolGuid or
> > gEmbeddedMmcHostProtocolGuid instead?
> > 
> 
> The latter seems the most suitable to me.

Well, with that pure substitution across the board:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>