From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web12.920.1588196056636475299 for ; Wed, 29 Apr 2020 14:34:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=JV2JYmFF; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id h4so3671213wmb.4 for ; Wed, 29 Apr 2020 14:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ab+7YwljIg427d8zqu6slKUsSBAiGuWsURa0D7g3hlE=; b=JV2JYmFFPRvUq6q/WkjPR4wFdw/Igk8IhgnFVbQGZbexKHaYumiWGVBxp9HfbeYesx KdvBo9Xd7DIkgPqAZ3GvScLYLwt2C8mdwFY56siVKe+J6LieGMImqlqTdlWtBm6I8Hhj Eaveut/uQzBgOmemXYRediHmZtfRq7kILA4IGP0yjFsGG7iP9cMm9IzeDdOBzIJ5qQ4z Sb/ikCmRwLVuJAin055cimknk661eZcxkdqBWxL7bbHFy1N51uBiYu/eXgyQBFiOR39a A43xaJVVWwHInHzgmFfxRolf6VuY2fIy2psjJ0kemIG15CDsQPLWol+9eLYoXOPyVmZ3 1P2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ab+7YwljIg427d8zqu6slKUsSBAiGuWsURa0D7g3hlE=; b=OMqOKNaMXaecUYQaD7rJo3shRUgLNMWs5piN39KgWpgdNHtg3Hoiwkjncj4DTEi9zK y7sfpf8ibv9UnT/uGNBrvpkp1T4VLsCQmzAfujLJi8oQ6isH3HfXyo8mnZSoVW1V/SeF vcsZ/PLhtczhxPGEETvryRJpSHzyqUiSD0SPh+8jXqmu8Dqxuh2MJSOYwG5ac0d9tyIo 7shH4kreYIhNlbVXr19RfiKrhG8eND4VxI5n7v4KcYSMqI1lofjAoCiz7d6ovh2YJXRf GCMY7bXlQmIyNxxE3sGqUi0nhyhpw3OQHHT0zELM9WYGKJtci84ZlhfOTJtwW+bkNVlq 8Pew== X-Gm-Message-State: AGi0PuaBC9BE8+ZlVYVE52wTYNqaTt39oaG3XGsCds90yKLDK7eMWoie 06vEsC8cjoROjjaL4Oi255xS5w== X-Google-Smtp-Source: APiQypLzz4E3HHqjJpspzPsHJL2+e5tIFutP0BzwuxNM6ji7XmX2COqCetS8enehdKtjPsdSroW3Ug== X-Received: by 2002:a1c:4304:: with SMTP id q4mr5790814wma.152.1588196055276; Wed, 29 Apr 2020 14:34:15 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id n9sm800873wrx.61.2020.04.29.14.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 14:34:14 -0700 (PDT) Date: Wed, 29 Apr 2020 22:34:12 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH] EmbeddedPkg: rename gEfiMmcHostProtocolGuid to gEdkiiMmcHostProtocolGuid Message-ID: <20200429213412.GL21486@vanye> References: <20200429182704.8715-1-ard.biesheuvel@arm.com> <20200429200648.GJ21486@vanye> <7cc63e8e-ea01-af04-ba46-ccfb3492d7e8@arm.com> MIME-Version: 1.0 In-Reply-To: <7cc63e8e-ea01-af04-ba46-ccfb3492d7e8@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 29, 2020 at 23:27:52 +0200, Ard Biesheuvel wrote: > On 4/29/20 10:06 PM, Leif Lindholm wrote: > > On Wed, Apr 29, 2020 at 20:27:04 +0200, Ard Biesheuvel wrote: > > > In EDK2, identifiers carrying the EFI prefix are reserved for ones > > > that are defined in the UEFI or PI specifications. For protocols that > > > are part of the internal EDK2 implementation, we use EDKII instead. > > > > > > Since the MMC host protocol defined in EmbeddedPkg is not the one that > > > the UEFI spec defines, and given the confusion around this, let's rename > > > it to gEdkiiMmcHostProtocolGuid. > > > > 1) Yes, please, let's change this. > > 2) But not s/Efi/Edkii/ please. > > > > We want to get rid of this thing - and the "replacement" in > > MdeModulePkg has things called gEdkiiPeiSdMmcHostControllerPpiGuid and > > gEdkiiSdMmcOverrideProtocolGuid, so I think this would still be > > confusing. > > > > Could we call it plain gEmbeddedPkgMmcHostProtocolGuid or > > gEmbeddedMmcHostProtocolGuid instead? > > > > The latter seems the most suitable to me. Well, with that pure substitution across the board: Reviewed-by: Leif Lindholm