public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: devel@edk2.groups.io
Subject: Re: [PATCH edk2-platforms 1/2] Silicon/TexasInstruments/Omap35xxPkg: switch to new MMC host protocol name
Date: Wed, 29 Apr 2020 22:37:04 +0100	[thread overview]
Message-ID: <20200429213704.GM21486@vanye> (raw)
In-Reply-To: <20200429184705.20934-1-ard.biesheuvel@arm.com>

On Wed, Apr 29, 2020 at 20:47:04 +0200, Ard Biesheuvel wrote:
> The protocol name for EmbeddedPkg's version of the MMC host protocol was
> changed to reflect that this protocol is not the one that the UEFI spec
> defines. So update OMAP3's MMC host DXE driver accordingly.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

With the corresponding name change as the edk2 patch:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.c   | 2 +-
>  Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.c b/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.c
> index 410fed9366a8..413392908914 100644
> --- a/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.c
> +++ b/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.c
> @@ -662,7 +662,7 @@ MMCInitialize (
>  
>    Status = gBS->InstallMultipleProtocolInterfaces (
>                    &Handle,
> -                  &gEfiMmcHostProtocolGuid,         &gMMCHost,
> +                  &gEdkiiMmcHostProtocolGuid,       &gMMCHost,
>                    NULL
>                    );
>    ASSERT_EFI_ERROR (Status);
> diff --git a/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf b/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf
> index 28e78ee646cd..c05d0d1cd913 100644
> --- a/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf
> +++ b/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf
> @@ -37,7 +37,7 @@ [Protocols]
>    gEfiCpuArchProtocolGuid
>    gEfiDevicePathProtocolGuid
>    gEmbeddedExternalDeviceProtocolGuid
> -  gEfiMmcHostProtocolGuid
> +  gEdkiiMmcHostProtocolGuid
>  
>  [Pcd]
>    gOmap35xxTokenSpaceGuid.PcdOmap35xxMMCHS1Base
> -- 
> 2.17.1
> 

  parent reply	other threads:[~2020-04-29 21:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 18:47 [PATCH edk2-platforms 1/2] Silicon/TexasInstruments/Omap35xxPkg: switch to new MMC host protocol name Ard Biesheuvel
2020-04-29 18:47 ` [PATCH edk2-platforms 2/2] Platform/ARM/VExpressPkg: incorporate PL180 driver Ard Biesheuvel
2020-04-29 21:51   ` Leif Lindholm
2020-04-29 21:37 ` Leif Lindholm [this message]
2020-04-30  8:13   ` [PATCH edk2-platforms 1/2] Silicon/TexasInstruments/Omap35xxPkg: switch to new MMC host protocol name Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429213704.GM21486@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox