From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web12.963.1588196228451993389 for ; Wed, 29 Apr 2020 14:37:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=JwSm6AZi; spf=pass (domain: nuviainc.com, ip: 209.85.221.66, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f66.google.com with SMTP id j1so4380837wrt.1 for ; Wed, 29 Apr 2020 14:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ETwp4DU2XG7urGWgPwTQE57vpv7LcGo/9EDIguNIdPE=; b=JwSm6AZiNbVLJL2MM/JaFM2cFcxEHdr36RIHrVYwmz1LrhegstRibxoU+UpKXDMqlG ZRictMmQxwAdgU87jP50vy+7NHjbey8RxbWKF0FXG9jaswgVOvWZW334O/3CT7k24+pW iYFIHqiXvSDO++kaiYc/Qu31d6KI9BARe553WQ/eEyCzFgB0hjR5R8Nf6w7ycyrAGFU7 TD0zefhJpIXpGuWlragW62HyMoQWBPquPeRZDW9fEjszB9heAX0ZJOGOvjxuDeznNotc 8UsW/stHTdqOcj7nqpMUuAAX83eNMizKZdvWkKhI4d/qn7gA4xO8aKz2xkCcuppuoqR0 n92w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ETwp4DU2XG7urGWgPwTQE57vpv7LcGo/9EDIguNIdPE=; b=dn1C51BLtR1U5JFRHSC7mt5lAHIahQfk9Sn8Am8T0AnuIxWRNMfJ3Up39IzbY6lkx6 V0+7wtBsJerJD2xcx2tDp6Y2ipsLwF60XaVt4RUV65BSGiZMN16hUTBDfou21z0oucMv aTi+XocWr5tjVydg5Sxzaa5RvXYwA9yf5EsN72AiTwaDK0WaJ9aLeLkllWpOoxtOLZyp W6l0wN1QlxgPOJ7iwY8Rj9lDoRGeGW37L9TfxbmH1KAFV93OjT7BCXowdLzXMjG5hmj7 5twTXCutt1oivn9rDuprbanA4L9zuD5jU3g27ugVeku22jL+a+RuxDYWCMCM0wCMkfNa BBqg== X-Gm-Message-State: AGi0PuZdEfRP+oaMEqORObgYzJuqjOBzH+XRIRmBeagmMpdJlwRJsYgL vKEXk+61TTclnWmttSKjPfsK1RhUpO4= X-Google-Smtp-Source: APiQypJZHifwjvCKGS7nBksVLzNVEbAhb2U5gqk60JivxV+VD7FovaJhRNoi5o/1qEOUvYCMlit48A== X-Received: by 2002:a5d:6145:: with SMTP id y5mr160612wrt.126.1588196226888; Wed, 29 Apr 2020 14:37:06 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id l16sm759458wrp.91.2020.04.29.14.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 14:37:06 -0700 (PDT) Date: Wed, 29 Apr 2020 22:37:04 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms 1/2] Silicon/TexasInstruments/Omap35xxPkg: switch to new MMC host protocol name Message-ID: <20200429213704.GM21486@vanye> References: <20200429184705.20934-1-ard.biesheuvel@arm.com> MIME-Version: 1.0 In-Reply-To: <20200429184705.20934-1-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 29, 2020 at 20:47:04 +0200, Ard Biesheuvel wrote: > The protocol name for EmbeddedPkg's version of the MMC host protocol was > changed to reflect that this protocol is not the one that the UEFI spec > defines. So update OMAP3's MMC host DXE driver accordingly. > > Signed-off-by: Ard Biesheuvel With the corresponding name change as the edk2 patch: Reviewed-by: Leif Lindholm > --- > Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.c | 2 +- > Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.c b/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.c > index 410fed9366a8..413392908914 100644 > --- a/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.c > +++ b/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.c > @@ -662,7 +662,7 @@ MMCInitialize ( > > Status = gBS->InstallMultipleProtocolInterfaces ( > &Handle, > - &gEfiMmcHostProtocolGuid, &gMMCHost, > + &gEdkiiMmcHostProtocolGuid, &gMMCHost, > NULL > ); > ASSERT_EFI_ERROR (Status); > diff --git a/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf b/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf > index 28e78ee646cd..c05d0d1cd913 100644 > --- a/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf > +++ b/Silicon/TexasInstruments/Omap35xxPkg/MmcHostDxe/MmcHostDxe.inf > @@ -37,7 +37,7 @@ [Protocols] > gEfiCpuArchProtocolGuid > gEfiDevicePathProtocolGuid > gEmbeddedExternalDeviceProtocolGuid > - gEfiMmcHostProtocolGuid > + gEdkiiMmcHostProtocolGuid > > [Pcd] > gOmap35xxTokenSpaceGuid.PcdOmap35xxMMCHS1Base > -- > 2.17.1 >