From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web11.1132.1588196735061705879 for ; Wed, 29 Apr 2020 14:45:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=Eie45meG; spf=pass (domain: nuviainc.com, ip: 209.85.221.68, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f68.google.com with SMTP id g13so4348364wrb.8 for ; Wed, 29 Apr 2020 14:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tVx1LNFVDlPaLGCPRc733CaM44/PGUJOvsu2EEiowqw=; b=Eie45meGj+sRnc3taEm//opLeGBwDSj2/qonsaRwSSngf1Q2FcFhW36ra+5ezZ4PT7 f7sU7gh9MAl66DaoUQD5CQq7vMfVX29yOiKEnDvfNzIWIi+hZ1o59eofUdfuA9h6S0ID D4Wb9GJQXEr6JhNJHT223CZHvStf/W+oKsK8e1Ur3qC3Xgho5aLY3gNAePJzfcN5pRLT QBI7yYrkWaNj3KsL24hm17YVPHdNtQa9TCm0Znl9hh+QheVID5ZP4saNPeifHl8G7Of7 yLOlq9Oz3xyeeoZtBxBRsPJLVn79/dwgIpk4JfFzRybvhuX/mmErDzA/lVRtzR2KqetV TvaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tVx1LNFVDlPaLGCPRc733CaM44/PGUJOvsu2EEiowqw=; b=Z8Y6/hUQg8B+0elOFdf+uMNFPQVXCDT3z5InwriV8Iv/exsiG/eLcZd2Cvoz4rj9M5 SGtZAhg2Pej7lsJIF0qgOfnDbCGw/37Y8JY+TVcnxzrmhTyQVDqBzmff6iMZ7K/+qpK7 pCALDlGbP3/RLqGCNj3Um6lkOsew4sXbbSiiLDypgGKrfBXujgu2kSNl/JwdkXH3FpbS aekcgtFagVFIGtx/f/i4OsY2tDtvrGOmmaxD30oyKDojWzKaNQUrdlbmkYsl4TJvkK8B k+7YVAfFM3wcXOOLvVGnY2NH/Gc28ApOX/++ePbAyv7SxMLpnJbX7HjzerbZyfsYYv9l rNeA== X-Gm-Message-State: AGi0PuZb/dV7nK9Dc25+TTkR+b6TtYF7nFJXb92vh3VglOSlDl7vT5Pd 3xhtC2gsIhErO4sLxU1ToF5pUA== X-Google-Smtp-Source: APiQypJ1RWXSGRzYRq+e63IcR1mdDm9NNDArqLkO4wrgW2w80p3n48IJ5vGwKHQyFH20iNPXws29sg== X-Received: by 2002:a5d:4109:: with SMTP id l9mr41574299wrp.300.1588196733628; Wed, 29 Apr 2020 14:45:33 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id q143sm10247021wme.31.2020.04.29.14.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 14:45:33 -0700 (PDT) Date: Wed, 29 Apr 2020 22:45:31 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Andrew Fish , Bob Feng , Laszlo Ersek , Liming Gao , Michael D Kinney Subject: Re: [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers Message-ID: <20200429214531.GN21486@vanye> References: <20200429163616.5951-1-leif@nuviainc.com> <10151f16-f903-6fcf-92c8-f28f269eab53@arm.com> <20200429195343.GI21486@vanye> <464be692-53ef-8cac-ec69-2f87cc6f59cb@arm.com> MIME-Version: 1.0 In-Reply-To: <464be692-53ef-8cac-ec69-2f87cc6f59cb@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 29, 2020 at 22:04:08 +0200, Ard Biesheuvel wrote: > > > I am mostly concerned about the use of MmcDxe in new platforms. The other > > > bits I'm not too worried about, and I think it would be fine to move those > > > into Platform/ARM/VExpressPkg in edk2-platforms, instead of hoping that > > > someone will turn up and turn them into driver model drivers. > > > > We could, although I would prefer not adding code to edk2-platforms > > that would not be accepted was it submitted as a new contribution. > > The SATA controller, I would ideally re-review and merge properly. > > > > If we do include the other drivers in platform-specific directories, I > > want them to come with ... strongly worded readmes. > > > > Right. > > Should we have some format for that? A way to log shortcomings along with > the code? Thinking a bit more on this, maybe what we should do is add a template to each file's top comment block. Draft proposal: * * WARNING: * This driver fails to follow the UEFI driver model without a good * reason, and only remains in the tree because it is still used by * a small number of platforms. It will removed when no longer used. * New platforms should not use it, and no one should use this as * reference code for developing new drivers. * / Leif > > > One thing I'd like to do in the short term is renaming > > > gEfiMmcHostProtocolGuid, given that it violates the naming rules, and move > > > the PL180 driver to edk2-platforms. > > > > I did think about moving PL180 as well. I'm not opposed to moving > > it. I don't think it's widely used. > > > > > Any thoughts about DwEmmcDxe? Only HiKey uses that at the moment, > > > given that socfpga apparently switched to the generic version. > > > > Well, if nothing else it might be a useful scream test. Same comment > > on strongly worded readme. > > > > OK