public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Andrei Warkentin" <andrey.warkentin@gmail.com>
To: devel@edk2.groups.io
Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, pete@akeo.ie,
	philmd@redhat.com
Subject: [edk2-platforms][PATCH 2/4] RPi: fix MmcTransferBlock (writes) regression for eMMC
Date: Thu, 30 Apr 2020 02:26:50 -0700	[thread overview]
Message-ID: <20200430092652.54526-3-andrey.warkentin@gmail.com> (raw)
In-Reply-To: <20200430092652.54526-1-andrey.warkentin@gmail.com>

Way back when I added write block validation (https://github.com/andreiw/RaspberryPiPkg/commit/bdea35dc3f1652bf7b17505a20a5f52f7fde9707),
I had screwed the logic up breaking eMMC.

This starts to matter on the CM3, which has eMMC.

Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
---
 Platform/RaspberryPi/Drivers/MmcDxe/MmcBlockIo.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/RaspberryPi/Drivers/MmcDxe/MmcBlockIo.c b/Platform/RaspberryPi/Drivers/MmcDxe/MmcBlockIo.c
index 29a9fd7d..8a2f7f42 100644
--- a/Platform/RaspberryPi/Drivers/MmcDxe/MmcBlockIo.c
+++ b/Platform/RaspberryPi/Drivers/MmcDxe/MmcBlockIo.c
@@ -47,6 +47,7 @@ ValidateWrittenBlockCount (
     /*
      * Not on MMC.
      */
+    *TransferredBlocks = Count;
     return EFI_SUCCESS;
   }
 
-- 
2.17.1


  parent reply	other threads:[~2020-04-30  9:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30  9:26 [edk2-platforms][PATCH 0/4] (v2) extend RPi3 to support 3A+, 2B (v1.2) and CM3 Andrei Warkentin
2020-04-30  9:26 ` [edk2-platforms][PATCH 1/4] RPi3: support Pi 2B v1.2 Andrei Warkentin
2020-04-30  9:26 ` Andrei Warkentin [this message]
2020-04-30  9:26 ` [edk2-platforms][PATCH 3/4] RPi: update HII strings in ConfigDxe to reflect eMMC support Andrei Warkentin
2020-04-30  9:26 ` [edk2-platforms][PATCH 4/4] RPi: document CM3, Pi 2B (v1.2) and Pi 3A+ support, update Pi 4 docs Andrei Warkentin
2020-04-30  9:34 ` [edk2-platforms][PATCH 0/4] (v2) extend RPi3 to support 3A+, 2B (v1.2) and CM3 Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200430092652.54526-3-andrey.warkentin@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox