From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by mx.groups.io with SMTP id smtpd.web10.3782.1588238825626628595 for ; Thu, 30 Apr 2020 02:27:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=G2R3eAe8; spf=pass (domain: gmail.com, ip: 209.85.222.195, mailfrom: andrey.warkentin@gmail.com) Received: by mail-qk1-f195.google.com with SMTP id i136so872115qke.10 for ; Thu, 30 Apr 2020 02:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wOJrIx2BYkd94KcF5cWEU6B9DSRDyhatZ3Dl9wm2fUE=; b=G2R3eAe8tgPzVAmZaF8s89m8sgPCzeguIScCa50GQp8svycOYuTFcng7Ru0vpmIjyV gdbUd4S5oxXu5jsOaLXMxJmoKkrQJkg2+NjjHxljlCuFwukVNcigcQ1oopN29SAOPkBb LmqwNU6mTm/FBhfIbVwZwDcvRp5qSOKZjhHmLxv1/auP6I1MP6Aygs5eqxxOXCQIZx8U AJ9j4cLLa7BJcnyoLqpDJLvwpWg9KaXzDhIlR22KHK8cFVmwMcc9zB3JXJZNsrO8lhmI eVBkCiU7cF/gFeqXtCsNzyn9eTu+uDTkva3HDktDrRQq1Y0upSDt4iaf+6kBKWZVypjd SdWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wOJrIx2BYkd94KcF5cWEU6B9DSRDyhatZ3Dl9wm2fUE=; b=Si914SSOxPh+WyNtnDRwfyuUVZmEwsdeRkPx/sAT9VdVhs+/5yzb9AbTLhAXQv2oCr 3kgZsF4XJomZRzCp8auqTKV0DSuPvmeRUfLSZjwCnffvTA1HVUiFIrJt4hcyPxDSsSWY 2FrycQ64lxV5k+uv3y1DTqcfTWyOpDOPCsU6K2fy0wvdsOrhGUp2k0u0aPawXsdpCwJf Xi8N7fOD/ssOwpvZ51i5oS+QmCwjvkoN7M8F7YYI3J+uwnYmPsmgk0lxCCX+krBvFWlH XSZiMkxjCyB6nvHyiW+mZOfSfHhgOH7uCMoEDNC1BF+ryH+AdcvIJluen780EqEkmcG1 GL4w== X-Gm-Message-State: AGi0PuY68rcjWuN/7SZdc7c7jXfv1EjJ85gxAZalDIXO0EuZmw36ULkX RRzuWnZ/8hxSH7IITeNWGcA7E7XwS+g= X-Google-Smtp-Source: APiQypJu+5/LHjQJ7Hm5RIl3T30k2ehITTpp8x/xMnz5pU5OASJiXYthu+gGOofE4isF8lzc0eFWRA== X-Received: by 2002:ae9:e509:: with SMTP id w9mr2624640qkf.252.1588238824617; Thu, 30 Apr 2020 02:27:04 -0700 (PDT) Return-Path: Received: from localhost.localdomain (c-98-214-99-181.hsd1.il.comcast.net. [98.214.99.181]) by smtp.gmail.com with ESMTPSA id i5sm1430355qki.42.2020.04.30.02.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2020 02:27:04 -0700 (PDT) From: "Andrei Warkentin" To: devel@edk2.groups.io Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, pete@akeo.ie, philmd@redhat.com Subject: [edk2-platforms][PATCH 2/4] RPi: fix MmcTransferBlock (writes) regression for eMMC Date: Thu, 30 Apr 2020 02:26:50 -0700 Message-Id: <20200430092652.54526-3-andrey.warkentin@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200430092652.54526-1-andrey.warkentin@gmail.com> References: <20200430092652.54526-1-andrey.warkentin@gmail.com> Way back when I added write block validation (https://github.com/andreiw/RaspberryPiPkg/commit/bdea35dc3f1652bf7b17505a20a5f52f7fde9707), I had screwed the logic up breaking eMMC. This starts to matter on the CM3, which has eMMC. Signed-off-by: Andrei Warkentin --- Platform/RaspberryPi/Drivers/MmcDxe/MmcBlockIo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/RaspberryPi/Drivers/MmcDxe/MmcBlockIo.c b/Platform/RaspberryPi/Drivers/MmcDxe/MmcBlockIo.c index 29a9fd7d..8a2f7f42 100644 --- a/Platform/RaspberryPi/Drivers/MmcDxe/MmcBlockIo.c +++ b/Platform/RaspberryPi/Drivers/MmcDxe/MmcBlockIo.c @@ -47,6 +47,7 @@ ValidateWrittenBlockCount ( /* * Not on MMC. */ + *TransferredBlocks = Count; return EFI_SUCCESS; } -- 2.17.1