From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web10.7037.1588253327678601369 for ; Thu, 30 Apr 2020 06:28:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=P+y/JoPp; spf=pass (domain: nuviainc.com, ip: 209.85.128.66, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f66.google.com with SMTP id h4so1860236wmb.4 for ; Thu, 30 Apr 2020 06:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=vibeAl0ou49kTlWSVTiw5JK3ldTLi2OjigmywOgfOXg=; b=P+y/JoPp5FtdewdW4QWjtAJwPjT1EBVwbq52e2tKn8K2QJhN7I5Q6IEps6M+2d/x37 SZ4USP0Ci+VPgm87hUXAkgu3zg8VUlX+roPRaoQ3ZVTtrrhvJq9b7ANw12ZhDWFFmyRT tVT7g064W8ajZC0IrP9ZqT/LH9OoSNoEwf5iSxEkvVrOSSaQXCgBQdrpNr4bz/n2TQOB Q+ft72Ie0uDOuQS+aVtZupRKjPyrtMeeIqx+iU2+JByGRQyqY1XwO1s+gFVFeU5Y9yy3 W/aOMqckJhMH/yMq5iljFdBEP21lQnOITx/H1xhKYynEjI5p9FmDvWuyxA142ObmPHNa 6qJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=vibeAl0ou49kTlWSVTiw5JK3ldTLi2OjigmywOgfOXg=; b=RDkYfDH6WaM/G7ZFZVg1GeD8qwSdc/785mD/FDzSxQtkUBtfjlN5u9HPUuvHIFUj1i x5uhojespg8qaKjSNYJZOXmYR55+ROPVbrxjvi/Bo9ylhv/MMZy1wj0R6MoYmHVKNVQD zqVa9LR5wEbC6BI+mQbpjWrlq8kzb1mn3L65RBGR0/7p8uvn0NWWyGsjrNalrqNOZONu 8xC8XDgWHSVeF/vyKGOBBp/h8uHBrUFKDl6V9bedt6+ye63szc2z0ziq0nE3Lp3ubS+D N4tbtsse70uLz1pX+1ZZaUggff9zbg/PwoqOQZ9tOXepLYsbHVKbptT0DQlWwSdrjTFS WLHw== X-Gm-Message-State: AGi0PuamCpnn8DGlWyZuVd97r7OuLXJZkkbuZ83WGanBAyvnARQFqp35 wrvaMGCURSaiHCpmQgKW2O/iWg== X-Google-Smtp-Source: APiQypIu/4FhXCfwrg7rNmGEFHhj08dFcUQHa73YaaHmQILeWc42mbnf1kREhASW08Z/kIQvoi7LFg== X-Received: by 2002:a1c:35c3:: with SMTP id c186mr3147977wma.66.1588253326208; Thu, 30 Apr 2020 06:28:46 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id t20sm11829148wmi.2.2020.04.30.06.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2020 06:28:45 -0700 (PDT) Date: Thu, 30 Apr 2020 14:28:43 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: Ard Biesheuvel , devel@edk2.groups.io, Andrew Fish , Bob Feng , Liming Gao , Michael D Kinney Subject: Re: [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers Message-ID: <20200430132843.GS21486@vanye> References: <20200429163616.5951-1-leif@nuviainc.com> <10151f16-f903-6fcf-92c8-f28f269eab53@arm.com> <20200429195343.GI21486@vanye> <464be692-53ef-8cac-ec69-2f87cc6f59cb@arm.com> <20200429214531.GN21486@vanye> <83cf98dc-ec56-2712-2835-e9b4c99049c9@arm.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Apr 30, 2020 at 13:17:26 +0200, Laszlo Ersek wrote: > On 04/29/20 23:47, Ard Biesheuvel wrote: > > On 4/29/20 11:45 PM, Leif Lindholm wrote: > >> On Wed, Apr 29, 2020 at 22:04:08 +0200, Ard Biesheuvel wrote: > >>>>> I am mostly concerned about the use of MmcDxe in new platforms. The > >>>>> other > >>>>> bits I'm not too worried about, and I think it would be fine to > >>>>> move those > >>>>> into Platform/ARM/VExpressPkg in edk2-platforms, instead of hoping > >>>>> that > >>>>> someone will turn up and turn them into driver model drivers. > >>>> > >>>> We could, although I would prefer not adding code to edk2-platforms > >>>> that would not be accepted was it submitted as a new contribution. > >>>> The SATA controller, I would ideally re-review and merge properly. > >>>> > >>>> If we do include the other drivers in platform-specific directories, I > >>>> want them to come with ... strongly worded readmes. > >>>> > >>> > >>> Right. > >>> > >>> Should we have some format for that? A way to log shortcomings along > >>> with > >>> the code? > >> > >> Thinking a bit more on this, maybe what we should do is add a template > >> to each file's top comment block. Draft proposal: > >> > >>    * > >>    * WARNING: > >>    * This driver fails to follow the UEFI driver model without a good > >>    * reason, and only remains in the tree because it is still used by > >>    * a small number of platforms. It will removed when no longer used. > >>    * New platforms should not use it, and no one should use this as > >>    * reference code for developing new drivers. > >>    * > >> > > > > Works for me > > > > You could also (or alternatively) add a separate file "DEPRECATED.txt" > to the directory -- sometimes people don't read file-top comments, > before duplicating or editing code. Something that's visible with a > simple "ls -l" might stand out more. I think what's more visible depends on the use-case. A comment at the top of the file is at least very visible to the reviewer if someone submits Yet Another Clone of an inadvisible driver. A DEPRECATED.txt might be a good ide for something like the EmbeddedPkg MmcDxe which we wan't people to stop *using* as opposed to copying. Ard? Thanks! / Leif > > Just a thought, I'm neutral on this. > > Thanks > Laszlo >