From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.78]) by mx.groups.io with SMTP id smtpd.web11.2055.1588225877542771447 for ; Wed, 29 Apr 2020 22:51:17 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@nxp1.onmicrosoft.com header.s=selector2-nxp1-onmicrosoft-com header.b=GqT14Jgj; spf=pass (domain: oss.nxp.com, ip: 40.107.20.78, mailfrom: pankaj.bansal@oss.nxp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PT93kBz0LcCOGq7Htfvow+7J56uYJM0tggcRtIWwBSlF215ZOkkT2bJIVAW6I0UyKVTbgDV/KMQPgomxYJGwgAOnmN8m69JuoKI0JAn1aEeOaO8R6eqs/DUz6Znlk9tH3T6/7uYvaLEX/NRwVr8AYhcY154gYYum3ORny1YGla5D3ovKQG7nsChZsEKuZTGj4KXouT4SyHxTkOBmsIactNrmb/vpSaB0HNNGu1E/iqOW6yACeQUYgglyf2sRdE4vZYOajFEr17EgQuaXFfy+dO+KfAd9H4eiJcIWxwGExEGjr9shoKA5wKRxj7uzyUTi8d5nKEDNDLM1pV6aW15lIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LepqR+Y50iVz7tE/oDSbnIzdnxnhTwPBRdCKeJ0+zdw=; b=DM0k8UVg93ZsNWn80pfEdyOk5hXZKUUwZJw1plTLcWssBnPBZ3GhoEAME/mKB5PLnzUGq+Dm0TCArgknrGi9+ufxBrAUIURYp/PVQFTy9A2CLLj6G5HsNZ9pEtQvs3etJ8hFTxlVX3QWZPmqa0VufTGaxJQ/OOC51AnTmdgMkGdza6tziFQpHLXfyuq1MBYTnD6y3YEEOBvxKrSl8hdJOCIMdPLruJht8NhlrlXEs/lbtoN+/OSMi3L1u2u/np/C97ITTOB9JQNY/YybqZeactIwhK0NVGYu17MrAp2vRaGeJ5xYkPaNuLpyebq9hvTcP3pFWeo1j0c4LPSpzAn1nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LepqR+Y50iVz7tE/oDSbnIzdnxnhTwPBRdCKeJ0+zdw=; b=GqT14JgjjnDCvmuzDc/wB+OWaCmg4ULv9J8h3+mKEiu0+zmLVp05xqIwN2zj+BiNnjXOHyeoRHXjgXY2BDpAfMQKWknpRIsYJbzrCTh3g63O6632NdRyXNHbi8bdlj/DX6kd5AUkBksMbE1NxyZmk0QmGZueff5GGJexQNu7YDs= Authentication-Results: nuviainc.com; dkim=none (message not signed) header.d=none;nuviainc.com; dmarc=none action=none header.from=oss.nxp.com; Received: from VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) by VI1PR04MB4429.eurprd04.prod.outlook.com (2603:10a6:803:6e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Thu, 30 Apr 2020 05:51:15 +0000 Received: from VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513]) by VI1PR04MB5933.eurprd04.prod.outlook.com ([fe80::45c4:8846:5327:9513%7]) with mapi id 15.20.2958.020; Thu, 30 Apr 2020 05:51:15 +0000 From: "Pankaj Bansal" To: Leif Lindholm , Meenakshi Aggarwal , Michael D Kinney , devel@edk2.groups.io, Varun Sethi , Samer El-Haj-Mahmoud , Jon Nettleton , Ard Biesheuvel Subject: [PATCH edk2-platforms v4 05/24] Silicon/Maxim: Add comments in Ds1307RtcLib Date: Fri, 1 May 2020 11:19:36 +0530 Message-ID: <20200501054955.13025-6-pankaj.bansal@oss.nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200501054955.13025-1-pankaj.bansal@oss.nxp.com> References: <20200501054955.13025-1-pankaj.bansal@oss.nxp.com> X-ClientProxiedBy: SG2PR03CA0131.apcprd03.prod.outlook.com (2603:1096:4:91::35) To VI1PR04MB5933.eurprd04.prod.outlook.com (2603:10a6:803:ec::16) Return-Path: pankaj.bansal@oss.nxp.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from uefi-workstation.ap.freescale.net (92.120.0.69) by SG2PR03CA0131.apcprd03.prod.outlook.com (2603:1096:4:91::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.14 via Frontend Transport; Thu, 30 Apr 2020 05:51:12 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [92.120.0.69] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: cffa2a40-4710-49bd-ae3a-08d7ecca7ee1 X-MS-TrafficTypeDiagnostic: VI1PR04MB4429:|VI1PR04MB4429: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 0389EDA07F X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5933.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(376002)(39860400002)(346002)(366004)(396003)(6512007)(26005)(16526019)(5660300002)(6666004)(966005)(478600001)(186003)(2906002)(110136005)(52116002)(6486002)(316002)(8676002)(6506007)(66476007)(19627235002)(86362001)(2616005)(66946007)(44832011)(956004)(66556008)(1076003)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sm5hGdQEVu5M9mAoksHWftRR+9bZ3UnwteeR4eyhmZIQGAuLWRVNRMXHz4sdEuDRyVcbhst/zCW6ahNQpTDZs9jFqmmfFtLISTC1JkKHibKqv3GG+jSzR4xJqS6vQ+bbSLXbp/myPqd3HtmXNnASCqPB12ksaOsEvj9t5JRYNmS9JO59///S2bVQXW/oC5CLJHc2j7cdcYSNl0S+awsdjnqSW7njmqB/HVepSy/aLof6RAUO3QDvaUiqDChSnQHQ+hkXuB+aMsOGJhHLm/vlHnls7wL/7SLqviTwt5Mzno44QxtP9i6Oo6NpwL7BtgRtnE1BNi09arQe7zKKoVeoXABw6r1R3+rBmPHjQZSkmSclXNSjcXOyrsKDkxVV1s1grE+2hzAQCaVijvVOBpqnPLY6MaHUlgSpvZSOOfFv7Oq9VuLgfBH+oqQstqJkXUoVgLpJSQljLV+a6eM9lbr7iCN5Wbys/7JRA0LHHWRMJToy+pTwpsmEFc/UXrh2zK04JjhXQlL/+GyqND8scJW/Rg== X-MS-Exchange-AntiSpam-MessageData: U6tmjDil9/qI6CK/WeooiU86mUeINYWjF6DrgtlJXRIjzZYHfGgSm4W1aZP9YRLC6OUdb0kQHqT7HythLAMVg1PswrGE4ieyncD65vrdHydOAke38SiUM3rJhAoVwmidza6TR/mR8YjJZ7mkJnq9PuIJY11EOk3d+2+AfR3NWGpBGzwm6erT3OcTCv9J1R5szwPam0owXNGfyC0WBLNj4vWW4ZTj+W3W3fzbSkLE48N8/zbnc9Ibih0JUP216NFSTsnivvNPlW6GpzfRJzMTFvgIwqGFzuVCvGNYP9fAFVZ8Ev+MSwjGEVjKAsD+YP7mWQsDV1Zmw3+IdXCW/NGRftd52BtHe91yVv/NuIhrEGJzf1z+HRt+bgashmnlPE8H/UW3ifQ/1xS8PDgBelYOQjRVCDR6JaMxmURaAcScjYWrgkpTc/tEN9bOMYljYYc9vJrRcMYUVqX/TIXY14k/LrIEtusJUeaMLhj6mcwIoSFJUIOtE53cxjS31K9mTnIf/iOUblemPH0KSPCuOS2SbTP4NlHNIa++s8HkRgnHB9BDSzHcnfz88c1Ze5dQV+Ym3zcK18uHWlCI/Et4yxZeWBvgxgUvVwEiPeKlLpQynlV2poNER5VR3sUcWnywEko+MMQgc92ZEBN2BlbRyApSAoWK0qMhQgn6eMJ6bbKRwkFmT6tGd98vZzmgK8SnVwiDvObQ57Vo8qyfutqNLPvikmAArF5Mp56fOElm0J4XswvIboIDvFJdWY3qNrBq3qnBb2sWQVdF05boFGsP5sYec7HwEmd8GdapHlzYlB+itSI= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cffa2a40-4710-49bd-ae3a-08d7ecca7ee1 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2020 05:51:15.4691 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KY37rXHARFwV5CXrC34SeeWxgldWYkWQZI/6x7Z+UHNFDOnvJKgckAbr342wOWhnu9LPKIcaSbTIm/k/1XcK9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4429 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain From: Pankaj Bansal Add comments to explain the register read and write operation on Ds1307. These comments have been referred from data sheet: https://datasheets.maximintegrated.com/en/ds/DS1307.pdf Signed-off-by: Pankaj Bansal Reviewed-by: Leif Lindholm --- Notes: V4: - No change =20 V3: - No change Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c b/Silicon/Ma= xim/Library/Ds1307RtcLib/Ds1307RtcLib.c index fd7a8696e405..444e01124811 100644 --- a/Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c +++ b/Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c @@ -28,6 +28,11 @@ STATIC EFI_I2C_MASTER_PROTOCOL *mI2cMaster; =20 /** Read RTC register. + Data Read-Slave Transmitter Mode + + = + + The first byte is received and handled as in the slave receiver mode. =20 @param RtcRegAddr Register offset of RTC to be read. =20 @@ -69,6 +74,9 @@ RtcRead ( =20 /** Write RTC register. + Data Write-Slave Receiver Mode + + =20 @param RtcRegAddr Register offset of RTC to write. @param Val Value to be written --=20 2.17.1