public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: devel@edk2.groups.io
Subject: Re: [PATCH edk2-platforms v3 0/8] move obsolete platform drivers out of core edk2
Date: Mon, 4 May 2020 12:00:58 +0100	[thread overview]
Message-ID: <20200504110058.GF21486@vanye> (raw)
In-Reply-To: <20200430171650.24139-1-ard.biesheuvel@arm.com>

On Thu, Apr 30, 2020 at 19:16:41 +0200, Ard Biesheuvel wrote:
> This is a followup to two patches I sent out separately yesterday, and to
> the subsequent discussion regarding annotating obsolete drivers as unfit
> for reuse if they don't follow the UEFI driver model.
> 
> I have rounded up all the stuff I have in flight for edk2-platforms at
> the moment, so this v3 supersedes everything else for edk2-platforms you
> may have in your mailbox.
> 
> Once this is in, I will follow up with a series for EmbeddedPkg to get
> rid of the originals.
> 
> Changes since v2:
> - move DwEmmcDxe, Lan91x, Lan9118 and ISP 1761 drivers as well
> - incorporate a build fixlet that I sent out separately as well
> - add some acks
> 
> Changes since v1:
> - use gEmbeddedMmcHostProtocolGuid not gEdkiiMmcHostProtocolGuid
> - add WARNING comment blocks to all files to document the fact that these
>   files are only kept for sentimental reasons
> 
> Ard Biesheuvel (8):
>   Omap35xxPkg/LcdGraphicsOutputDxe: add missing protocol reference
>   Platform/ARM/VExpressPkg: incorporate PL180 driver
>   Platform/ARM/JunoPkg: incorporate SiI3132 SATA controller driver
>   Silicon/Synopsys/DesignWare: import eMMC DXE driver from EmbeddedPkg
>   Platform/HiKey: switch to relocated version of eMMC driver
>   Platform/ARM/VExpressPkg: incorporate Lan91x driver
>   Platform/ARM/VExpressPkg: incorporate Lan9118 driver
>   Platform/ARM/VExpressPkg: incorporate ISP 1761 USB host driver

Many thanks for this!
For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

>  Platform/ARM/JunoPkg/ArmJuno.dec              |    4 +-
>  Platform/ARM/JunoPkg/ArmJuno.dsc              |   10 +-
>  Platform/ARM/JunoPkg/ArmJuno.fdf              |    4 +-
>  .../Drivers/SataSiI3132Dxe/ComponentName.c    |  179 ++
>  .../Drivers/SataSiI3132Dxe/SataSiI3132.c      |  546 ++++
>  .../Drivers/SataSiI3132Dxe/SataSiI3132.h      |  286 +++
>  .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf |   38 +
>  .../SataSiI3132Dxe/SiI3132AtaPassThru.c       |  834 ++++++
>  Platform/ARM/SgiPkg/SgiPlatform.dsc           |    4 +-
>  Platform/ARM/SgiPkg/SgiPlatform.fdf           |    2 +-
>  .../ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc  |   14 +-
>  .../ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf  |    6 +-
>  .../VExpressPkg/ArmVExpress-FVP-AArch64.dsc   |    6 +-
>  .../VExpressPkg/ArmVExpress-FVP-AArch64.fdf   |    4 +-
>  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc  |    6 +-
>  Platform/ARM/VExpressPkg/ArmVExpressPkg.dec   |   18 +
>  .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c     |  636 +++++
>  .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h     |  123 +
>  .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf   |   39 +
>  .../Drivers/Lan9118Dxe/Lan9118Dxe.c           | 1539 ++++++++++++
>  .../Drivers/Lan9118Dxe/Lan9118Dxe.h           |  304 +++
>  .../Drivers/Lan9118Dxe/Lan9118Dxe.inf         |   58 +
>  .../Drivers/Lan9118Dxe/Lan9118DxeHw.h         |  401 +++
>  .../Drivers/Lan9118Dxe/Lan9118DxeUtil.c       | 1039 ++++++++
>  .../Drivers/Lan9118Dxe/Lan9118DxeUtil.h       |  283 +++
>  .../VExpressPkg/Drivers/Lan91xDxe/Lan91xDxe.c | 2236 +++++++++++++++++
>  .../Drivers/Lan91xDxe/Lan91xDxe.inf           |   59 +
>  .../Drivers/Lan91xDxe/Lan91xDxeHw.h           |  279 ++
>  .../Drivers/PL180MciDxe/PL180Mci.c            |  570 +++++
>  .../Drivers/PL180MciDxe/PL180Mci.h            |  169 ++
>  .../Drivers/PL180MciDxe/PL180MciDxe.inf       |   53 +
>  Platform/Hisilicon/HiKey/HiKey.dsc            |    7 +-
>  Platform/Hisilicon/HiKey/HiKey.fdf            |    2 +-
>  Silicon/Synopsys/DesignWare/DesignWare.dec    |    9 +
>  Silicon/Synopsys/DesignWare/DesignWare.dsc    |    2 +
>  .../DesignWare/Drivers/DwEmmcDxe/DwEmmc.h     |  132 +
>  .../DesignWare/Drivers/DwEmmcDxe/DwEmmcDxe.c  |  693 +++++
>  .../Drivers/DwEmmcDxe/DwEmmcDxe.inf           |   56 +
>  .../LcdGraphicsOutputDxe.inf                  |    1 +
>  39 files changed, 10618 insertions(+), 33 deletions(-)
>  create mode 100644 Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/ComponentName.c
>  create mode 100644 Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c
>  create mode 100644 Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h
>  create mode 100644 Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf
>  create mode 100644 Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan91xDxe/Lan91xDxe.c
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan91xDxe/Lan91xDxe.inf
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.h
>  create mode 100644 Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180MciDxe.inf
>  create mode 100644 Silicon/Synopsys/DesignWare/Drivers/DwEmmcDxe/DwEmmc.h
>  create mode 100644 Silicon/Synopsys/DesignWare/Drivers/DwEmmcDxe/DwEmmcDxe.c
>  create mode 100644 Silicon/Synopsys/DesignWare/Drivers/DwEmmcDxe/DwEmmcDxe.inf
> 
> -- 
> 2.17.1
> 

  parent reply	other threads:[~2020-05-04 11:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 17:16 [PATCH edk2-platforms v3 0/8] move obsolete platform drivers out of core edk2 Ard Biesheuvel
2020-04-30 17:16 ` [PATCH edk2-platforms v3 1/8] Omap35xxPkg/LcdGraphicsOutputDxe: add missing protocol reference Ard Biesheuvel
2020-04-30 17:16 ` [PATCH edk2-platforms v3 2/8] Platform/ARM/VExpressPkg: incorporate PL180 driver Ard Biesheuvel
2020-04-30 17:16 ` [PATCH edk2-platforms v3 3/8] Platform/ARM/JunoPkg: incorporate SiI3132 SATA controller driver Ard Biesheuvel
2020-05-04 10:57   ` Leif Lindholm
2020-04-30 17:16 ` [PATCH edk2-platforms v3 4/8] Silicon/Synopsys/DesignWare: import eMMC DXE driver from EmbeddedPkg Ard Biesheuvel
2020-05-04 10:58   ` Leif Lindholm
2020-05-04 11:40     ` [edk2-devel] " Philippe Mathieu-Daudé
2020-05-04 11:44       ` Philippe Mathieu-Daudé
2020-04-30 17:16 ` [PATCH edk2-platforms v3 5/8] Platform/HiKey: switch to relocated version of eMMC driver Ard Biesheuvel
2020-04-30 17:16 ` [PATCH edk2-platforms v3 6/8] Platform/ARM/VExpressPkg: incorporate Lan91x driver Ard Biesheuvel
2020-05-04 11:41   ` [edk2-devel] " Philippe Mathieu-Daudé
2020-05-04 11:44     ` Philippe Mathieu-Daudé
2020-04-30 17:16 ` [PATCH edk2-platforms v3 7/8] Platform/ARM/VExpressPkg: incorporate Lan9118 driver Ard Biesheuvel
2020-05-04 11:42   ` [edk2-devel] " Philippe Mathieu-Daudé
2020-05-04 11:44     ` Philippe Mathieu-Daudé
2020-04-30 17:16 ` [PATCH edk2-platforms v3 8/8] Platform/ARM/VExpressPkg: incorporate ISP 1761 USB host driver Ard Biesheuvel
2020-05-04 11:00   ` Leif Lindholm
2020-05-04 11:00 ` Leif Lindholm [this message]
2020-05-04 13:19   ` [PATCH edk2-platforms v3 0/8] move obsolete platform drivers out of core edk2 Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200504110058.GF21486@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox