From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web11.3798.1588590062433927618 for ; Mon, 04 May 2020 04:01:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=NIMOKDve; spf=pass (domain: nuviainc.com, ip: 209.85.128.67, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f67.google.com with SMTP id v8so15282127wma.0 for ; Mon, 04 May 2020 04:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ke1wtIBzvLMf9lspLpGhVzDQ3CvFsc5kAXBGvzruMKI=; b=NIMOKDvezzay6RwXdVJfIFoxjQ8YKbejBhysjFTADHKOsIT4rsOyLzJ47Idzyx2yuI 6vwETjfVpix8ywWxRSQzqSAkn6wbi+AJq6LPhwfhgzc5vSq3MWuHpnRwJMqK/QKbg49G Dy+nnTzRTsIA5nFmfVXlZJTBfHMYwE8DUXElV/fJvQeMGQlnFsqai3jnHMjG5VMTFk+1 BU1AgAbp7LWonQaW35SCu7nTlYVpTpdQCiCru185lQMbM3ot0YIWwF4PVwfaokS7zYlH X5jzPQSqW7eV/Y3sDlF+zlGEcsjCV2HlNDyaJbw28zMjBAtklOQuCYzV3YlEdgrCAkvH W4tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ke1wtIBzvLMf9lspLpGhVzDQ3CvFsc5kAXBGvzruMKI=; b=SVP5eEm7C5yj3hO4qTjEOOS9L+76zYar1kkVmX0WNPdzIygaRV/gIjeLoit3EWNdJL bEpsoym7z2yUbXbEa7cgo+TnnUXmt0+NHIVrh1U1DOyKBpwteSstSNjqOrobOg+zW/3T 99WX1TI9OmuvW6RMIKTmutFA8sCT+lkxMed3KVY/YzpaN5QnQ5YtT9j0GXcH+uMig/UP Vv7TLG2GOorRO/enM8a0C5I52PE2DlUi53BDlyWGADaqZYhnYJZSvShEqbJjUaLkC+sZ hhyNQeLJBA2XEgoB0ZlRIf+AJdIeJvW2F8/SWCTNV13CD9gbNlQf47dxKykH82fqJSvR KwrQ== X-Gm-Message-State: AGi0PuYyR6V+DcWw5X36E9J6c0jkIjWZw0cwPRSLTAF1Yz+G5kdEdSY2 iv0Lfq5PGBXTwuT91VE5DRDRfQ== X-Google-Smtp-Source: APiQypI0JT7CSBYjjc3vy7Tnnml7fgbcZr/FPsmy3L4El9kR/QY33gJlvLKdRZiGi4UvtgjUqe2O1g== X-Received: by 2002:a1c:b684:: with SMTP id g126mr13440690wmf.163.1588590061014; Mon, 04 May 2020 04:01:01 -0700 (PDT) Return-Path: Received: from vanye ([2001:470:1f09:12f0:b26e:bfff:fea9:f1b8]) by smtp.gmail.com with ESMTPSA id a8sm5428225wrg.85.2020.05.04.04.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2020 04:01:00 -0700 (PDT) Date: Mon, 4 May 2020 12:00:58 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: devel@edk2.groups.io Subject: Re: [PATCH edk2-platforms v3 0/8] move obsolete platform drivers out of core edk2 Message-ID: <20200504110058.GF21486@vanye> References: <20200430171650.24139-1-ard.biesheuvel@arm.com> MIME-Version: 1.0 In-Reply-To: <20200430171650.24139-1-ard.biesheuvel@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 30, 2020 at 19:16:41 +0200, Ard Biesheuvel wrote: > This is a followup to two patches I sent out separately yesterday, and to > the subsequent discussion regarding annotating obsolete drivers as unfit > for reuse if they don't follow the UEFI driver model. > > I have rounded up all the stuff I have in flight for edk2-platforms at > the moment, so this v3 supersedes everything else for edk2-platforms you > may have in your mailbox. > > Once this is in, I will follow up with a series for EmbeddedPkg to get > rid of the originals. > > Changes since v2: > - move DwEmmcDxe, Lan91x, Lan9118 and ISP 1761 drivers as well > - incorporate a build fixlet that I sent out separately as well > - add some acks > > Changes since v1: > - use gEmbeddedMmcHostProtocolGuid not gEdkiiMmcHostProtocolGuid > - add WARNING comment blocks to all files to document the fact that these > files are only kept for sentimental reasons > > Ard Biesheuvel (8): > Omap35xxPkg/LcdGraphicsOutputDxe: add missing protocol reference > Platform/ARM/VExpressPkg: incorporate PL180 driver > Platform/ARM/JunoPkg: incorporate SiI3132 SATA controller driver > Silicon/Synopsys/DesignWare: import eMMC DXE driver from EmbeddedPkg > Platform/HiKey: switch to relocated version of eMMC driver > Platform/ARM/VExpressPkg: incorporate Lan91x driver > Platform/ARM/VExpressPkg: incorporate Lan9118 driver > Platform/ARM/VExpressPkg: incorporate ISP 1761 USB host driver Many thanks for this! For the series: Reviewed-by: Leif Lindholm > Platform/ARM/JunoPkg/ArmJuno.dec | 4 +- > Platform/ARM/JunoPkg/ArmJuno.dsc | 10 +- > Platform/ARM/JunoPkg/ArmJuno.fdf | 4 +- > .../Drivers/SataSiI3132Dxe/ComponentName.c | 179 ++ > .../Drivers/SataSiI3132Dxe/SataSiI3132.c | 546 ++++ > .../Drivers/SataSiI3132Dxe/SataSiI3132.h | 286 +++ > .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf | 38 + > .../SataSiI3132Dxe/SiI3132AtaPassThru.c | 834 ++++++ > Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 +- > Platform/ARM/SgiPkg/SgiPlatform.fdf | 2 +- > .../ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 14 +- > .../ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf | 6 +- > .../VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 6 +- > .../VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 4 +- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 6 +- > Platform/ARM/VExpressPkg/ArmVExpressPkg.dec | 18 + > .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c | 636 +++++ > .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h | 123 + > .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf | 39 + > .../Drivers/Lan9118Dxe/Lan9118Dxe.c | 1539 ++++++++++++ > .../Drivers/Lan9118Dxe/Lan9118Dxe.h | 304 +++ > .../Drivers/Lan9118Dxe/Lan9118Dxe.inf | 58 + > .../Drivers/Lan9118Dxe/Lan9118DxeHw.h | 401 +++ > .../Drivers/Lan9118Dxe/Lan9118DxeUtil.c | 1039 ++++++++ > .../Drivers/Lan9118Dxe/Lan9118DxeUtil.h | 283 +++ > .../VExpressPkg/Drivers/Lan91xDxe/Lan91xDxe.c | 2236 +++++++++++++++++ > .../Drivers/Lan91xDxe/Lan91xDxe.inf | 59 + > .../Drivers/Lan91xDxe/Lan91xDxeHw.h | 279 ++ > .../Drivers/PL180MciDxe/PL180Mci.c | 570 +++++ > .../Drivers/PL180MciDxe/PL180Mci.h | 169 ++ > .../Drivers/PL180MciDxe/PL180MciDxe.inf | 53 + > Platform/Hisilicon/HiKey/HiKey.dsc | 7 +- > Platform/Hisilicon/HiKey/HiKey.fdf | 2 +- > Silicon/Synopsys/DesignWare/DesignWare.dec | 9 + > Silicon/Synopsys/DesignWare/DesignWare.dsc | 2 + > .../DesignWare/Drivers/DwEmmcDxe/DwEmmc.h | 132 + > .../DesignWare/Drivers/DwEmmcDxe/DwEmmcDxe.c | 693 +++++ > .../Drivers/DwEmmcDxe/DwEmmcDxe.inf | 56 + > .../LcdGraphicsOutputDxe.inf | 1 + > 39 files changed, 10618 insertions(+), 33 deletions(-) > create mode 100644 Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/ComponentName.c > create mode 100644 Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c > create mode 100644 Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h > create mode 100644 Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf > create mode 100644 Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c > create mode 100644 Platform/ARM/VExpressPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c > create mode 100644 Platform/ARM/VExpressPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h > create mode 100644 Platform/ARM/VExpressPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf > create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c > create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h > create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf > create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h > create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c > create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h > create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan91xDxe/Lan91xDxe.c > create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan91xDxe/Lan91xDxe.inf > create mode 100644 Platform/ARM/VExpressPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h > create mode 100644 Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c > create mode 100644 Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.h > create mode 100644 Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180MciDxe.inf > create mode 100644 Silicon/Synopsys/DesignWare/Drivers/DwEmmcDxe/DwEmmc.h > create mode 100644 Silicon/Synopsys/DesignWare/Drivers/DwEmmcDxe/DwEmmcDxe.c > create mode 100644 Silicon/Synopsys/DesignWare/Drivers/DwEmmcDxe/DwEmmcDxe.inf > > -- > 2.17.1 >