* [PATCH 1/5] EmbeddedPkg: remove DwEmmcDxe host controller driver
2020-05-04 13:57 [PATCH 0/5] EmbeddedPkg spring cleaning Ard Biesheuvel
@ 2020-05-04 13:57 ` Ard Biesheuvel
2020-05-04 13:57 ` [PATCH 2/5] EmbeddedPkg: remove Lan91x network " Ard Biesheuvel
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Ard Biesheuvel @ 2020-05-04 13:57 UTC (permalink / raw)
To: devel; +Cc: leif, philmd, Ard Biesheuvel
The Synopsys DesignWare eMMC host controller driver does not implement
that SD/MMC host controller protocol that the UEFI spec defines, but an
obsolete EDK2-specific one that predates it. It also does not implement
the UEFI driver model.
Due to this, it has been moved into the edk2-platforms repository,
alongside its remaining users, which have been updated to refer to it in
its new location. So drop this version from EmbeddedPkg.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
EmbeddedPkg/EmbeddedPkg.dec | 6 -
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf | 49 --
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h | 127 ----
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 688 --------------------
4 files changed, 870 deletions(-)
diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec
index 7e0f692d6fc1..11e9f4f57731 100644
--- a/EmbeddedPkg/EmbeddedPkg.dec
+++ b/EmbeddedPkg/EmbeddedPkg.dec
@@ -144,12 +144,6 @@ [PcdsFixedAtBuild.common]
# LAN91x Ethernet Driver PCDs
gEmbeddedTokenSpaceGuid.PcdLan91xDxeBaseAddress|0x0|UINT32|0x00000029
- # DwEmmc Driver PCDs
- gEmbeddedTokenSpaceGuid.PcdDwEmmcDxeBaseAddress|0x0|UINT32|0x00000035
- gEmbeddedTokenSpaceGuid.PcdDwEmmcDxeClockFrequencyInHz|0x0|UINT32|0x00000036
- gEmbeddedTokenSpaceGuid.PcdDwEmmcDxeMaxClockFreqInHz|0x0|UINT32|0x00000037
- gEmbeddedTokenSpaceGuid.PcdDwEmmcDxeFifoDepth|0x0|UINT32|0x00000038
-
#
# Android FastBoot
#
diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf
deleted file mode 100644
index cf8e2422134d..000000000000
diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h
deleted file mode 100644
index 2f3659718a39..000000000000
diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
deleted file mode 100644
index b95917bd7aa5..000000000000
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/5] EmbeddedPkg: remove Lan91x network controller driver
2020-05-04 13:57 [PATCH 0/5] EmbeddedPkg spring cleaning Ard Biesheuvel
2020-05-04 13:57 ` [PATCH 1/5] EmbeddedPkg: remove DwEmmcDxe host controller driver Ard Biesheuvel
@ 2020-05-04 13:57 ` Ard Biesheuvel
2020-05-04 13:57 ` [PATCH 3/5] EmbeddedPkg: remove Lan9118 " Ard Biesheuvel
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Ard Biesheuvel @ 2020-05-04 13:57 UTC (permalink / raw)
To: devel; +Cc: leif, philmd, Ard Biesheuvel
The Lan91x network controller driver does not implement the UEFI driver
model, and is not a suitable example for new drivers to be based on.
Also, it is currently only used on a limited set of ARM development
platforms.
Due to this, it has been moved into the edk2-platforms repository,
alongside its remaining users, which have been updated to refer to it in
its new location. So drop this version from EmbeddedPkg.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
EmbeddedPkg/EmbeddedPkg.dec | 3 -
EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf | 52 -
EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h | 272 ---
EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c | 2229 --------------------
4 files changed, 2556 deletions(-)
diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec
index 11e9f4f57731..6ef070e9e436 100644
--- a/EmbeddedPkg/EmbeddedPkg.dec
+++ b/EmbeddedPkg/EmbeddedPkg.dec
@@ -141,9 +141,6 @@ [PcdsFixedAtBuild.common]
# duplex operation is suspected to be broken in the driver.
gEmbeddedTokenSpaceGuid.PcdLan9118NegotiationFeatureMask|0xFFFFFEBF|UINT32|0x00000028
- # LAN91x Ethernet Driver PCDs
- gEmbeddedTokenSpaceGuid.PcdLan91xDxeBaseAddress|0x0|UINT32|0x00000029
-
#
# Android FastBoot
#
diff --git a/EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf b/EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf
deleted file mode 100644
index ba63d26fe85a..000000000000
diff --git a/EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h b/EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h
deleted file mode 100644
index d13f2bc6efc0..000000000000
diff --git a/EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c b/EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c
deleted file mode 100644
index e3e8d6889594..000000000000
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/5] EmbeddedPkg: remove Lan9118 network controller driver
2020-05-04 13:57 [PATCH 0/5] EmbeddedPkg spring cleaning Ard Biesheuvel
2020-05-04 13:57 ` [PATCH 1/5] EmbeddedPkg: remove DwEmmcDxe host controller driver Ard Biesheuvel
2020-05-04 13:57 ` [PATCH 2/5] EmbeddedPkg: remove Lan91x network " Ard Biesheuvel
@ 2020-05-04 13:57 ` Ard Biesheuvel
2020-05-04 13:57 ` [PATCH 4/5] EmbeddedPkg: remove SiI3132 SATA " Ard Biesheuvel
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Ard Biesheuvel @ 2020-05-04 13:57 UTC (permalink / raw)
To: devel; +Cc: leif, philmd, Ard Biesheuvel
The Lan9118 network controller driver does not implement the UEFI driver
model, and is not a suitable example for new drivers to be based on.
Also, it is currently only used on a limited set of ARM development
platforms.
Due to this, it has been moved into the edk2-platforms repository,
alongside its remaining users, which have been updated to refer to it in
its new location. So drop this version from EmbeddedPkg.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
EmbeddedPkg/EmbeddedPkg.dec | 8 -
EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf | 51 -
EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h | 297 ----
EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h | 394 -----
EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h | 276 ----
EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c | 1532 --------------------
EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c | 1032 -------------
7 files changed, 3590 deletions(-)
diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec
index 6ef070e9e436..8b3019eec725 100644
--- a/EmbeddedPkg/EmbeddedPkg.dec
+++ b/EmbeddedPkg/EmbeddedPkg.dec
@@ -133,14 +133,6 @@ [PcdsFixedAtBuild.common]
gEmbeddedTokenSpaceGuid.PcdGdbMaxPacketRetryCount|10000000|UINT32|0x0000004c
gEmbeddedTokenSpaceGuid.PcdGdbTimerPeriodMilliseconds|250|UINT32|0x0000004d
- # LAN9118 Ethernet Driver PCDs
- gEmbeddedTokenSpaceGuid.PcdLan9118DxeBaseAddress|0x0|UINT32|0x00000025
- gEmbeddedTokenSpaceGuid.PcdLan9118DefaultMacAddress|0x0|UINT64|0x00000026
- gEmbeddedTokenSpaceGuid.PcdLan9118DefaultNegotiationTimeout|4000|UINT32|0x00000027
- # The default feature mask below disables full duplex negotiation, since full
- # duplex operation is suspected to be broken in the driver.
- gEmbeddedTokenSpaceGuid.PcdLan9118NegotiationFeatureMask|0xFFFFFEBF|UINT32|0x00000028
-
#
# Android FastBoot
#
diff --git a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf
deleted file mode 100644
index 35e6460f3b2e..000000000000
diff --git a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h
deleted file mode 100644
index 76cf9226c510..000000000000
diff --git a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h
deleted file mode 100644
index 80df34b87e63..000000000000
diff --git a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h
deleted file mode 100644
index 24e74077e559..000000000000
diff --git a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c
deleted file mode 100644
index 2138f7576bec..000000000000
diff --git a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c
deleted file mode 100644
index be4d6bb9c1cf..000000000000
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 4/5] EmbeddedPkg: remove SiI3132 SATA controller driver
2020-05-04 13:57 [PATCH 0/5] EmbeddedPkg spring cleaning Ard Biesheuvel
` (2 preceding siblings ...)
2020-05-04 13:57 ` [PATCH 3/5] EmbeddedPkg: remove Lan9118 " Ard Biesheuvel
@ 2020-05-04 13:57 ` Ard Biesheuvel
2020-05-04 13:57 ` [PATCH 5/5] EmbeddedPkg: remove ISP 1716 USB host " Ard Biesheuvel
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Ard Biesheuvel @ 2020-05-04 13:57 UTC (permalink / raw)
To: devel; +Cc: leif, philmd, Ard Biesheuvel
The SiI3132 SATA controller driver does not implement the UEFI driver
model, and is not a suitable example for new drivers to be based on.
Also, it is currently only used on a limited set of ARM development
platforms.
Due to this, it has been moved into the edk2-platforms repository,
alongside its remaining users, which have been updated to refer to it in
its new location. So drop this version from EmbeddedPkg.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
EmbeddedPkg/EmbeddedPkg.dec | 3 -
EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf | 42 -
EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 279 -------
EmbeddedPkg/Drivers/SataSiI3132Dxe/ComponentName.c | 172 ----
EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 539 -------------
EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 827 --------------------
6 files changed, 1862 deletions(-)
diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec
index 8b3019eec725..0d7d76fc3c69 100644
--- a/EmbeddedPkg/EmbeddedPkg.dec
+++ b/EmbeddedPkg/EmbeddedPkg.dec
@@ -87,9 +87,6 @@ [PcdsFeatureFlag.common]
gEmbeddedTokenSpaceGuid.PcdPrePiProduceMemoryTypeInformationHob|FALSE|BOOLEAN|0x0000001b
gEmbeddedTokenSpaceGuid.PcdGdbSerial|FALSE|BOOLEAN|0x00000053
- gEmbeddedTokenSpaceGuid.PcdSataSiI3132FeaturePMPSupport|FALSE|BOOLEAN|0x00000050
- gEmbeddedTokenSpaceGuid.PcdSataSiI3132FeatureDirectCommandIssuing|FALSE|BOOLEAN|0x00000051
-
[PcdsFixedAtBuild.common]
gEmbeddedTokenSpaceGuid.PcdPrePiStackBase|0|UINT32|0x0000000b
gEmbeddedTokenSpaceGuid.PcdPrePiStackSize|131072|UINT32|0x0000000c
diff --git a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf
deleted file mode 100644
index 227e52adb45a..000000000000
diff --git a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h
deleted file mode 100644
index 20636574c271..000000000000
diff --git a/EmbeddedPkg/Drivers/SataSiI3132Dxe/ComponentName.c b/EmbeddedPkg/Drivers/SataSiI3132Dxe/ComponentName.c
deleted file mode 100644
index 0ce01bd363fc..000000000000
diff --git a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c
deleted file mode 100644
index df0f16d19a8f..000000000000
diff --git a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c
deleted file mode 100644
index 0e2905c1ebb0..000000000000
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/5] EmbeddedPkg: remove ISP 1716 USB host controller driver
2020-05-04 13:57 [PATCH 0/5] EmbeddedPkg spring cleaning Ard Biesheuvel
` (3 preceding siblings ...)
2020-05-04 13:57 ` [PATCH 4/5] EmbeddedPkg: remove SiI3132 SATA " Ard Biesheuvel
@ 2020-05-04 13:57 ` Ard Biesheuvel
2020-05-05 14:04 ` [PATCH 0/5] EmbeddedPkg spring cleaning Philippe Mathieu-Daudé
2020-05-05 14:08 ` Leif Lindholm
6 siblings, 0 replies; 9+ messages in thread
From: Ard Biesheuvel @ 2020-05-04 13:57 UTC (permalink / raw)
To: devel; +Cc: leif, philmd, Ard Biesheuvel
The ISP 1716 USB host controller driver does not implement the UEFI
driver model, and is not a suitable example for new drivers to be
based on. Also, it is currently only used on a limited set of ARM
development platforms.
Due to this, it has been moved into the edk2-platforms repository,
alongside its remaining users, which have been updated to refer to it in
its new location. So drop this version from EmbeddedPkg.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
EmbeddedPkg/EmbeddedPkg.dec | 3 -
EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf | 38 --
EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h | 116 ----
EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c | 629 --------------------
4 files changed, 786 deletions(-)
diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec
index 0d7d76fc3c69..c2068ce5a8ce 100644
--- a/EmbeddedPkg/EmbeddedPkg.dec
+++ b/EmbeddedPkg/EmbeddedPkg.dec
@@ -146,9 +146,6 @@ [PcdsFixedAtBuild.common]
[PcdsFixedAtBuild.ARM]
gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|0|UINT8|0x00000011
- # ISP1761 USB OTG Controller
- gEmbeddedTokenSpaceGuid.PcdIsp1761BaseAddress|0|UINT32|0x00000021
-
[PcdsFixedAtBuild.AARCH64]
gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|0|UINT8|0x00000011
diff --git a/EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf b/EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf
deleted file mode 100644
index b0c595c7b6e5..000000000000
diff --git a/EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h b/EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h
deleted file mode 100644
index c4f1aabdc3cc..000000000000
diff --git a/EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c b/EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c
deleted file mode 100644
index 3ad453595bcd..000000000000
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 0/5] EmbeddedPkg spring cleaning
2020-05-04 13:57 [PATCH 0/5] EmbeddedPkg spring cleaning Ard Biesheuvel
` (4 preceding siblings ...)
2020-05-04 13:57 ` [PATCH 5/5] EmbeddedPkg: remove ISP 1716 USB host " Ard Biesheuvel
@ 2020-05-05 14:04 ` Philippe Mathieu-Daudé
2020-05-05 14:08 ` Leif Lindholm
6 siblings, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-05 14:04 UTC (permalink / raw)
To: Ard Biesheuvel, devel; +Cc: leif
On 5/4/20 3:57 PM, Ard Biesheuvel wrote:
> Delete a couple of obsole driver from EmbeddedPkg. They have been moved
> into edk2-platforms alongside the small set of development platforms
> that still use them, but they are no long fit for use beyond that.
>
> Diffs have been omitted for files that are completely deleted. The full
> set can be found here:
> https://github.com/ardbiesheuvel/edk2/tree/embeddedpkg-spring-cleaning
>
> Ard Biesheuvel (5):
> EmbeddedPkg: remove DwEmmcDxe host controller driver
> EmbeddedPkg: remove Lan91x network controller driver
> EmbeddedPkg: remove Lan9118 network controller driver
> EmbeddedPkg: remove SiI3132 SATA controller driver
> EmbeddedPkg: remove ISP 1716 USB host controller driver
>
> EmbeddedPkg/EmbeddedPkg.dec | 23 -
> EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf | 49 -
> .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf | 38 -
> EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf | 51 -
> EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf | 52 -
> .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf | 42 -
> EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h | 127 -
> .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h | 116 -
> EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h | 297 ---
> EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h | 394 ---
> .../Drivers/Lan9118Dxe/Lan9118DxeUtil.h | 276 --
> EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h | 272 --
> .../Drivers/SataSiI3132Dxe/SataSiI3132.h | 279 ---
> EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 688 -----
> .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c | 629 -----
> EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c | 1532 -----------
> .../Drivers/Lan9118Dxe/Lan9118DxeUtil.c | 1032 --------
> EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c | 2229 -----------------
> .../Drivers/SataSiI3132Dxe/ComponentName.c | 172 --
> .../Drivers/SataSiI3132Dxe/SataSiI3132.c | 539 ----
> .../SataSiI3132Dxe/SiI3132AtaPassThru.c | 827 ------
> 21 files changed, 9664 deletions(-)
Nice diffstat... ^^^^
Series:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 0/5] EmbeddedPkg spring cleaning
2020-05-04 13:57 [PATCH 0/5] EmbeddedPkg spring cleaning Ard Biesheuvel
` (5 preceding siblings ...)
2020-05-05 14:04 ` [PATCH 0/5] EmbeddedPkg spring cleaning Philippe Mathieu-Daudé
@ 2020-05-05 14:08 ` Leif Lindholm
2020-05-05 15:46 ` Ard Biesheuvel
6 siblings, 1 reply; 9+ messages in thread
From: Leif Lindholm @ 2020-05-05 14:08 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: devel, philmd
On Mon, May 04, 2020 at 15:57:22 +0200, Ard Biesheuvel wrote:
> Delete a couple of obsole driver from EmbeddedPkg. They have been moved
> into edk2-platforms alongside the small set of development platforms
> that still use them, but they are no long fit for use beyond that.
>
> Diffs have been omitted for files that are completely deleted. The full
> set can be found here:
> https://github.com/ardbiesheuvel/edk2/tree/embeddedpkg-spring-cleaning
>
> Ard Biesheuvel (5):
> EmbeddedPkg: remove DwEmmcDxe host controller driver
> EmbeddedPkg: remove Lan91x network controller driver
> EmbeddedPkg: remove Lan9118 network controller driver
> EmbeddedPkg: remove SiI3132 SATA controller driver
> EmbeddedPkg: remove ISP 1716 USB host controller driver
Many thanks for this! For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> EmbeddedPkg/EmbeddedPkg.dec | 23 -
> EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf | 49 -
> .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf | 38 -
> EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf | 51 -
> EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf | 52 -
> .../Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf | 42 -
> EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h | 127 -
> .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h | 116 -
> EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h | 297 ---
> EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h | 394 ---
> .../Drivers/Lan9118Dxe/Lan9118DxeUtil.h | 276 --
> EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h | 272 --
> .../Drivers/SataSiI3132Dxe/SataSiI3132.h | 279 ---
> EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 688 -----
> .../Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c | 629 -----
> EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c | 1532 -----------
> .../Drivers/Lan9118Dxe/Lan9118DxeUtil.c | 1032 --------
> EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c | 2229 -----------------
> .../Drivers/SataSiI3132Dxe/ComponentName.c | 172 --
> .../Drivers/SataSiI3132Dxe/SataSiI3132.c | 539 ----
> .../SataSiI3132Dxe/SiI3132AtaPassThru.c | 827 ------
> 21 files changed, 9664 deletions(-)
> delete mode 100644 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf
> delete mode 100644 EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.inf
> delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.inf
> delete mode 100644 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.inf
> delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132Dxe.inf
> delete mode 100644 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmc.h
> delete mode 100644 EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.h
> delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.h
> delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeHw.h
> delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.h
> delete mode 100644 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxeHw.h
> delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h
> delete mode 100644 EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
> delete mode 100644 EmbeddedPkg/Drivers/Isp1761UsbDxe/Isp1761UsbDxe.c
> delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c
> delete mode 100644 EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118DxeUtil.c
> delete mode 100644 EmbeddedPkg/Drivers/Lan91xDxe/Lan91xDxe.c
> delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/ComponentName.c
> delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c
> delete mode 100644 EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 0/5] EmbeddedPkg spring cleaning
2020-05-05 14:08 ` Leif Lindholm
@ 2020-05-05 15:46 ` Ard Biesheuvel
0 siblings, 0 replies; 9+ messages in thread
From: Ard Biesheuvel @ 2020-05-05 15:46 UTC (permalink / raw)
To: Leif Lindholm; +Cc: devel, philmd
On 5/5/20 4:08 PM, Leif Lindholm wrote:
> On Mon, May 04, 2020 at 15:57:22 +0200, Ard Biesheuvel wrote:
>> Delete a couple of obsole driver from EmbeddedPkg. They have been moved
>> into edk2-platforms alongside the small set of development platforms
>> that still use them, but they are no long fit for use beyond that.
>>
>> Diffs have been omitted for files that are completely deleted. The full
>> set can be found here:
>> https://github.com/ardbiesheuvel/edk2/tree/embeddedpkg-spring-cleaning
>>
>> Ard Biesheuvel (5):
>> EmbeddedPkg: remove DwEmmcDxe host controller driver
>> EmbeddedPkg: remove Lan91x network controller driver
>> EmbeddedPkg: remove Lan9118 network controller driver
>> EmbeddedPkg: remove SiI3132 SATA controller driver
>> EmbeddedPkg: remove ISP 1716 USB host controller driver
>
> Many thanks for this! For the series:
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>
Cheers
Pushed this, along with the PL180 one you acked earlier.
https://github.com/tianocore/edk2/pull/577
^ permalink raw reply [flat|nested] 9+ messages in thread