From: "Miki Shindo" <miki.shindo@intel.com>
To: devel@edk2.groups.io
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>,
Chasel Chiu <chasel.chiu@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Prince Agyeman <prince.agyeman@intel.com>,
Ray Ni <ray.ni@intel.com>
Subject: [edk2-platforms:PATCH v5 2/7] KabylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib
Date: Tue, 5 May 2020 20:16:45 -0700 [thread overview]
Message-ID: <20200506031650.55020-3-miki.shindo@intel.com> (raw)
In-Reply-To: <20200506031650.55020-1-miki.shindo@intel.com>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2536
This commit removes redundant InitializeAslUpdateLib call
as DxeAslUpdateLib itself calls it internally.
Signed-off-by: Miki Shindo <miki.shindo@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Acked-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
---
Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c
index 13a687576c..d101f4bb75 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c
@@ -1,6 +1,6 @@
/** @file
-Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2018 - 2020, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -125,9 +125,6 @@ TbtAcpiEndOfDxeCallback (
UINT16 Length;
UINT32 Signature;
- Status = InitializeAslUpdateLib ();
- ASSERT_EFI_ERROR (Status);
-
Address = (UINT32) (UINTN) mTbtNvsAreaProtocol.Area;
Length = (UINT16) sizeof (TBT_NVS_AREA);
DEBUG ((DEBUG_INFO, "Patch TBT NvsAreaAddress: TBT NVS Address %x Length %x\n", Address, Length));
--
2.16.2.windows.1
next prev parent reply other threads:[~2020-05-06 3:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 3:16 [edk2-platforms:PATCH v5 0/7] IntelSiliconPkg DxeAslUpdateLib support Miki Shindo
2020-05-06 3:16 ` [edk2-platforms:PATCH v5 1/7] WhiskeylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Miki Shindo
2020-05-06 21:52 ` Chaganty, Rangasai V
2020-05-06 3:16 ` Miki Shindo [this message]
2020-05-06 21:52 ` [edk2-platforms:PATCH v5 2/7] KabylakeOpenBoardPkg/TbtDxe: " Chaganty, Rangasai V
2020-05-06 3:16 ` [edk2-platforms:PATCH v5 3/7] CometlakeOpenBoardPkg/TbtDxe: " Miki Shindo
2020-05-06 21:52 ` Chaganty, Rangasai V
2020-05-06 3:16 ` [edk2-platforms:PATCH v5 4/7] MinPlatformPkg/DxeAslUpdateLib: Cleans up APIs Miki Shindo
2020-05-06 21:53 ` Chaganty, Rangasai V
2020-05-06 3:16 ` [edk2-platforms:PATCH v5 5/7] KabylakeSiliconPkg/DxeAslUpdateLib: " Miki Shindo
2020-05-06 21:53 ` Chaganty, Rangasai V
2020-05-06 3:16 ` [edk2-platforms:PATCH v5 6/7] CoffeelakeSiliconPkg/DxeAslUpdateLib: " Miki Shindo
2020-05-06 21:54 ` Chaganty, Rangasai V
2020-05-06 3:16 ` [edk2-platforms:PATCH v5 7/7] IntelSiliconPkg/DxeAslUpdateLib: Add DxeAslUpdateLib support Miki Shindo
2020-05-06 21:54 ` Chaganty, Rangasai V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506031650.55020-3-miki.shindo@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox