From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by mx.groups.io with SMTP id smtpd.web10.105.1588783932679659007 for ; Wed, 06 May 2020 09:52:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@bsdio.com header.s=xmission header.b=Bb6jnyOY; spf=pass (domain: bsdio.com, ip: 166.70.13.232, mailfrom: rebecca@bsdio.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=bsdio.com; s=xmission; h=Subject:Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BDRzrXHD+8rmR8Hqh7yq7PdcDi4QmaNZZ5INBSW1vZE=; b=Bb6jnyOYTat8XpvMH9Nj0iayw+ UUgdz4SqBQO8yN5eKQkb+4rlQmXR3oGypwVOIG5TqJHuUKkRUmtXIt9DKmpDiukWyxb7sRbMpQHHl te2xZFsrIn8n3lOJsTXwz9nLGAMEeO/aBy/yUQiaBedY3FHTVjMBa+X5mjANCl9ukcUs=; Received: from in01.mta.xmission.com ([166.70.13.51]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jWNHH-0004n9-0r; Wed, 06 May 2020 10:52:11 -0600 Received: from mta5.zcs.xmission.com ([166.70.13.69]) by in01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jWNHG-0002WW-AW; Wed, 06 May 2020 10:52:10 -0600 Received: from localhost (localhost [127.0.0.1]) by mta5.zcs.xmission.com (Postfix) with ESMTP id DF46F1280830; Wed, 6 May 2020 10:52:09 -0600 (MDT) X-Amavis-Modified: Mail body modified (using disclaimer) - mta5.zcs.xmission.com Received: from mta5.zcs.xmission.com ([127.0.0.1]) by localhost (mta5.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Wmv7ZhrCxafc; Wed, 6 May 2020 10:52:09 -0600 (MDT) Received: from photon.int.bluestop.org (c-174-52-16-57.hsd1.ut.comcast.net [174.52.16.57]) by mta5.zcs.xmission.com (Postfix) with ESMTPSA id 1D342128014F; Wed, 6 May 2020 10:52:09 -0600 (MDT) From: "Rebecca Cran" To: devel@edk2.groups.io Cc: Rebecca Cran , Ray Ni , Zhichao Gao , Philippe Mathieu-Daude Date: Wed, 6 May 2020 10:52:05 -0600 Message-Id: <20200506165205.17360-1-rebecca@bsdio.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-XM-SPF: eid=1jWNHG-0002WW-AW;;;mid=<20200506165205.17360-1-rebecca@bsdio.com>;;;hst=in01.mta.xmission.com;;;ip=166.70.13.69;;;frm=rebecca@bsdio.com;;;spf=pass X-SA-Exim-Connect-IP: 166.70.13.69 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa02.xmission.com X-Spam-Level: X-Spam-Status: No, score=0.5 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TooManySym_01,XMSubLong autolearn=disabled version=3.4.2 X-Spam-Virus: No X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 0.7 XMSubLong Long Subject * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa02 0; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: ; sa02 0; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;devel@edk2.groups.io X-Spam-Relay-Country: X-Spam-Timing: total 319 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 3.8 (1.2%), b_tie_ro: 2.7 (0.9%), parse: 0.72 (0.2%), extract_message_metadata: 13 (4.1%), get_uri_detail_list: 1.09 (0.3%), tests_pri_-1000: 10 (3.3%), tests_pri_-950: 1.02 (0.3%), tests_pri_-900: 0.79 (0.2%), tests_pri_-90: 49 (15.4%), check_bayes: 48 (15.1%), b_tokenize: 6 (1.8%), b_tok_get_all: 5 (1.7%), b_comp_prob: 1.25 (0.4%), b_tok_touch_all: 33 (10.5%), b_finish: 0.66 (0.2%), tests_pri_0: 231 (72.4%), check_dkim_signature: 0.38 (0.1%), check_dkim_adsp: 45 (14.0%), poll_dns_idle: 36 (11.3%), tests_pri_10: 1.67 (0.5%), tests_pri_500: 5 (1.7%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH v2 1/1] ShellPkg: smbiosview - print field values as unsigned integers X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Content-Transfer-Encoding: 8bit This prevents overflow when printing DWORD fields such as the type 17 tables's extended DIMM size. Signed-off-by: Rebecca Cran Cc: Ray Ni Cc: Zhichao Gao Cc: Philippe Mathieu-Daude --- .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index a75caff3de34..1ea7b84bd0fa 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -49,7 +49,7 @@ #define PRINT_STRUCT_VALUE(pStruct, type, element) \ do { \ ShellPrintEx(-1,-1,L"%a",#element); \ - ShellPrintEx(-1,-1,L": %d\n", (pStruct->type->element)); \ + ShellPrintEx(-1,-1,L": %u\n", (pStruct->type->element)); \ } while (0); #define PRINT_STRUCT_VALUE_H(pStruct, type, element) \ @@ -634,8 +634,8 @@ SmbiosPrintStructure ( NumOfItem = (Struct->Type14->Hdr.Length - 5) / 3; PRINT_PENDING_STRING (Struct, Type14, GroupName); for (Index = 0; Index < NumOfItem; Index++) { - ShellPrintEx(-1,-1,L"ItemType %d: %d\n", Index + 1, Struct->Type14->Group[Index].ItemType); - ShellPrintEx(-1,-1,L"ItemHandle %d: %d\n", Index + 1, Struct->Type14->Group[Index].ItemHandle); + ShellPrintEx(-1,-1,L"ItemType %u: %u\n", Index + 1, Struct->Type14->Group[Index].ItemType); + ShellPrintEx(-1,-1,L"ItemHandle %u: %u\n", Index + 1, Struct->Type14->Group[Index].ItemHandle); } } break; -- 2.26.2